From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web08.5296.1654556374040115729
 for <devel@edk2.groups.io>;
 Mon, 06 Jun 2022 15:59:34 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=r5t1nPKO;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.195.228.134])
	by linux.microsoft.com (Postfix) with ESMTPSA id DDED620BE623;
	Mon,  6 Jun 2022 15:59:32 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DDED620BE623
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1654556373;
	bh=p4MK0b56t0YLbkNYJtNC8PRV9zQyPdR7Y8k+iUPD/eU=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=r5t1nPKOPLo3PWqnxm92NKIMmX+/6W80gUWla+OLizy9EeR7ShUf/a5IRiS7M+HDk
	 PRGvq1Eoo9KJgqKL+rIrdjavkpujbsRH6gDUB2DNoVz4pRNaNwrlu07C+IhVw2wA4I
	 8mNDxa5AQ7JYJSz9MINY7tYWanYg9hN+Nh6X0L/4=
Message-ID: <d42a5599-ac88-376a-f0e6-135690cfd1e3@linux.microsoft.com>
Date: Mon, 6 Jun 2022 18:59:32 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1 4/4] TigerlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT
To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>,
 Ankit Sinha <ankit.sinha@intel.com>,
 Michael Kubacki <michael.kubacki@microsoft.com>,
 Heng Luo <heng.luo@intel.com>
References: <20220606225030.3403-1-nathaniel.l.desimone@intel.com>
 <20220606225030.3403-5-nathaniel.l.desimone@intel.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20220606225030.3403-5-nathaniel.l.desimone@intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 6/6/2022 6:50 PM, Nate DeSimone wrote:
> Set the location of the DUTY_CYCLE field in the P_CNT register
> and indicate the width of the clock duty cycle to OS power management
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Cc: Heng Luo <heng.luo@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>   .../TigerlakeURvp/OpenBoardPkgPcd.dsc                  | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> index ebbbc7b9f9..aba3c8d6d0 100644
> --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> +++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> @@ -1,7 +1,7 @@
>   ## @file
>   #  PCD configuration build description file for the TigerlakeURvp board.
>   #
> -#  Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
> +#  Copyright (c) 2021 - 2022, Intel Corporation. All rights reserved.<BR>
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
>   ##
> @@ -118,6 +118,14 @@
>     gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000
>   #!endif
>     gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeiStackSize|0x40000
> +
> +  #
> +  # Set the location of the DUTY_CYCLE field in the P_CNT register
> +  # and indicate the width of the clock duty cycle to OS power management
> +  #
> +  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset|0x1
> +  gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth|0x3
> +
>   [PcdsFeatureFlag.common]
>     ######################################
>     # Edk2 Configuration