From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A327EAC110D for ; Tue, 6 Feb 2024 14:56:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Pjd6+iJrsdARRC7Y+XiyKPA+PvJFLo6akv/wfvDACkY=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1707231387; v=1; b=fGEdqgGBk9F9U+0GON5dPVfF9Tv8W93E3JSgo845pbBhqoAi+vJjQxO4NqcEcQ95qIMES6hv g2kHKwkzRXEKb+UeLd+iRUZ+ysUniO022HT0A/XWd3/Mr+AdGbVevHgpam29K7/e6DVxpBux5E4 /07DoMsJBecG9IUi1arK3gAg= X-Received: by 127.0.0.2 with SMTP id 6erEYY7687511xkbfMmWUk5t; Tue, 06 Feb 2024 06:56:27 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mx.groups.io with SMTP id smtpd.web11.19781.1707220900490782065 for ; Tue, 06 Feb 2024 04:01:41 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="619547" X-IronPort-AV: E=Sophos;i="6.05,247,1701158400"; d="scan'208";a="619547" X-Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2024 04:01:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,247,1701158400"; d="scan'208";a="1031108" X-Received: from saiphani-mobl.gar.corp.intel.com ([10.213.97.135]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2024 04:01:38 -0800 From: "Sai Phanindra Gandikota" To: devel@edk2.groups.io Cc: Gandikota Sai Phanindra <102981786+saiphanindrag@users.noreply.github.com>, Hao A Wu , Liming Gao , Sai Phanindra Gandikota Subject: [edk2-devel] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update switch to highspeed timing flow Date: Tue, 6 Feb 2024 17:29:03 +0530 Message-Id: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sai.phanindra.gandikota@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kSvC2Mpu4NOpRRd8TY9t6L9Xx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fGEdqgGB; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Gandikota Sai Phanindra <102981786+saiphanindrag@users.noreply.github.com> Switch to DDR50 speed mode is failing with the existing code flow. Exiting flow sets Bus width first then bus timing and clock frequency, with this flow switch to DDR50 speed mode is failing. After updating the flow to set the bus timing and clock frequency then bus width resolved the issue and switch to DDR50 is successful. Cc: Hao A Wu Cc: Liming Gao Signed-off-by: Sai Phanindra Gandikota --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c index a392a4e31a..2bca6da3db 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c @@ -833,12 +833,12 @@ EmmcSwitchToHighSpeed ( IsDdr = FALSE; } - Status = EmmcSwitchBusWidth (PciIo, PassThru, Slot, Rca, IsDdr, BusMode->BusWidth); + Status = EmmcSwitchBusTiming (PciIo, PassThru, Slot, Rca, BusMode->DriverStrength, BusMode->BusTiming, BusMode->ClockFreq); if (EFI_ERROR (Status)) { return Status; } - return EmmcSwitchBusTiming (PciIo, PassThru, Slot, Rca, BusMode->DriverStrength, BusMode->BusTiming, BusMode->ClockFreq); + return EmmcSwitchBusWidth (PciIo, PassThru, Slot, Rca, IsDdr, BusMode->BusWidth); } /** -- 2.38.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115171): https://edk2.groups.io/g/devel/message/115171 Mute This Topic: https://groups.io/mt/104198932/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-