public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: Ashish Singhal <ashishsingha@nvidia.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser
Date: Fri, 31 Jan 2020 05:32:56 +0000	[thread overview]
Message-ID: <d47eb94994e84ce88e3bd34944f1e1a3@intel.com> (raw)
In-Reply-To: <CY4PR1201MB013472ACDAD55D6EDDD8CCBABA0B0@CY4PR1201MB0134.namprd12.prod.outlook.com>

Actually I have no permission to create the pull request. I would help to send the patch to Ray and he would create the pull request.

Thanks,
Zhichao

> -----Original Message-----
> From: Ashish Singhal [mailto:ashishsingha@nvidia.com]
> Sent: Tuesday, January 28, 2020 1:29 AM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io; Ni, Ray
> <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix
> FADT Parser
> 
> Hello Zhichao,
> 
> Do you know by when this may be merged?
> 
> Thanks
> Ashish
> 
> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Monday, January 20, 2020 12:42 AM
> To: devel@edk2.groups.io; Ashish Singhal <ashishsingha@nvidia.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix
> FADT Parser
> 
> External email: Use caution opening links or attachments
> 
> 
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Ashish Singhal
> > Sent: Monday, January 20, 2020 1:45 PM
> > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> > <zhichao.gao@intel.com>
> > Cc: Ashish Singhal <ashishsingha@nvidia.com>
> > Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib:
> > Fix FADT Parser
> >
> > FADT parser was checking for reduced ACPI flag incorrectly leading to
> > incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL are both
> > 0.
> >
> > Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
> > ---
> >  .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c       | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> > c
> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> > c
> > index 5b8cc174f1..8acfbac3b1 100644
> > ---
> > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> > c
> > +++
> > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars
> > +++ er.c
> > @@ -253,7 +253,7 @@ ParseAcpiFadt (
> >      // present.
> >      if ((Trace) &&
> >          (Flags != NULL) &&
> > -        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) != 0)) {
> > +        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=
> > + EFI_ACPI_6_3_HW_REDUCED_ACPI)) {
> >        IncrementErrorCount ();
> >        Print (L"ERROR: No FACS table found, "
> >                 L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are
> > zero.\n");
> > --
> > 2.17.1
> >
> >
> > 
> 
> -----------------------------------------------------------------------------------
> This email message is for the sole use of the intended recipient(s) and may
> contain confidential information.  Any unauthorized review, use, disclosure or
> distribution is prohibited.  If you are not the intended recipient, please contact
> the sender by reply email and destroy all copies of the original message.
> -----------------------------------------------------------------------------------

  reply	other threads:[~2020-01-31  5:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20  5:44 [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Ashish Singhal
2020-01-20  7:42 ` [edk2-devel] " Gao, Zhichao
2020-01-27 17:28   ` Ashish Singhal
2020-01-31  5:32     ` Gao, Zhichao [this message]
2020-02-10 17:39       ` Ashish Singhal
2020-02-11  2:54         ` Gao, Zhichao
2020-02-11  5:22           ` Ashish Singhal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d47eb94994e84ce88e3bd34944f1e1a3@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox