From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.232.1580448778509448645 for ; Thu, 30 Jan 2020 21:32:58 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zhichao.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2020 21:32:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,384,1574150400"; d="scan'208";a="253238600" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 30 Jan 2020 21:32:58 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jan 2020 21:32:58 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 31 Jan 2020 13:32:56 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Fri, 31 Jan 2020 13:32:56 +0800 From: "Gao, Zhichao" To: Ashish Singhal , "devel@edk2.groups.io" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Thread-Topic: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Thread-Index: AQHVz1S5ttTJJxpElEylwh7oCb4WnKfzKyOggAsekwCABgclcA== Date: Fri, 31 Jan 2020 05:32:56 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Actually I have no permission to create the pull request. I would help to s= end the patch to Ray and he would create the pull request. Thanks, Zhichao > -----Original Message----- > From: Ashish Singhal [mailto:ashishsingha@nvidia.com] > Sent: Tuesday, January 28, 2020 1:29 AM > To: Gao, Zhichao ; devel@edk2.groups.io; Ni, Ray > > Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: = Fix > FADT Parser >=20 > Hello Zhichao, >=20 > Do you know by when this may be merged? >=20 > Thanks > Ashish >=20 > -----Original Message----- > From: Gao, Zhichao > Sent: Monday, January 20, 2020 12:42 AM > To: devel@edk2.groups.io; Ashish Singhal ; Ni, = Ray > > Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: = Fix > FADT Parser >=20 > External email: Use caution opening links or attachments >=20 >=20 > Reviewed-by: Zhichao Gao >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Ashish Singhal > > Sent: Monday, January 20, 2020 1:45 PM > > To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao > > > > Cc: Ashish Singhal > > Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: > > Fix FADT Parser > > > > FADT parser was checking for reduced ACPI flag incorrectly leading to > > incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL are both > > 0. > > > > Signed-off-by: Ashish Singhal > > --- > > .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 2 += - > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser= . > > c > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser= . > > c > > index 5b8cc174f1..8acfbac3b1 100644 > > --- > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser= . > > c > > +++ > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars > > +++ er.c > > @@ -253,7 +253,7 @@ ParseAcpiFadt ( > > // present. > > if ((Trace) && > > (Flags !=3D NULL) && > > - ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D 0)) { > > + ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D > > + EFI_ACPI_6_3_HW_REDUCED_ACPI)) { > > IncrementErrorCount (); > > Print (L"ERROR: No FACS table found, " > > L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are > > zero.\n"); > > -- > > 2.17.1 > > > > > >=20 >=20 > ------------------------------------------------------------------------= ----------- > This email message is for the sole use of the intended recipient(s) and = may > contain confidential information. Any unauthorized review, use, disclos= ure or > distribution is prohibited. If you are not the intended recipient, plea= se contact > the sender by reply email and destroy all copies of the original message= . > ------------------------------------------------------------------------= -----------