public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>, Andrew Fish <afish@apple.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ShellPkg: Create a homefilesystem environment variable
Date: Fri, 5 Oct 2018 13:32:34 +0200	[thread overview]
Message-ID: <d486a802-2e99-2867-6ad7-09893859f2af@redhat.com> (raw)
In-Reply-To: <CB6E33457884FA40993F35157061515CA415C763@FMSMSX103.amr.corp.intel.com>

On 10/04/18 22:54, Carsey, Jaben wrote:
> Laszlo,
> 
> The leading "_" was required for out of spec, but built in, commands.  The spec has no restrictions on environment variables except some have special meaning and may be read only.
> 
> I can certainly work on slowing down the process.  I have been complaining about that same thing and should have been more aware.  I would like to have a community minimum amount of time before commits are done that we all agree to.  Something like 1 full day would be nice I think.

Good idea! I believe 24 hours should be tolerable on all ends. It also
gives a chance to people in other time zones to comment.

I think there should be one exception: grave regressions -- build
failures, or total boot failures -- should be possible to revert (or
fix) as soon as there's one review.

Thanks!
Laszlo


  reply	other threads:[~2018-10-05 11:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03 16:02 [PATCH] ShellPkg: Create a homefilesystem environment variable Jim.Dailey
2018-10-03 18:15 ` Carsey, Jaben
2018-10-03 18:17 ` Carsey, Jaben
2018-10-04 17:07   ` Laszlo Ersek
2018-10-04 19:05     ` Jim.Dailey
2018-10-04 19:20       ` Laszlo Ersek
2018-10-04 19:19     ` Andrew Fish
2018-10-04 20:54       ` Carsey, Jaben
2018-10-05 11:32         ` Laszlo Ersek [this message]
2018-10-05 12:19           ` Tim Lewis
2018-10-09  4:33             ` Ni, Ruiyu
2018-10-05 15:00           ` Carsey, Jaben
2018-10-05 17:47             ` Laszlo Ersek
2018-10-08  6:42 ` Ni, Ruiyu
2018-10-08 13:58   ` Jim.Dailey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d486a802-2e99-2867-6ad7-09893859f2af@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox