From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id F06DE2194D3AE
 for <edk2-devel@lists.01.org>; Fri,  5 Oct 2018 04:32:37 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
 [10.5.11.22])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 7BC2483F51;
 Fri,  5 Oct 2018 11:32:36 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-170.rdu2.redhat.com
 [10.10.121.170])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 910AD1057044;
 Fri,  5 Oct 2018 11:32:35 +0000 (UTC)
To: "Carsey, Jaben" <jaben.carsey@intel.com>, Andrew Fish <afish@apple.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
References: <ae7ca27cc6ff410586d9065a9b2c43f3@ausx13mps335.AMER.DELL.COM>
 <CB6E33457884FA40993F35157061515CA415B95D@FMSMSX103.amr.corp.intel.com>
 <c86b2f5a-a642-ecc4-e5e9-f88296065888@redhat.com>
 <E8FEE5BC-C48C-4DD5-B0FC-F3269BE9DFDB@apple.com>
 <CB6E33457884FA40993F35157061515CA415C763@FMSMSX103.amr.corp.intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <d486a802-2e99-2867-6ad7-09893859f2af@redhat.com>
Date: Fri, 5 Oct 2018 13:32:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CB6E33457884FA40993F35157061515CA415C763@FMSMSX103.amr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.27]); Fri, 05 Oct 2018 11:32:36 +0000 (UTC)
Subject: Re: [PATCH] ShellPkg: Create a homefilesystem environment variable
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Oct 2018 11:32:38 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 10/04/18 22:54, Carsey, Jaben wrote:
> Laszlo,
> 
> The leading "_" was required for out of spec, but built in, commands.  The spec has no restrictions on environment variables except some have special meaning and may be read only.
> 
> I can certainly work on slowing down the process.  I have been complaining about that same thing and should have been more aware.  I would like to have a community minimum amount of time before commits are done that we all agree to.  Something like 1 full day would be nice I think.

Good idea! I believe 24 hours should be tolerable on all ends. It also
gives a chance to people in other time zones to comment.

I think there should be one exception: grave regressions -- build
failures, or total boot failures -- should be possible to revert (or
fix) as soon as there's one review.

Thanks!
Laszlo