From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 02F4D941951 for ; Fri, 10 Nov 2023 15:25:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LTS5tUy+Wi4lZK5sBgJxVuUdZSOWN3+3Oo+dqSHKSO8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699629922; v=1; b=TUU27WgliOJXqy+A2TZqkX+j/mro845Qr5r11x3ycsvqMDkzeckuQv8d4uXSHtkbG2KWDT0C 3PwODJsm7FR05tvQIuqk8R0jTyMCJD6BKG34ml54e73KA/XvBduszTRViyuoC/kATkgxRuXg9Qd iUDwq75EYqLStCSROkYGqV7M= X-Received: by 127.0.0.2 with SMTP id nHrOYY7687511xVve5OoGJgO; Fri, 10 Nov 2023 07:25:22 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.30235.1699629921839474934 for ; Fri, 10 Nov 2023 07:25:22 -0800 X-Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AAExoP9003805; Fri, 10 Nov 2023 15:25:10 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u9pq8g1tp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Nov 2023 15:25:10 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AAFP9Ln002828 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Nov 2023 15:25:09 GMT X-Received: from [10.111.128.58] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Fri, 10 Nov 2023 07:25:07 -0800 Message-ID: Date: Fri, 10 Nov 2023 15:25:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION To: Pierre Gondois CC: , Sami Mujawar , Ard Biesheuvel , Michael D Kinney , Liming Gao References: <20231025112540.1654844-1-pierre.gondois@arm.com> <20231025112540.1654844-2-pierre.gondois@arm.com> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: BxKvVxByfRFkqIKqMW8QxLdskY4aF-u5 X-Proofpoint-GUID: BxKvVxByfRFkqIKqMW8QxLdskY4aF-u5 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 3AAExoP9003805 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QlgaA17qKVfwjq1kVt8gKBUpx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TUU27Wgl; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2023-11-10 09:11, Pierre Gondois wrote: > Hello Leif, >=20 > On 11/2/23 11:20, Pierre Gondois wrote: >> Hello Leif, >> Thanks for the review, >> >> On 10/26/23 12:05, Leif Lindholm wrote: >>> On Wed, Oct 25, 2023 at 13:25:30 +0200, pierre.gondois@arm.com wrote: >>>> From: Pierre Gondois >>>> >>>> Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different >>>> versions of the protocol. The macro is neither used in edk2 nor >>>> in edk2-platforms. >>> >>> OK, so slight nitpick, but mainly because it parses a bit weirdly... >>> *Will* it be used after this series is merged, or is this an update >>> for completeness? >> >> The 'fast channels' were added in the v2.0 SCMI specification. This=20 >> patch-set >> relies on this feature, so it is checked in: >> =C2=A0=C2=A0=C2=A0=C2=A0 [PATCH v2 10/11] DynamicTablesPkg: Add ArmScmiI= nfoLib >> that the underlying SCP is at least at this version. >> >> ``` >> =C2=A0=C2=A0=C2=A0=C2=A0 // FastChannels were added in SCMI v2.0 spec. >> =C2=A0=C2=A0=C2=A0=C2=A0 if (Version < PERFORMANCE_PROTOCOL_VERSION_V2) = { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DEBUG ((DEBUG_ERROR, "ArmScmiInfoLi= b requires SCMI version >=20 >> 2.0\n")); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return EFI_UNSUPPORTED; >> =C2=A0=C2=A0=C2=A0=C2=A0 } >> ``` >> >>> >>>> Signed-off-by: Pierre Gondois >>>> --- >>>> =C2=A0=C2=A0 ArmPkg/Include/Library/ArmLib.h=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 |=C2=A0 1 + >>>> =C2=A0=C2=A0 .../Include/Protocol/ArmScmiPerformanceProtocol.h=C2=A0= =C2=A0 | 13=20 >>>> ++++++++----- >>>> =C2=A0=C2=A0 2 files changed, 9 insertions(+), 5 deletions(-) >>>> >>>> diff --git a/ArmPkg/Include/Library/ArmLib.h=20 >>>> b/ArmPkg/Include/Library/ArmLib.h >>>> index 0169dbc1092c..7b2b2238fed9 100644 >>>> --- a/ArmPkg/Include/Library/ArmLib.h >>>> +++ b/ArmPkg/Include/Library/ArmLib.h >>>> @@ -780,6 +780,7 @@ EFIAPI >>>> =C2=A0=C2=A0 ArmHasVhe ( >>>> =C2=A0=C2=A0=C2=A0=C2=A0 VOID >>>> =C2=A0=C2=A0=C2=A0=C2=A0 ); >>>> + >>>> =C2=A0=C2=A0 #endif // MDE_CPU_AARCH64 >>>> =C2=A0=C2=A0 #ifdef MDE_CPU_ARM >>>> diff --git a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h=20 >>>> b/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h >>>> index 7e548e4765c2..8e8e05d5a5f6 100644 >>>> --- a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h >>>> +++ b/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h >>>> @@ -1,12 +1,12 @@ >>>> =C2=A0=C2=A0 /** @file >>>> -=C2=A0 Copyright (c) 2017-2021, Arm Limited. All rights reserved. >>>> +=C2=A0 Copyright (c) 2017-2023, Arm Limited. All rights reserved. >>>> =C2=A0=C2=A0=C2=A0=C2=A0 SPDX-License-Identifier: BSD-2-Clause-Patent >>>> -=C2=A0 System Control and Management Interface V1.0 >>>> -=C2=A0=C2=A0=C2=A0 http://infocenter.arm.com/help/topic/com.arm.doc.d= en0056a/ >>>> -=C2=A0=C2=A0=C2=A0 DEN0056A_System_Control_and_Management_Interface.p= df >>>> +=C2=A0 System Control and Management Interface, latest version: >>> >>> I see this as a pattern throughout the series. >>> But this statement will at some point become untrue; this >>> implementation is written against a specific version. I think this >>> version shold be reflected in the comment. (And that applies >>> throughout the series.) >>> >>>> +=C2=A0 - https://developer.arm.com/documentation/den0056/latest/ >>> >>> But I think the above is the most useful link. >=20 > I was referring to this point I'm not sure I understood. Oh, right. I was referring to "latest version" being a moving target. If I go to https://developer.arm.com/documentation/den0056/latest/, that=20 currently means "version 3.2". At some point in the future, that number=20 will change, but this code won't automatically get updated. So I'd prefer something like "System Control and Management Interface v3.2, Latest version of the specification can be downloaded from https://developer.arm.com/documentation/den0056/latest/" If that makes more sense? Regards, Leif > Regards, > Pierre >=20 >> >> I am not sure I understand completely. Do you mean that the SCMI >> structures/interfaces defined in: >> =C2=A0=C2=A0=C2=A0=C2=A0 ArmPkg/Include/Protocol/ArmScmiPerformanceProto= col.h >> and that were written against the SCMI v1.0 specification should >> not be used as such for other SCMI specification version ? >> I.e. the same process as for the AcpiXX.h files >> (MdePkg/Include/IndustryStandard/Acpi65.h) should be used ? >> >> Or do you mean that the _CPC object generation implies that the >> SCP should comply to the v2.0 version at least and this should be >> reflected in the commit messages ? >> >> Regards, >> Pierre >> >>> >>> / >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Leif >>> >>>> + >>>> =C2=A0=C2=A0 **/ >>>> =C2=A0=C2=A0 #ifndef ARM_SCMI_PERFORMANCE_PROTOCOL_H_ >>>> @@ -14,7 +14,10 @@ >>>> =C2=A0=C2=A0 #include >>>> -#define PERFORMANCE_PROTOCOL_VERSION=C2=A0 0x10000 >>>> +/// Arm Scmi performance protocol versions. >>>> +#define PERFORMANCE_PROTOCOL_VERSION_V1=C2=A0 0x10000 >>>> +#define PERFORMANCE_PROTOCOL_VERSION_V2=C2=A0 0x20000 >>>> +#define PERFORMANCE_PROTOCOL_VERSION_V3=C2=A0 0x30000 >>>> =C2=A0=C2=A0 #define ARM_SCMI_PERFORMANCE_PROTOCOL_GUID=C2=A0 { \ >>>> =C2=A0=C2=A0=C2=A0=C2=A0 0x9b8ba84, 0x3dd3, 0x49a6, {0xa0, 0x5a, 0x31,= 0x34, 0xa5, 0xf0,=20 >>>> 0x7b, 0xad} \ >>>> --=20 >>>> 2.25.1 >>>> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111038): https://edk2.groups.io/g/devel/message/111038 Mute This Topic: https://groups.io/mt/102175810/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-