public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure
@ 2018-07-19  4:50 Dandan Bi
  2018-07-19  4:57 ` Dong, Eric
  2018-07-19 12:04 ` Laszlo Ersek
  0 siblings, 2 replies; 4+ messages in thread
From: Dandan Bi @ 2018-07-19  4:50 UTC (permalink / raw)
  To: edk2-devel; +Cc: Eric Dong

Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 UefiCpuPkg/Library/MpInitLib/Microcode.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c b/UefiCpuPkg/Library/MpInitLib/Microcode.c
index efda143e67..9726172fbd 100644
--- a/UefiCpuPkg/Library/MpInitLib/Microcode.c
+++ b/UefiCpuPkg/Library/MpInitLib/Microcode.c
@@ -61,10 +61,12 @@ MicrocodeDetect (
   VOID                                    *MicrocodeData;
   MSR_IA32_PLATFORM_ID_REGISTER           PlatformIdMsr;
   UINT32                                  ProcessorFlags;
   UINT32                                  ThreadId;
 
+  ProcessorFlags = 0;
+
   if (CpuMpData->MicrocodePatchRegionSize == 0) {
     //
     // There is no microcode patches
     //
     return;
-- 
2.14.3.windows.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure
  2018-07-19  4:50 [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure Dandan Bi
@ 2018-07-19  4:57 ` Dong, Eric
  2018-07-19 12:04 ` Laszlo Ersek
  1 sibling, 0 replies; 4+ messages in thread
From: Dong, Eric @ 2018-07-19  4:57 UTC (permalink / raw)
  To: Bi, Dandan, edk2-devel@lists.01.org

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, July 19, 2018 12:51 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>
> Subject: [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/Microcode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c
> b/UefiCpuPkg/Library/MpInitLib/Microcode.c
> index efda143e67..9726172fbd 100644
> --- a/UefiCpuPkg/Library/MpInitLib/Microcode.c
> +++ b/UefiCpuPkg/Library/MpInitLib/Microcode.c
> @@ -61,10 +61,12 @@ MicrocodeDetect (
>    VOID                                    *MicrocodeData;
>    MSR_IA32_PLATFORM_ID_REGISTER           PlatformIdMsr;
>    UINT32                                  ProcessorFlags;
>    UINT32                                  ThreadId;
> 
> +  ProcessorFlags = 0;
> +
>    if (CpuMpData->MicrocodePatchRegionSize == 0) {
>      //
>      // There is no microcode patches
>      //
>      return;
> --
> 2.14.3.windows.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure
  2018-07-19  4:50 [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure Dandan Bi
  2018-07-19  4:57 ` Dong, Eric
@ 2018-07-19 12:04 ` Laszlo Ersek
  2018-07-19 14:18   ` Bi, Dandan
  1 sibling, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2018-07-19 12:04 UTC (permalink / raw)
  To: Dandan Bi, edk2-devel; +Cc: Eric Dong

Hi Dandan,

On 07/19/18 06:50, Dandan Bi wrote:
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/Microcode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c b/UefiCpuPkg/Library/MpInitLib/Microcode.c
> index efda143e67..9726172fbd 100644
> --- a/UefiCpuPkg/Library/MpInitLib/Microcode.c
> +++ b/UefiCpuPkg/Library/MpInitLib/Microcode.c
> @@ -61,10 +61,12 @@ MicrocodeDetect (
>    VOID                                    *MicrocodeData;
>    MSR_IA32_PLATFORM_ID_REGISTER           PlatformIdMsr;
>    UINT32                                  ProcessorFlags;
>    UINT32                                  ThreadId;
>  
> +  ProcessorFlags = 0;
> +
>    if (CpuMpData->MicrocodePatchRegionSize == 0) {
>      //
>      // There is no microcode patches
>      //
>      return;
> 

can you please add the comment from

  https://bugzilla.tianocore.org/show_bug.cgi?id=607

namely:

  //
  // set ProcessorFlags to suppress incorrect compiler/analyzer warnings
  //
  ProcessorFlags = 0;

Thanks!
Laszlo


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure
  2018-07-19 12:04 ` Laszlo Ersek
@ 2018-07-19 14:18   ` Bi, Dandan
  0 siblings, 0 replies; 4+ messages in thread
From: Bi, Dandan @ 2018-07-19 14:18 UTC (permalink / raw)
  To: Laszlo Ersek, edk2-devel@lists.01.org; +Cc: Dong, Eric

Sure.
I will add the comments before commit it.

Thanks,
Dandan

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
Sent: Thursday, July 19, 2018 8:04 PM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>
Subject: Re: [edk2] [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure

Hi Dandan,

On 07/19/18 06:50, Dandan Bi wrote:
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  UefiCpuPkg/Library/MpInitLib/Microcode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/UefiCpuPkg/Library/MpInitLib/Microcode.c b/UefiCpuPkg/Library/MpInitLib/Microcode.c
> index efda143e67..9726172fbd 100644
> --- a/UefiCpuPkg/Library/MpInitLib/Microcode.c
> +++ b/UefiCpuPkg/Library/MpInitLib/Microcode.c
> @@ -61,10 +61,12 @@ MicrocodeDetect (
>    VOID                                    *MicrocodeData;
>    MSR_IA32_PLATFORM_ID_REGISTER           PlatformIdMsr;
>    UINT32                                  ProcessorFlags;
>    UINT32                                  ThreadId;
>  
> +  ProcessorFlags = 0;
> +
>    if (CpuMpData->MicrocodePatchRegionSize == 0) {
>      //
>      // There is no microcode patches
>      //
>      return;
> 

can you please add the comment from

  https://bugzilla.tianocore.org/show_bug.cgi?id=607

namely:

  //
  // set ProcessorFlags to suppress incorrect compiler/analyzer warnings
  //
  ProcessorFlags = 0;

Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-07-19 14:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-19  4:50 [patch] UefiCpuPkg/MpInitLib: Fix VS2012 build failure Dandan Bi
2018-07-19  4:57 ` Dong, Eric
2018-07-19 12:04 ` Laszlo Ersek
2018-07-19 14:18   ` Bi, Dandan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox