public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>,
	Ankit Sinha <ankit.sinha@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Dongdong Zhang <zhangdongdong@eswincomputing.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Guomin Jiang <guomin.jiang@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Ray Ni <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>,
	Sean Brogan <sean.brogan@microsoft.com>,
	Supreeth Venkatesh <supreeth.venkatesh@arm.com>,
	Wei6 Xu <wei6.xu@intel.com>
Subject: Re: [PATCH v3 00/14] Fix new typos reported
Date: Thu, 15 Dec 2022 11:40:44 -0500	[thread overview]
Message-ID: <d4a4c4f6-a770-a82b-b43b-7e87d1103d29@linux.microsoft.com> (raw)
In-Reply-To: <20221214225252.1660-1-mikuback@linux.microsoft.com>

This series is revoked.

Dongdong, if you would like to still submit your patches, you can use 
your original series.

Thanks,
Michael

On 12/14/2022 5:52 PM, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3929
> 
> The 5.21.0 SpellCheck plugin update originally caused new typos to
> be reported that were originally missed.
> 
> These patches were deferred at the time. There's been renewed
> interest in getting these changes in to continue to improve spelling
> consistency in the codebase so it is rebased, integrates new patches,
> and updates the cspell version.
> 
> V3 changes:
>    1. Rebase series (and reopen BZ 3929)
>    2. Add patches from Dongdong Zhang
>    3. Update cspell and node versions
>    4. Disable spellcheck audit mode in ArmPkg and ArmVirtPkg
> 
> V2 changes:
>    1. Complete BZ 3929.
>    2. Lock the cspell version to v5.20.0 to prevent latest from
>       unexpectedly causing issues in the future.
>    3. Update the common word list in cspell.base.yaml to prevent package
>       level duplication in the future.
>    4. Set "allowCompoundWords" to "true" to better recognize compound words.
>    4. Include code review tags.
> 
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Dongdong Zhang <zhangdongdong@eswincomputing.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Wei6 Xu <wei6.xu@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Dongdong Zhang (3):
>    ArmPkg: Fix typos
>    ArmPlatformPkg: Fix typos
>    ArmVirtPkg: Fix typos
> 
> Michael Kubacki (11):
>    PrmPkg: Fix new typos reported
>    StandaloneMmPkg: Fix new typos reported
>    DynamicTablesPkg: Fix new typos reported
>    UnitTestFrameworkPkg: Fix new typos reported
>    FatPkg: Fix new typos reported
>    FmpDevicePkg: Fix new typos reported
>    ArmPkg: Ignore new typos reported
>    ArmVirtPkg: Add new ignored spelling errors
>    .azurepipelines: Update cspell version to 5.21.0
>    ArmPkg: Turn off spellcheck audit mode
>    ArmVirtPkg: Turn off spellcheck audit mode
> 
>   ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c                                                                      |  2 +-
>   ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c                                                    | 10 ++--
>   ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c                                                  |  2 +-
>   ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.c                                                |  6 +--
>   ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                                                      |  2 +-
>   ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c                                  |  2 +-
>   ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c                                                             |  2 +-
>   ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c                                                               |  6 +--
>   ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c                                         |  2 +-
>   ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c                                               |  2 +-
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c                                         |  2 +-
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c                             |  2 +-
>   DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c                                          |  2 +-
>   DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c                                                |  2 +-
>   DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c                                                    |  2 +-
>   DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepo.c                                     |  4 +-
>   DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.c                                       |  2 +-
>   DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c                                 |  2 +-
>   FatPkg/EnhancedFatDxe/FileSpace.c                                                                        |  2 +-
>   FatPkg/EnhancedFatDxe/ReadWrite.c                                                                        |  2 +-
>   FmpDevicePkg/Library/FmpDependencyLib/FmpDependencyLib.c                                                 |  2 +-
>   PrmPkg/Application/PrmInfo/PrmInfo.c                                                                     |  2 +-
>   PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib.c                                       |  2 +-
>   PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c                                                                       |  2 +-
>   StandaloneMmPkg/Core/Dependency.c                                                                        |  2 +-
>   StandaloneMmPkg/Core/Dispatcher.c                                                                        | 18 +++----
>   StandaloneMmPkg/Core/Handle.c                                                                            |  2 +-
>   UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.c                   | 18 +++----
>   UnitTestFrameworkPkg/Library/UnitTestBootLibNull/UnitTestBootLibNull.c                                   |  2 +-
>   UnitTestFrameworkPkg/Library/UnitTestBootLibUsbClass/UnitTestBootLibUsbClass.c                           |  2 +-
>   UnitTestFrameworkPkg/Library/UnitTestLib/Log.c                                                           |  2 +-
>   UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLib.c                                                   |  2 +-
>   UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTestUefiBootServicesTableLibImage.c    |  2 +-
>   UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTestUefiBootServicesTableLibProtocol.c |  2 +-
>   UnitTestFrameworkPkg/Test/UnitTest/Sample/SampleUnitTest/SampleUnitTest.c                                |  2 +-
>   .azurepipelines/templates/spell-check-prereq-steps.yml                                                   |  4 +-
>   ArmPkg/ArmPkg.ci.yaml                                                                                    | 56 ++++++++++++++++++--
>   ArmPkg/Include/Library/OemMiscLib.h                                                                      |  2 +-
>   ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S                                                            |  2 +-
>   ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S                                                          |  2 +-
>   ArmPkg/Library/SemihostLib/Arm/GccSemihost.S                                                             |  2 +-
>   ArmPlatformPkg/ArmPlatformPkg.dec                                                                        |  2 +-
>   ArmPlatformPkg/Include/Library/LcdPlatformLib.h                                                          |  2 +-
>   ArmVirtPkg/ArmVirt.dsc.inc                                                                               |  2 +-
>   ArmVirtPkg/ArmVirtPkg.ci.yaml                                                                            | 27 ++++++----
>   DynamicTablesPkg/DynamicTablesPkg.ci.yaml                                                                | 31 ++++++++---
>   DynamicTablesPkg/Include/Library/DynamicPlatRepoLib.h                                                    |  4 +-
>   DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.h                                          |  2 +-
>   DynamicTablesPkg/Library/FdtHwInfoParserLib/Gic/ArmGicDispatcher.h                                       |  2 +-
>   DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.h                                 |  2 +-
>   DynamicTablesPkg/Readme.md                                                                               |  4 +-
>   FatPkg/EnhancedFatDxe/Fat.h                                                                              |  2 +-
>   FatPkg/FatPkg.ci.yaml                                                                                    | 22 ++++++--
>   FmpDevicePkg/FmpDevicePkg.ci.yaml                                                                        |  4 ++
>   PrmPkg/Include/Library/PrmModuleDiscoveryLib.h                                                           |  2 +-
>   PrmPkg/PrmLoaderDxe/PrmAcpiTable.h                                                                       |  4 +-
>   PrmPkg/PrmPkg.ci.yaml                                                                                    |  9 ++++
>   StandaloneMmPkg/Core/StandaloneMmCore.h                                                                  |  2 +-
>   StandaloneMmPkg/Include/Guid/MmCoreData.h                                                                |  2 +-
>   StandaloneMmPkg/StandaloneMmPkg.ci.yaml                                                                  |  8 +++
>   UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTestUefiBootServicesTableLib.h         |  4 +-
>   UnitTestFrameworkPkg/PrivateInclude/Library/UnitTestBootLib.h                                            |  2 +-
>   UnitTestFrameworkPkg/PrivateInclude/UnitTestFrameworkTypes.h                                             |  2 +-
>   UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml                                                        | 31 +++++++----
>   64 files changed, 236 insertions(+), 124 deletions(-)
> 

  parent reply	other threads:[~2022-12-15 16:40 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 22:52 [PATCH v3 00/14] Fix new typos reported Michael Kubacki
2022-12-14 22:52 ` [PATCH v3 01/14] PrmPkg: " Michael Kubacki
2022-12-20  3:09   ` [edk2-devel] " Ankit Sinha
2022-12-20 22:19     ` Michael Kubacki
2022-12-14 22:52 ` [PATCH v3 02/14] StandaloneMmPkg: " Michael Kubacki
2022-12-14 22:52 ` [PATCH v3 03/14] DynamicTablesPkg: " Michael Kubacki
2022-12-14 22:52 ` [PATCH v3 04/14] UnitTestFrameworkPkg: " Michael Kubacki
2022-12-14 23:05   ` Michael D Kinney
2022-12-14 22:52 ` [PATCH v3 05/14] FatPkg: " Michael Kubacki
2022-12-14 23:07   ` [edk2-devel] " Michael D Kinney
2022-12-14 22:52 ` [PATCH v3 06/14] FmpDevicePkg: " Michael Kubacki
2022-12-14 23:05   ` Michael D Kinney
2022-12-14 22:52 ` [PATCH v3 07/14] ArmPkg: Ignore " Michael Kubacki
2022-12-14 22:52 ` [PATCH v3 08/14] ArmVirtPkg: Add new ignored spelling errors Michael Kubacki
2022-12-14 22:52 ` [PATCH v3 09/14] ArmPkg: Fix typos Michael Kubacki
2022-12-14 22:52 ` [PATCH v3 10/14] ArmPlatformPkg: " Michael Kubacki
2022-12-14 22:52 ` [PATCH v3 11/14] ArmVirtPkg: " Michael Kubacki
2022-12-14 22:52 ` [PATCH v3 12/14] .azurepipelines: Update cspell version to 5.21.0 Michael Kubacki
2022-12-14 23:06   ` [edk2-devel] " Michael D Kinney
2022-12-14 22:52 ` [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode Michael Kubacki
2022-12-14 23:07   ` Ard Biesheuvel
2022-12-14 23:21     ` Michael Kubacki
2022-12-14 23:24       ` Ard Biesheuvel
2022-12-15  0:04         ` [edk2-devel] " Michael Kubacki
2022-12-15  8:46           ` Ard Biesheuvel
2022-12-15 10:42           ` Leif Lindholm
2022-12-15 16:38             ` Michael Kubacki
2022-12-15 16:57               ` Michael D Kinney
2022-12-16 17:36                 ` Michael Kubacki
2023-01-04 10:37               ` Ard Biesheuvel
2023-01-06  2:46                 ` Michael Kubacki
2023-01-11 16:23                   ` Ard Biesheuvel
2023-01-13  1:50                     ` Michael Kubacki
2022-12-14 22:52 ` [PATCH v3 14/14] ArmVirtPkg: " Michael Kubacki
2022-12-15 16:40 ` Michael Kubacki [this message]
2022-12-16  2:35   ` [PATCH v3 00/14] Fix new typos reported Dongdong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4a4c4f6-a770-a82b-b43b-7e87d1103d29@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox