From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8EFBCD806DA for ; Tue, 19 Sep 2023 15:13:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZA9O+ccWiVZccLPEIy7ewzMrVpLCgKcKRLnq0uH2Lxs=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695136380; v=1; b=I58Q2u6TDRXgHuKXMxvWlwcrxPLqutLU7S4d3umKxr6DkpMHg3mCVMMYFzxQHjNXLVlFtvE7 Mytrge5tVokmLxPR+DCFs7Z8QEUOw2q8CJltvrTkQRkideikz3Bkjx7/hpADU6prC68ulTrWk8n v5wEB+UOBO9xN4dzQHGbAKjU= X-Received: by 127.0.0.2 with SMTP id WsDIYY7687511xuRJmS3iDVv; Tue, 19 Sep 2023 08:13:00 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.12106.1695136379798568968 for ; Tue, 19 Sep 2023 08:12:59 -0700 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id 86FD9212C493; Tue, 19 Sep 2023 08:12:58 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 86FD9212C493 Message-ID: Date: Tue, 19 Sep 2023 11:12:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb@kernel.org, Michael Kinney , Andrew Fish Cc: Sami Mujawar , Gerd Hoffmann References: <20230913170617.429-1-mikuback@linux.microsoft.com> <20230913170617.429-5-mikuback@linux.microsoft.com> <0c073095-9f42-c740-72d4-a74a8c1b4ccc@linux.microsoft.com> <991610c3-8d67-40f6-affa-32ef563b5fee@quicinc.com> From: "Michael Kubacki" In-Reply-To: <991610c3-8d67-40f6-affa-32ef563b5fee@quicinc.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ZNYUNP1Zq6lxNNiUdVmCVRwjx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=I58Q2u6T; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none) On 9/19/2023 10:52 AM, Leif Lindholm wrote: > On 2023-09-19 15:46, Ard Biesheuvel wrote: >> On Mon, 18 Sept 2023 at 22:35, Michael Kubacki >> wrote: >>> >>> Thanks Ard. I still need a Reviewed-by on this patch to complete the=20 >>> series. >> >> Actually, you don't but I suppose there is some difference of >> interpretation here. >> >> In the Linux community (where these tags originated), an ack from a >> maintainer means 'no objections, feel free to apply this to code that >> I maintain'. In this case, I am not 100% sure what the change means, >> so I am not comfortable claiming that I reviewed it, but given that >> this is your area of expertise rather than mine, I trust that you know >> what you are doing. Hence the acked-by. >> >> In other cases, I may rely on another person's expertise and their >> reviewed-by to decide whether or not to merge something, rather than >> review it myself. In this case, the acked-by is implied by the fact >> that I decided to merge the PR (and therefore somewhat redundant). But >> it comes down to the same thing. >> >> If there is a Tianocore rule that says every patch needs a reviewed-by >> from a maintainer, we should probably fix that. It is *not* the job of >> a maintainer to review everything (and this wouldn't scale to begin >> with) - rather, it is their job to ensure that everything that gets >> merged has been reviewed sufficiently, either by themselves or by >> other people they have confidence in. >=20 > I was under the impression we had this conversation a few years ago and= =20 > agreed a maintainer Ack was sufficient. Have we failed to document that= =20 > fact? >=20 I looked here: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Pr= ocess It would be great if we could explicitly state the process around each=20 tag either there or linked from there. Thanks, Michael > / > =C2=A0=C2=A0=C2=A0 Leif >=20 >>> On 9/13/2023 1:10 PM, Ard Biesheuvel wrote: >>>> On Wed, 13 Sept 2023 at 19:07, wrote: >>>>> >>>>> From: Michael Kubacki >>>>> >>>>> Adds a CI YAML entry to acknowledge a case where a macro is expanded >>>>> that contains a print specifier. >>>>> >>>>> Cc: Ard Biesheuvel >>>>> Cc: Leif Lindholm >>>>> Cc: Sami Mujawar >>>>> Cc: Gerd Hoffmann >>>>> Signed-off-by: Michael Kubacki >>>> >>>> Acked-by: Ard Biesheuvel >>>> >>>>> --- >>>>> =C2=A0=C2=A0 ArmVirtPkg/ArmVirtPkg.ci.yaml | 8 ++++++++ >>>>> =C2=A0=C2=A0 1 file changed, 8 insertions(+) >>>>> >>>>> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml=20 >>>>> b/ArmVirtPkg/ArmVirtPkg.ci.yaml >>>>> index 1e799dc4e194..506b0e72f0bb 100644 >>>>> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml >>>>> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml >>>>> @@ -125,5 +125,13 @@ >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ],=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # words to extend to= the dictionary for=20 >>>>> this package >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "IgnoreS= tandardPaths": [],=C2=A0=C2=A0 # Standard Plugin defined=20 >>>>> paths that should be ignore >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Additio= nalIncludePaths": [] # Additional paths to spell=20 >>>>> check (wildcards supported) >>>>> +=C2=A0=C2=A0=C2=A0 }, >>>>> + >>>>> +=C2=A0=C2=A0=C2=A0 "DebugMacroCheck": { >>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "StringSubstitutions": { >>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # DynamicTabl= esPkg/Include/ConfigurationManagerObject.h >>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # Reason: Exp= ansion of macro that contains a print=20 >>>>> specifier. >>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "FMT_CM_OBJEC= T_ID": "0x%lx" >>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>>>> =C2=A0=C2=A0 } >>>>> --=20 >>>>> 2.42.0.windows.2 >>>>> >>>> >>>> >>>> >>>> >> >> >> >> >> >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108848): https://edk2.groups.io/g/devel/message/108848 Mute This Topic: https://groups.io/mt/101341655/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-