From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by mx.groups.io with SMTP id smtpd.web11.15810.1598457917882229552 for ; Wed, 26 Aug 2020 09:05:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=JShtWXYo; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.218.43, mailfrom: vladimir.olovyannikov@broadcom.com) Received: by mail-ej1-f43.google.com with SMTP id d26so3639773ejr.1 for ; Wed, 26 Aug 2020 09:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=/W4ySu64Zp2iySQZQFxpyrjMq6MDDwL84m2yf2kl9Dc=; b=JShtWXYoE4fVjKFoLxGybixznIUd8hRcqYTtTJFJ1MitASr/otP4W66DFZ1s2Ruge7 7ONfZvVK+PaJoZmL0pawuvi26I41mpK5kSl11zMdCTqhtNMovqnXZvQ5gOPNl40J9T1B KeTemxb3+btP7WZyQhdscOJtBzt5n6fkliPUg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=/W4ySu64Zp2iySQZQFxpyrjMq6MDDwL84m2yf2kl9Dc=; b=hR5FLH/AAZUVymdY9DLxbYKjJV8yaBdVg5iXu0Pzn6ZL8jV53M5pX6sA8ck1ZkEsyW cZu2vKvnRl4zDndu8A52p+Ck+j775yt/uQUOQkOFoL3xeoHrmxk6CBvMRdlbi+3oNPVh /8LBieFfDYZzncoqSSzOx6xunzPrSSyxD8/QlrYfM4rwwieMujZNqR6mE7yhZcVbJgzP 97ig7W1h5sfOFT2bBg8VwXFQcUm/3C3ibmnJOoRaTn40mxUzGPM+Uz40UVlXBuMOrF/s Wb4tEi3Q3tZocndgOMmYomFfJOMXtD3MBUjfjVPOCSLfBiXP9PFSZmX8KfBn7PltrltB iZRg== X-Gm-Message-State: AOAM530KPe/rj6AQ/sMxpcScCVSUpjnrcobuay1zgWvkArPuycA4kZTH 8yyKPcqQUtKC3vdA1h3h4YzlMoClZV3hMnrh81uWlg== X-Google-Smtp-Source: ABdhPJx2s6kRt+v/3i1DjPexmJoY+582CJBOnXF//6FwE+jiddCcTHdknjuE1GgKhMnyCz3BstbM0nd4lg6QcCDqR/M= X-Received: by 2002:a17:906:6a84:: with SMTP id p4mr17204886ejr.374.1598457916186; Wed, 26 Aug 2020 09:05:16 -0700 (PDT) From: "Vladimir Olovyannikov" References: <20200825172049.30912-1-vladimir.olovyannikov@broadcom.com> <1e618ae0-230b-effb-f9df-9957fcd0d19f@redhat.com> In-Reply-To: <1e618ae0-230b-effb-f9df-9957fcd0d19f@redhat.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQI5oHfex7oCUXIXH7eSdMX/5I5pUgHGA7//qHYUFIA= Date: Wed, 26 Aug 2020 09:05:13 -0700 Message-ID: Subject: Re: [edk2-devel] [PATCH v7 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Laszlo Ersek , devel@edk2.groups.io Cc: Maciej Rabeda , Zhichao Gao , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd , Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" Hi Laszlo, No worries, please let me know if you have any comments/concerns down the road. Thank you, Vladimir > -----Original Message----- > From: Laszlo Ersek > Sent: Wednesday, August 26, 2020 6:56 AM > To: devel@edk2.groups.io; vladimir.olovyannikov@broadcom.com > Cc: Maciej Rabeda ; Zhichao Gao > ; Jiaxin Wu ; Siyuan Fu > ; Ray Ni ; Liming Gao > ; Nd ; Samer El-Haj-Mahmoud > > Subject: Re: [edk2-devel] [PATCH v7 0/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > Hi Vladimir, > > On 08/25/20 19:20, Vladimir Olovyannikov via groups.io wrote: > > Signed-off-by: Vladimir Olovyannikov > > > > Reviewed-by: Maciej Rabeda > > Cc: Zhichao Gao > > Cc: Maciej Rabeda > > Cc: Jiaxin Wu > > Cc: Siyuan Fu > > Cc: Ray Ni > > Cc: Liming Gao > > Cc: Nd > > Cc: Laszlo Ersek > > Cc: Samer El-Haj-Mahmoud > > > > This patchset introduces an http client utilizing EDK2 HTTP protocol, > > to allow fast image downloading from http/https servers. > > HTTP download speed is usually faster than tftp. > > The client is based on the same approach as tftp dynamic command, and > > uses the same UEFI Shell command line parameters. This makes it easy > > integrating http into existing UEFI Shell scripts. > > Note that to enable HTTP download, feature Pcd > > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to > TRUE. > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > > > > PATCH v7 changes: > > Address Laszlo' and Maciej's comments: > > - Remove openssl submodule change accidentally added to the v6 > patchset; > > - Fix code style issues in the code overlooked in the previous > > patchset. > > I'm currently working on some VCPU hotplug fixes for the upcoming release. > Before I return to your HttpDynamicCommand patch, I'll also have to > re-read > my earlier comments for it. (In fact I can't tell off-hand if I had > remaining > requests for your patch, or not -- hence the need for re-reading my > earlier > comments.) It could take some time -- thanks for your patience. > > Thanks, > Laszlo