From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.11550.1658515598037244054 for ; Fri, 22 Jul 2022 11:46:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=B6rvkRdR; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658515598; x=1690051598; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ai81eh22rQC7jxV3UReOlFhNQMCSygEBr5YWOPMI/LM=; b=B6rvkRdRpqI2Up7bIxYlMPVdRIN0ob8I2dU+0NS02JbEHa2m8D+0NULq do6hvSoXTlWIG+z40VvTBfRls2Q1C+JQ6HbZmHiI1yxpUvI9eS4jAVxtF GDyB3LDcn+MeY4v9PnYlSqPR4bi96m2cTGawY1iGEVgxJ5/uLk6ukqHZw xkt3FdTUi++/pdT29uNXQC6cmNNWN2QgEJfAjFKmrzKeLs7/cvUYNJf36 SsvKK/txx43RYoHdPhf4SwW1EvDwC0/qAA9VffzgVA2w0CVbG/sGhuJ8w PaW0Jzt2Ie/mO1vc1N3W8RMv2Ko1JzZbUkGoxrdMInkCBHYx42nKoFXaq A==; X-IronPort-AV: E=McAfee;i="6400,9594,10416"; a="288138258" X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="288138258" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:37 -0700 X-IronPort-AV: E=Sophos;i="5.93,186,1654585200"; d="scan'208";a="666767956" Received: from iworam-desk.amr.corp.intel.com ([10.24.80.243]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2022 11:46:37 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Isaac Oram , Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel][edk2-platforms][PATCH V1 01/13] MinPlatformPkg/Include: Simplify board creation Date: Fri, 22 Jul 2022 11:46:12 -0700 Message-Id: X-Mailer: git-send-email 2.36.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Reduce the need for boards to initialize common MinPlatformPkg PCD used in build files. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram --- .../Dsc/MinPlatformFeaturesPcd.dsc.inc | 26 +++++++++++++++++++ .../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 +++++----- 2 files changed, 32 insertions(+), 8 deletions(-) create mode 100644 Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc b/Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc new file mode 100644 index 0000000000..842668a081 --- /dev/null +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc @@ -0,0 +1,26 @@ +## @file +# DSC file for defining default PCD for MinPlatform features. +# +# This makes it easy for boards to initially configure their build. +# +# This initializes features to be disable by default. +# A board can enable a feature by configuring the PCD in the board DSC file +# after this file has been included. +# +# Copyright (C) 2022 Intel Corporation +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +## + +[PcdsFeatureFlag] + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable |FALSE + + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable |FALSE + + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable |FALSE diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc index 09aa6fe4d5..90127c16b5 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc @@ -38,14 +38,12 @@ # ################################################################################ -[PcdsFeatureFlag] - # configuration - gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable|FALSE - gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|FALSE +# +# MinPlatform common include for required feature PCD +# These PCD must be set before the core include files, CoreCommonLib, +# CorePeiLib, and CoreDxeLib. +# +!include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc ################################################################################ # -- 2.36.1.windows.1