From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web10.41.1595887698595918762 for ; Mon, 27 Jul 2020 15:08:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ggC95pfE; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595887697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tm/Ks5qKDTL8W72VMQZpqcJb9pu4euZOKylqvsoWeSU=; b=ggC95pfEYYMsdeZjNa7Ig6EbGYq19qMTiMt7mcoWz2vWE8EZT8t/833ID1obRJoFX52wFS aDaIWxUk2xDki9ywQyAk5DW2HbzJ1tWCPiyHO5my6A8vRsB7zzr4zv7B7tm7Qmlvx9lPoN F5iNBJU9PXB/znMG371WU9uOHMCJDDk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-HuDJNKgCOb6rdQ1MOzBuuw-1; Mon, 27 Jul 2020 18:08:11 -0400 X-MC-Unique: HuDJNKgCOb6rdQ1MOzBuuw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D0CA8015CE; Mon, 27 Jul 2020 22:08:09 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-40.ams2.redhat.com [10.36.112.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 694AF6FEC6; Mon, 27 Jul 2020 22:08:07 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: devel@edk2.groups.io, vladimir.olovyannikov@broadcom.com Cc: Samer El-Haj-Mahmoud , Zhichao Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd References: <20200727164830.25829-1-vladimir.olovyannikov@broadcom.com> <20200727164830.25829-2-vladimir.olovyannikov@broadcom.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 28 Jul 2020 00:08:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200727164830.25829-2-vladimir.olovyannikov@broadcom.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Just some quick remarks after a comparison with v3: On 07/27/20 18:48, Vladimir Olovyannikov via groups.io wrote: > Introduce an http client utilizing EDK2 HTTP protocol, to > allow fast image downloading from http/https servers. > HTTP download speed is usually faster than tftp. > The client is based on the same approach as tftp dynamic command, and > uses the same UEFI Shell command line parameters. This makes it easy > integrating http into existing UEFI Shell scripts. > Note that to enable HTTP download, feature Pcd > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must > be set to TRUE. > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > > Signed-off-by: Vladimir Olovyannikov > CC: Samer El-Haj-Mahmoud > CC: Laszlo Ersek (1) These "CC" lines are not formatted correctly -- they might do the job as far as git-send-email is concerned, but they don't satisfy "PatchCheck.py": > ShellPkg/DynamicCommand: add HttpDynamicCommand > The commit message format is not valid: > * 'CC' should be 'Cc' > * 'CC' should be 'Cc' > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format The exit status is 255, so this would break the CI run again. Please run "PatchCheck.py" locally before posting, and/or submit a personal CI build. [...] > + if (UserNicName != NULL) { > + if (StrCmp (NicName, UserNicName) != 0) { > + Status = EFI_NOT_FOUND; Change is new since v4, but not documented in the v5 changelog. (The code may be OK, but please help reviewers with the v(n) -> v(n+1) changelogs.) [...] > + if (ShellCommandLineGetFlag (CheckPackage, L"-m")) { > + Context.Flags |= DL_FLAG_TIME; > + } (2) The "-m" flag has not been removed from here [...] > +// Download Flags > +#define DL_FLAG_TIME BIT0 // Show elapsed time. (3) and here > +".SH SYNOPSIS\r\n" > +" \r\n" > +"HTTP [-i interface] [-l port] [-t timeout] [-s size] [-m] [-k]\r\n" (4) and here [...] > +" -m Measure and report download time (in seconds). \r\n" (5) and here. I suggest waiting for ShellPkg owner feedback before posting v6. Thanks! Laszlo