From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: devel@edk2.groups.io, leif@nuviainc.com
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Subject: Re: [edk2-devel] [PATCH 1/1] ArmPkg: only attempt buildin MmCommunicationDxe for AArch64
Date: Sun, 7 Jun 2020 22:23:20 +0200 [thread overview]
Message-ID: <d4e5a571-65b9-f932-2df9-addc47031b2c@arm.com> (raw)
In-Reply-To: <20200607200920.8204-1-leif@nuviainc.com>
On 6/7/20 10:09 PM, Leif Lindholm via groups.io wrote:
> Commit 045e4b84c18f ("ArmPkg/ArmPkg.dsc: Add missing components")
> adds some components to the ArmPkg.dsc build config, but it adds
> them to Components.common, and MmCommunicationDxe is AArch64 only.
> Move it to Components.AARCH64 to stop the ARM build breaking.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
So how does this break only now?
In any case,
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> ---
> ArmPkg/ArmPkg.dsc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> index bac1306af61f..48059cf38ed3 100644
> --- a/ArmPkg/ArmPkg.dsc
> +++ b/ArmPkg/ArmPkg.dsc
> @@ -145,8 +145,8 @@ [Components.common]
>
> ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
> ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf
> - ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
>
> [Components.AARCH64]
> + ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
> ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf
> ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf
>
next prev parent reply other threads:[~2020-06-07 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 20:09 [PATCH 1/1] ArmPkg: only attempt buildin MmCommunicationDxe for AArch64 Leif Lindholm
2020-06-07 20:23 ` Ard Biesheuvel [this message]
2020-06-07 21:16 ` [edk2-devel] " Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4e5a571-65b9-f932-2df9-addc47031b2c@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox