From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web12.15412.1591561409475219360
 for <devel@edk2.groups.io>;
 Sun, 07 Jun 2020 13:23:29 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3F7311FB;
	Sun,  7 Jun 2020 13:23:28 -0700 (PDT)
Received: from [192.168.1.69] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 718F73F73D;
	Sun,  7 Jun 2020 13:23:27 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH 1/1] ArmPkg: only attempt buildin MmCommunicationDxe for AArch64
To: devel@edk2.groups.io, leif@nuviainc.com
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
References: <20200607200920.8204-1-leif@nuviainc.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <d4e5a571-65b9-f932-2df9-addc47031b2c@arm.com>
Date: Sun, 7 Jun 2020 22:23:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <20200607200920.8204-1-leif@nuviainc.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 6/7/20 10:09 PM, Leif Lindholm via groups.io wrote:
> Commit 045e4b84c18f  ("ArmPkg/ArmPkg.dsc: Add missing components")
> adds some components to the ArmPkg.dsc build config, but it adds
> them to Components.common, and MmCommunicationDxe is AArch64 only.
> Move it to Components.AARCH64 to stop the ARM build breaking.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>

So how does this break only now?

In any case,

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

> ---
>   ArmPkg/ArmPkg.dsc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> index bac1306af61f..48059cf38ed3 100644
> --- a/ArmPkg/ArmPkg.dsc
> +++ b/ArmPkg/ArmPkg.dsc
> @@ -145,8 +145,8 @@ [Components.common]
>   
>     ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
>     ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf
> -  ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
>   
>   [Components.AARCH64]
> +  ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
>     ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf
>     ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf
>