From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by mx.groups.io with SMTP id smtpd.web10.2193.1607317191670252806 for ; Sun, 06 Dec 2020 20:59:51 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=rsU+/aEB; spf=pass (domain: nuviainc.com, ip: 209.85.210.194, mailfrom: rebecca@nuviainc.com) Received: by mail-pf1-f194.google.com with SMTP id q22so8569546pfk.12 for ; Sun, 06 Dec 2020 20:59:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=RMFbCqdGLiQZ5/a9QPYwQfQXOgVcO0B0O9teuYY0oAY=; b=rsU+/aEBxpI2Lw8cNrmHz4PlWvb0mqKCoJ1qvu8+UR3VV0rkUe4JVuIHXWcmUczDlD 1kHOXaKI6qXW8+lcd8DhaSUPyE0TP21KPr+/VpUgyylQC7ij0Zy87wVS8iX/0lIQoHHE al2oX48hTUdYu5xFYu1/E7aG3JbCaDysYSdCkuZqKenIJrZGV3jDwqR+e5huqplze9vc 2FJ0qQ2BpdhAo4hC/m4ECAJsvjh/YxqUXORzTDyqY6214Oh6y4zLi+Uper3smDhi/+QJ lNE/pAxAKloCEpKkNvMl19P0IZZg7zMxWj42T+jMPDHLUNqvN7FNtDML7QRz6nLELhVb ZA+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=RMFbCqdGLiQZ5/a9QPYwQfQXOgVcO0B0O9teuYY0oAY=; b=IBR1F943bhBr52z5aU1e7qh8OMb/72R8IpZEyjB8yOW+WlDkhRiV46+/66zfR/o/5o TRz5+X06JifwclYjhUWMECh1WlV74JFNR/D2p34D5jhE0cl85tkWUvLCzsFklOB+tRjz 2oNv+f8AY50P6HsShHKQgghbJG4A7xow8GOa14JTkt2mB5AtSGFYOQz4iQ7g3/YGG+hf TeXvuOAdPxuMPA383Ip9kLzJHYoPVJY7bX2PH4zCgMmBxLB2tVKlC++GXHP+eb6LlwUC Mq7dfHWGbIaN1XRfP5oqR31oR71HGmgTm8lAlGgXGbF1uphuqaRHqCm4Of93jE+sSsVU JWbw== X-Gm-Message-State: AOAM533WpkNAGHGwXY7PEUkoy+LENPjmTq2b8Irxsk3kZ6+RjmIwGVsb VkZxDuo5Bs/FSHzfTLDurWrLOw== X-Google-Smtp-Source: ABdhPJw8MqbS69S1aFwGQHyzsjAoGKgmt20xRvfg3febOqQ489duMDCTGfEXo5fR/91l1N4p5bfSkQ== X-Received: by 2002:a63:e94f:: with SMTP id q15mr2674405pgj.401.1607317191208; Sun, 06 Dec 2020 20:59:51 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id y19sm12868219pfp.211.2020.12.06.20.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Dec 2020 20:59:50 -0800 (PST) From: "Rebecca Cran" Subject: Re: [PATCH v3 3/3] ArmPkg: add Universal/Smbios as a generic SMBIOS library To: Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel , Michael D Kinney , Liming Gao , Zhiguang Liu References: <20201111001748.20217-1-rebecca@nuviainc.com> <20201111001748.20217-4-rebecca@nuviainc.com> <20201119125827.GL1664@vanye> Message-ID: Date: Sun, 6 Dec 2020 21:59:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201119125827.GL1664@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 11/19/20 5:58 AM, Leif Lindholm wrote: I hope I've addressed these and your other feedback in the new patch series I'll post soon. > Please use --stat=1000 --stat-graph-width=20 when generating > patches, to avoid above ellipses. I'll try and remember in future. > What version? FirmwareVersion? Would make sense to be explicit in the > name. I've removed the driver following Ard's feedback. > Where is this function defined? It's defined in the platform-specific OemMiscLib implementation. > Changes to this file in general seem to be removing unused(?) existing > cache-related macros and adding (architectural) special > purposeregister descriptions as replacements. This feels like two > separate changes (and hence patches). Agreed. I'll split it. > Eew. > This is quite possibly very useful, but that '&' made me swear out > loud. Add a comment describing how this is used further down? I hope I've addressed this sufficiently in my new revision. >> + >> + MISC_SMBIOS_TABLE_EXTERNS (SMBIOS_TABLE_TYPE0, MiscBiosVendor, MiscBiosVendor) > Why the indentation? I have no idea. I've fixed it. >> +#define MAX_HANDLE_COUNT 0x10 > Why? > Does this belong in a generic header? It's an arbitrary value, since the SMBIOS protocol doesn't have a way of letting you know how many records of a certain type are available without iterating through them. It might be better to just iterate twice. -- Rebecca Cran