From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mx.groups.io with SMTP id smtpd.web11.15206.1683722033359088621 for ; Wed, 10 May 2023 05:33:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=Mm1KwNUt; spf=pass (domain: bsdio.com, ip: 64.147.123.19, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 172073200921; Wed, 10 May 2023 08:33:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 10 May 2023 08:33:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683722031; x=1683808431; bh=RoUgLMyX0JWVpQtRJ4drU6/LYviWXDn5Lpd USBuDVrQ=; b=Mm1KwNUtLlL7O/3cTQEVTm7GukvjSbH9MI/YR7lymNCh84GAcjt zaxNVQtxHKLcECfcQtGDAuaXDfSOY7fw1zeWeSrnH8hQWghf1Is4gYQg25iIbLWm 3b5OHb9tDtf5RSCDugLa5FvMjkhEv0sSOLsJa9hpb4knN3cfGTd892lTn2+I/8S6 K8vOS8I+ivI3dh6LXXW3b1YD98fC2vdkXwpdqrz6J02abIAzjQLsWr3x2G/q9xYL Zlws+O3LnhXwIQem4yIBdPuO/TtaS6ViHnsBqT4DP3X6/Z7k/XUp1OhevXJu9hTz sZ3kglL9ckWiQd6aFxMjI7lgEaIjhnhH1pQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683722031; x=1683808431; bh=RoUgLMyX0JWVpQtRJ4drU6/LYviWXDn5Lpd USBuDVrQ=; b=a722wkwlIGHPSBDZ/sUss+/80Vp4WCbFyKNUguLezjFubKd2lXR 1+H6zyaCosHTQMmjje34kl45qmjRHr1QAf5EH5aFxk7OYAjAnujziWY9NhtTtqkK N/F5fRHr2lRomG4Zfz+03PP9AICV/lHKjXR+DEdGxWUtnOH2zfnLUsDLvXbaO1+N 1in0CW7Dp6NVoNFwJZ5rBhT974gP41uCqbqU9ox0neat9RrJyPdyxfsWm9G7OmLb Wn+neygwbMPQ0l+yi/D/VJ0cRPv6JnWcZm7cH3bkpzUXQLv+TMvSHSWroKSARYGg TbQ0GDojQrIeNhTD21FACEDQdmLZ3AcvIzQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeegiedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeevjeeijedtjedttdevgeefhfehueelfedtheeghfduffeljefhfeehhfdt iedthfenucffohhmrghinheplhhinhgrrhhordhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtgho mh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 May 2023 08:33:50 -0400 (EDT) Message-ID: Date: Wed, 10 May 2023 06:33:50 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-devel] [edk2-stable202305 PATCH 2/4] BaseTools: Set the CLANGDWARF OBJCOPY path in tools_def.template To: Ard Biesheuvel Cc: devel@edk2.groups.io, Liming Gao , Bob Feng , Yuwei Chen References: <20230509235337.1815842-1-rebecca@bsdio.com> <20230509235337.1815842-3-rebecca@bsdio.com> <9d398003-436a-0d99-66b5-17a84eb62e34@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/10/23 06:10, Ard Biesheuvel wrote: > On Wed, 10 May 2023 at 14:09, Rebecca Cran wrote: >> On 5/10/23 05:03, Ard Biesheuvel wrote: >>> On Wed, 10 May 2023 at 01:53, Rebecca Cran wrote: >>>> Set the OBJCOPY path for the CLANGDWARF toolchain to 'llvm-objcopy' to >>>> override the default of 'echo'. >>>> >>>> Signed-off-by: Rebecca Cran >>> This appears to break the AArch64 CLANGDWARF build. >>> >>> https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/4880/console >> Ugh, I'm sorry. We're not overriding the OBJCOPY_FLAGS for ARM and >> AARCH64, so it uses the default of "not needed for" which previously got >> echoed. >> >> I'll work on a better local testing process to avoid such an obvious >> breakage in future. >> >> >> Would you like this commit reverted, or should I submit a patch to fix it? >> > No revert necessary - it should be a minimal fix, and we can just > apply it on top. Thanks. I've just sent out a fix: "BaseTools: Revert Set the CLANGDWARF OBJCOPY path in tools_def.template" I was attempting to match what gcc does in terms of objcopy, but we can leave OBJCOPY as echo and just have RC set to llvm-objcopy. -- Rebecca Cran