From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.68, mailfrom: philmd@redhat.com) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Thu, 13 Jun 2019 09:21:35 -0700 Received: by mail-wr1-f68.google.com with SMTP id c2so21444307wrm.8 for ; Thu, 13 Jun 2019 09:21:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LBBe0XiMD1XE67Ht4XlwA5Ffrzi8ag8Syl8Jl1rqUZs=; b=Cq6MEgYvl4Rp442IaI2rQkHxyD4oKTURuysCUtHENqi0nvz+m6jVoaqnxaskP066vf 0F0dJpuvbmTR9qVkm9kVTQWoUl6H5ssvyLz6jlzxWpv0yiSaX+nqb2tZjrrA2Pz76Weq z/aKgCICMRVUs4/3Ixyqw+m2A3PCq8B1Vz1XnYtfWDlNDxgCYky/hjdkfEI/PmdB5IEA nziCfapgI/Lwzn3WA+Zi4AZJUO10l/Wpslryo30UfKxF2a6TE2lhLIKl8A8p2Kx9n4/q j/mZSdvvz8qovqPH6HIwkH0jWyZ3eaRTv6wTBHncl8o2sDSBWKqyAD66N242kf6HDhLy uFsw== X-Gm-Message-State: APjAAAVj6+AKT5Q1vKSoY6KO6COCk/weE0VWXLhLpFshEgneVo2OGO9n 6Z8lylJROKapqeMwaaDrNYOoqA== X-Google-Smtp-Source: APXvYqzx4f/RpK1zjWqrE8tMoRHbDxU7mhmNkUfxIxW5C4dEGqK0m/ZqoVj/FOv4OupA0GotNsq72g== X-Received: by 2002:a5d:5452:: with SMTP id w18mr24711228wrv.327.1560442893288; Thu, 13 Jun 2019 09:21:33 -0700 (PDT) Return-Path: Received: from [192.168.1.38] (183.red-88-21-202.staticip.rima-tde.net. [88.21.202.183]) by smtp.gmail.com with ESMTPSA id j17sm207113wrw.6.2019.06.13.09.21.32 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 09:21:32 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 0/2] EmbeddedPkg,ArmPlatformPkg: fix VS2017 TimeBaseLib build errors To: devel@edk2.groups.io, leif.lindholm@linaro.org Cc: ard.biesheuvel@linaro.org, Alexei Fedorov References: <20190613161833.30102-1-leif.lindholm@linaro.org> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Thu, 13 Jun 2019 18:21:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190613161833.30102-1-leif.lindholm@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 6/13/19 6:18 PM, Leif Lindholm wrote: > TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs > between architectures. This upsets VS2017 when building for 32-bit ARM > (and likely would if building for IA32 too). Similarly, some internal > calculations used UINTN for operating on fixed-size fields, giving > further issues. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=997 > > PL031RealTimeClockLib needed an adjustment to support the resulting API > change, but frankly that change just makes the code agree with the > comments surrounding it. > > This series cleans up the type handling Visual Studio complains about. > This is not a proper overhaul of the library, just a fix of encountered > build errors. > > Leif Lindholm (2): > ArmPlatformPkg: use UINT32 epoch second counter > EmbeddedPkg: improve TimeBaseLib type safety > > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 3 ++- > EmbeddedPkg/Include/Library/TimeBaseLib.h | 4 ++-- > EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c | 18 +++++++++--------- > 3 files changed, 13 insertions(+), 12 deletions(-) > > Cc: Alexei Fedorov > Series: Reviewed-by: Philippe Mathieu-Daude