From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, rebecca@bsdio.com
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>,
Andrew Fish <afish@apple.com>, Leif Lindholm <leif@nuviainc.com>,
Jordan L Justen <jordan.l.justen@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor
Date: Mon, 13 Jul 2020 20:09:57 +0200 [thread overview]
Message-ID: <d5725237-c79e-26e2-e776-8c87a38efba4@redhat.com> (raw)
In-Reply-To: <88d22f36-c210-f626-fe70-b2eb3c5fcd3c@redhat.com>
Hi Rebecca,
On 07/13/20 18:55, Laszlo Ersek wrote:
> On 07/13/20 07:41, Rebecca Cran wrote:
>> BhyvePkg supports the bhyve hypervisor, which is a hypervisor/virtual
>> machine manager available on FreeBSD, macOS and Illumos.
>>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> ---
>> OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 251 +++
>> OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 77 +
>> .../Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 65 +
>> OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c | 132 ++
>> OvmfPkg/Bhyve/AcpiPlatformDxe/EntryPoint.c | 90 +
>> OvmfPkg/Bhyve/AcpiPlatformDxe/PciDecoding.c | 192 ++
>> OvmfPkg/Bhyve/AcpiTables/AcpiTables.inf | 39 +
>> OvmfPkg/Bhyve/AcpiTables/Dsdt.asl | 1140 +++++++++++
>> OvmfPkg/Bhyve/AcpiTables/Facp.aslc | 76 +
>> OvmfPkg/Bhyve/AcpiTables/Facs.aslc | 80 +
>> OvmfPkg/Bhyve/AcpiTables/Hpet.aslc | 72 +
>> OvmfPkg/Bhyve/AcpiTables/Madt.aslc | 145 ++
>> OvmfPkg/Bhyve/AcpiTables/Mcfg.aslc | 57 +
>> OvmfPkg/Bhyve/AcpiTables/Platform.h | 72 +
>> OvmfPkg/Bhyve/AcpiTables/Spcr.aslc | 63 +
>> OvmfPkg/Bhyve/AcpiTables/Ssdt.asl | 15 +
>> OvmfPkg/Bhyve/BhyvePkg.dec | 171 ++
>> OvmfPkg/Bhyve/BhyvePkgDefines.fdf.inc | 85 +
>> OvmfPkg/Bhyve/BhyvePkgX64.dsc | 847 +++++++++
>> OvmfPkg/Bhyve/BhyvePkgX64.fdf | 490 +++++
>> OvmfPkg/Bhyve/BhyveRfbDxe/BhyveRfbDxe.inf | 68 +
>> OvmfPkg/Bhyve/BhyveRfbDxe/ComponentName.c | 201 ++
>> OvmfPkg/Bhyve/BhyveRfbDxe/Gop.h | 149 ++
>> OvmfPkg/Bhyve/BhyveRfbDxe/GopDriver.c | 543 ++++++
>> OvmfPkg/Bhyve/BhyveRfbDxe/GopScreen.c | 393 ++++
>> OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.asm | 342 ++++
>> OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.c | 259 +++
>> OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h | 912 +++++++++
>> OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.sh | 80 +
>> OvmfPkg/Bhyve/FvmainCompactScratchEnd.fdf.inc | 65 +
>> OvmfPkg/Bhyve/Include/Library/BhyveFwCtlLib.h | 47 +
>> .../Library/BhyveFwCtlLib/BhyveFwCtlLib.c | 426 +++++
>> .../Library/BhyveFwCtlLib/BhyveFwCtlLib.inf | 41 +
>> .../PlatformBootManagerLib/BdsPlatform.c | 1660 +++++++++++++++++
>> .../PlatformBootManagerLib/BdsPlatform.h | 190 ++
>> .../PlatformBootManagerLib.inf | 75 +
>> .../PlatformBootManagerLib/PlatformData.c | 171 ++
>> OvmfPkg/Bhyve/License.txt | 68 +
>> OvmfPkg/Bhyve/PlatformPei/AmdSev.c | 106 ++
>> OvmfPkg/Bhyve/PlatformPei/ClearCache.c | 111 ++
>> OvmfPkg/Bhyve/PlatformPei/Cmos.c | 58 +
>> OvmfPkg/Bhyve/PlatformPei/Cmos.h | 50 +
>> OvmfPkg/Bhyve/PlatformPei/FeatureControl.c | 21 +
>> OvmfPkg/Bhyve/PlatformPei/Fv.c | 94 +
>> OvmfPkg/Bhyve/PlatformPei/MemDetect.c | 627 +++++++
>> OvmfPkg/Bhyve/PlatformPei/Platform.c | 607 ++++++
>> OvmfPkg/Bhyve/PlatformPei/Platform.h | 137 ++
>> OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf | 113 ++
>> OvmfPkg/Bhyve/SmbiosPlatformDxe/Bhyve.c | 43 +
>> .../SmbiosPlatformDxe/SmbiosPlatformDxe.c | 245 +++
>> .../SmbiosPlatformDxe/SmbiosPlatformDxe.h | 52 +
>> .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 55 +
>> OvmfPkg/Bhyve/VarStore.fdf.inc | 115 ++
>> 53 files changed, 12283 insertions(+)
>> create mode 100644 OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c
>> create mode 100644 OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h
>> create mode 100644 OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf
>> create mode 100644 OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c
>> create mode 100644 OvmfPkg/Bhyve/AcpiPlatformDxe/EntryPoint.c
>> create mode 100644 OvmfPkg/Bhyve/AcpiPlatformDxe/PciDecoding.c
>> create mode 100644 OvmfPkg/Bhyve/AcpiTables/AcpiTables.inf
>> create mode 100644 OvmfPkg/Bhyve/AcpiTables/Dsdt.asl
>> create mode 100644 OvmfPkg/Bhyve/AcpiTables/Facp.aslc
>> create mode 100644 OvmfPkg/Bhyve/AcpiTables/Facs.aslc
>> create mode 100644 OvmfPkg/Bhyve/AcpiTables/Hpet.aslc
>> create mode 100644 OvmfPkg/Bhyve/AcpiTables/Madt.aslc
>> create mode 100644 OvmfPkg/Bhyve/AcpiTables/Mcfg.aslc
>> create mode 100644 OvmfPkg/Bhyve/AcpiTables/Platform.h
>> create mode 100644 OvmfPkg/Bhyve/AcpiTables/Spcr.aslc
>> create mode 100644 OvmfPkg/Bhyve/AcpiTables/Ssdt.asl
>> create mode 100644 OvmfPkg/Bhyve/BhyvePkg.dec
>> create mode 100644 OvmfPkg/Bhyve/BhyvePkgDefines.fdf.inc
>> create mode 100644 OvmfPkg/Bhyve/BhyvePkgX64.dsc
>> create mode 100644 OvmfPkg/Bhyve/BhyvePkgX64.fdf
>> create mode 100644 OvmfPkg/Bhyve/BhyveRfbDxe/BhyveRfbDxe.inf
>> create mode 100644 OvmfPkg/Bhyve/BhyveRfbDxe/ComponentName.c
>> create mode 100644 OvmfPkg/Bhyve/BhyveRfbDxe/Gop.h
>> create mode 100644 OvmfPkg/Bhyve/BhyveRfbDxe/GopDriver.c
>> create mode 100644 OvmfPkg/Bhyve/BhyveRfbDxe/GopScreen.c
>> create mode 100644 OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.asm
>> create mode 100644 OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.c
>> create mode 100644 OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h
>> create mode 100644 OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.sh
>> create mode 100644 OvmfPkg/Bhyve/FvmainCompactScratchEnd.fdf.inc
>> create mode 100644 OvmfPkg/Bhyve/Include/Library/BhyveFwCtlLib.h
>> create mode 100644 OvmfPkg/Bhyve/Library/BhyveFwCtlLib/BhyveFwCtlLib.c
>> create mode 100644 OvmfPkg/Bhyve/Library/BhyveFwCtlLib/BhyveFwCtlLib.inf
>> create mode 100644 OvmfPkg/Bhyve/Library/PlatformBootManagerLib/BdsPlatform.c
>> create mode 100644 OvmfPkg/Bhyve/Library/PlatformBootManagerLib/BdsPlatform.h
>> create mode 100644 OvmfPkg/Bhyve/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>> create mode 100644 OvmfPkg/Bhyve/Library/PlatformBootManagerLib/PlatformData.c
>> create mode 100644 OvmfPkg/Bhyve/License.txt
>> create mode 100644 OvmfPkg/Bhyve/PlatformPei/AmdSev.c
>> create mode 100644 OvmfPkg/Bhyve/PlatformPei/ClearCache.c
>> create mode 100644 OvmfPkg/Bhyve/PlatformPei/Cmos.c
>> create mode 100644 OvmfPkg/Bhyve/PlatformPei/Cmos.h
>> create mode 100644 OvmfPkg/Bhyve/PlatformPei/FeatureControl.c
>> create mode 100644 OvmfPkg/Bhyve/PlatformPei/Fv.c
>> create mode 100644 OvmfPkg/Bhyve/PlatformPei/MemDetect.c
>> create mode 100644 OvmfPkg/Bhyve/PlatformPei/Platform.c
>> create mode 100644 OvmfPkg/Bhyve/PlatformPei/Platform.h
>> create mode 100644 OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf
>> create mode 100644 OvmfPkg/Bhyve/SmbiosPlatformDxe/Bhyve.c
>> create mode 100644 OvmfPkg/Bhyve/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>> create mode 100644 OvmfPkg/Bhyve/SmbiosPlatformDxe/SmbiosPlatformDxe.h
>> create mode 100644 OvmfPkg/Bhyve/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
>> create mode 100644 OvmfPkg/Bhyve/VarStore.fdf.inc
>
> I've checked that the PACKAGE_GUID, PLATFORM_GUID, and FILE_GUID values
> are unique.
>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
>
> I'll merge this once the PatchCheck hurdle is solved.
>
> After I merge this, please follow up with a small patch for
> "Maintainers.txt".
Also checked "OvmfPkg/Bhyve/License.txt"; looks OK to me.
I've got quite a bit on my plate now; I wouldn't like to track the
solution to the PatchCheck.py issue. (There are two alternative
solutions; one is the BZ mentioned by Liming, which needs more work, and
the other is Leif's patch series, which also needs more work.)
Can you please ping me when the PatchCheck.py problem has been solved,
so I can go ahead with the merge?
Thanks,
Laszlo
next prev parent reply other threads:[~2020-07-13 18:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 5:41 [PATCH 0/1] Add BhyvePkg, to support the bhyve hypervisor Rebecca Cran
2020-07-13 5:41 ` [PATCH 1/1] " Rebecca Cran
2020-07-13 16:16 ` [edk2-devel] " Laszlo Ersek
2020-07-13 20:24 ` Rebecca Cran
2020-07-13 16:55 ` Laszlo Ersek
2020-07-13 18:09 ` Laszlo Ersek [this message]
2020-07-13 20:25 ` Rebecca Cran
[not found] ` <162169B0F92549B8.20689@groups.io>
2020-07-31 5:17 ` Rebecca Cran
2020-07-31 13:07 ` Laszlo Ersek
2020-07-31 13:10 ` Laszlo Ersek
2020-07-31 17:32 ` Sean
2020-07-31 20:28 ` Rebecca Cran
2020-07-31 21:14 ` Laszlo Ersek
2020-08-01 15:54 ` Laszlo Ersek
2020-08-01 21:10 ` Laszlo Ersek
2020-07-13 5:43 ` [PATCH 0/1] " Liming Gao
2020-07-13 5:48 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5725237-c79e-26e2-e776-8c87a38efba4@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox