From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 736F2211158DA for ; Mon, 8 Oct 2018 21:32:31 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2018 21:32:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,359,1534834800"; d="scan'208";a="79870501" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by orsmga008.jf.intel.com with ESMTP; 08 Oct 2018 21:32:29 -0700 To: Tim Lewis , 'Laszlo Ersek' , "'Carsey, Jaben'" , 'Andrew Fish' Cc: edk2-devel@lists.01.org References: <07e201d45ca5$bb0456d0$310d0470$@insyde.com> From: "Ni, Ruiyu" Message-ID: Date: Tue, 9 Oct 2018 12:33:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <07e201d45ca5$bb0456d0$310d0470$@insyde.com> Subject: Re: [PATCH] ShellPkg: Create a homefilesystem environment variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 04:32:32 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/5/2018 8:19 PM, Tim Lewis wrote: > Jaben -- > > Following on this: shouldn't this be a spec issue? If you are asking people > to depend on the behavior. I agree. So I suggest submit a Spec ECR for this change. Since it was checked in, we can revert it if the ECR is rejected. > > Thanks, > Tim > > -----Original Message----- > From: edk2-devel On Behalf Of Laszlo Ersek > Sent: Friday, October 5, 2018 4:33 AM > To: Carsey, Jaben ; Andrew Fish > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg: Create a homefilesystem environment > variable > > On 10/04/18 22:54, Carsey, Jaben wrote: >> Laszlo, >> >> The leading "_" was required for out of spec, but built in, commands. The > spec has no restrictions on environment variables except some have special > meaning and may be read only. >> >> I can certainly work on slowing down the process. I have been complaining > about that same thing and should have been more aware. I would like to have > a community minimum amount of time before commits are done that we all agree > to. Something like 1 full day would be nice I think. > > Good idea! I believe 24 hours should be tolerable on all ends. It also gives > a chance to people in other time zones to comment. > > I think there should be one exception: grave regressions -- build failures, > or total boot failures -- should be possible to revert (or > fix) as soon as there's one review. > > Thanks! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > -- Thanks, Ray