From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.groups.io with SMTP id smtpd.web11.5357.1571235133094665138 for ; Wed, 16 Oct 2019 07:12:13 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AB8337FDC9 for ; Wed, 16 Oct 2019 14:12:12 +0000 (UTC) Received: by mail-wm1-f72.google.com with SMTP id o188so1267228wmo.5 for ; Wed, 16 Oct 2019 07:12:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=34Nbv4qFl/afZCeTH3Bx8m2L00WN6k19hwgo3aLazeY=; b=j367THNWqrN3I03OEA4iT4R07zSL78CD8DlEFXsqgloDq7LU4mbGZIXjyRpIqxFqCt nc+MyLsNWRh/0vtxYWEqFHNFAm4ODCwtj3x0/ONvbkgrGOHepUNOHcC96ceTqc9tPk3F c4EVlNVImSDkB1BO2i04I0GA4RQgfGy5+e4GrlaXisNsu1ZRltLev+A0oXMgpVO/REyp LoEyVBl/ufV2TYUFW1k9H1RWi2bRVSy17o6nPjdc3Dc6qZm+0ZdtOBP+Pz+9E0E/XqAR CMW0caLMw1I90JIx01JoVB4aK/Xtrz3bhGPSsF5KOHd0d2/0jqW11YWhjx+aE7hR17f6 0XYQ== X-Gm-Message-State: APjAAAWga9OLMp82cjXjsNlBlSj4HjOUZ9VTU7dacRsRQvPKpy+EKK78 FBCtOVeqRCFozPEMTjbRbljkOw1ZiOJfaVDKep8IeLa9TRSv/ayX3KypcFEDoCnimhQsXYeqkn9 fRUhsjQtr9VTYfg== X-Received: by 2002:a5d:50c9:: with SMTP id f9mr2816214wrt.36.1571235131475; Wed, 16 Oct 2019 07:12:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzOJKuCnM9UIougpG2brPU1qBn6T0MsAgewNBWXYziGsSINH2BeZSi6+qbFikRtuTUj9omKnQ== X-Received: by 2002:a5d:50c9:: with SMTP id f9mr2816195wrt.36.1571235131268; Wed, 16 Oct 2019 07:12:11 -0700 (PDT) Received: from [192.168.1.36] (14.red-88-21-201.staticip.rima-tde.net. [88.21.201.14]) by smtp.gmail.com with ESMTPSA id 143sm3672458wmb.33.2019.10.16.07.12.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 07:12:10 -0700 (PDT) Subject: Re: [PATCH 3/3] BaseTools: Add script to help git-send-email pick addresses to cc To: Leif Lindholm , devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Laszlo Ersek References: <20191016140940.18844-1-philmd@redhat.com> <20191016140940.18844-4-philmd@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Wed, 16 Oct 2019 16:12:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191016140940.18844-4-philmd@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/16/19 4:09 PM, Philippe Mathieu-Daude wrote: > Add a new script GitCcCmd.sh that git-send-email can use to > automatically determine which addresses to cc on patch submission. > > Signed-off-by: Philippe Mathieu-Daude > --- > BaseTools/Scripts/GitCcCmd.sh | 38 +++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100755 BaseTools/Scripts/GitCcCmd.sh > > diff --git a/BaseTools/Scripts/GitCcCmd.sh b/BaseTools/Scripts/GitCcCmd.sh > new file mode 100755 > index 000000000000..3afdf3f1e40b > --- /dev/null > +++ b/BaseTools/Scripts/GitCcCmd.sh > @@ -0,0 +1,38 @@ > +#!/bin/sh > +### > +# @file > +# Shell script to be called by 'git-send-email --cc-cmd' to pick the correct > +# maintainer emails for each patch when sending a series. > +# > +# Copyright (C) 2019, Red Hat, Inc. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +# This script expects the following EDK2 environment variables defined: > +# - WORKSPACE > +# - EDK_TOOLS_PATH > +# > +### > + > +set -e > + > +# > +# git-send-email calls this script with a list of patches generated by > +# git-format-patch. > +# > +for arg in $@; do > + case ${arg} in > + *0000-cover-letter.patch) > + break > + ;; > + *.patch) > + test -e ${arg} && ( > + cd ${WORKSPACE} && \ > + head -1 < ${arg} \ > + | cut -d' ' -f2 \ > + | xargs python ${EDK_TOOLS_PATH}/Scripts/GetMaintainer.py --quiet > + ) > + break > + ;; > + esac > +done I meant to tag this patch RFC but forgot about it before sending, so please consider it as RFC :)