public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Corvin Köhne" <corvink@FreeBSD.org>
To: Rebecca Cran <rebecca@bsdio.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Peter Grehan <grehan@freebsd.org>
Subject: Re: [PATCH v3 3/3] OvmfPkg/Bhyve: install ACPI tables from memory
Date: Mon, 08 May 2023 08:04:26 +0200	[thread overview]
Message-ID: <d579a476b31edb0290b2fef72c1bd27e743febe1.camel@FreeBSD.org> (raw)
In-Reply-To: <961e80a5-f88d-3076-47fa-e8f40963c2a6@bsdio.com>

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

On Fri, 2023-05-05 at 08:43 -0600, Rebecca Cran wrote:
> On 5/3/23 01:32, Corvin Köhne wrote:
> 
> > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc
> > b/OvmfPkg/Bhyve/BhyveX64.dsc
> > index d0d2712c5662..465b81ffcd51 100644
> > --- a/OvmfPkg/Bhyve/BhyveX64.dsc
> > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
> > @@ -341,6 +341,7 @@ [LibraryClasses.common.UEFI_DRIVER]
> >    
> > PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf
> >   
> >   [LibraryClasses.common.DXE_DRIVER]
> > + 
> > AcpiPlatformLib|OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.
> > inf
> 
> That file doesn't exist. There's 
> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf and 
> OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf .
> 
> 

It's added by the first commit of this series.

---
 OvmfPkg/OvmfPkg.dec                           |  4 +
 OvmfPkg/OvmfXen.dsc                           |  1 +
 .../AcpiPlatformLib/DxeAcpiPlatformLib.inf    | 26 ++++++
 .../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf |  1 +
 OvmfPkg/Include/Library/AcpiPlatformLib.h     | 25 +++++
 .../AcpiPlatformLib/DxeAcpiPlatformLib.c      | 90 ++++++++++++++++++
 OvmfPkg/XenAcpiPlatformDxe/Xen.c              | 93 ++-----------------
 7 files changed, 153 insertions(+), 87 deletions(-)
 create mode 100644
OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.inf
 create mode 100644 OvmfPkg/Include/Library/AcpiPlatformLib.h
 create mode 100644
OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c


-- 
Kind regards,
Corvin

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-05-08  6:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03  7:32 [PATCH v3 1/3] OvmfPkg/Xen: export search of RSDP into a library function Corvin Köhne
2023-05-03  7:32 ` [PATCH v3 2/3] OvmfPkg/Xen: export AcpiTable installation into AcpiPlatformLib Corvin Köhne
2023-05-03  7:32 ` [PATCH v3 3/3] OvmfPkg/Bhyve: install ACPI tables from memory Corvin Köhne
2023-05-05 14:43   ` Rebecca Cran
2023-05-08  6:04     ` Corvin Köhne [this message]
2023-05-04 10:05 ` [PATCH v3 1/3] OvmfPkg/Xen: export search of RSDP into a library function Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d579a476b31edb0290b2fef72c1bd27e743febe1.camel@FreeBSD.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox