From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.110]) by mx.groups.io with SMTP id smtpd.web11.20519.1680166393893789206 for ; Thu, 30 Mar 2023 01:53:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=ktJro7Cr; spf=pass (domain: os.amperecomputing.com, ip: 40.107.237.110, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGC2Epwo2QlXUFeqmvY0RTFgv4nGFud9SzA+24/hdPmYHjuUNIoD35YGHVpjrkgBP45aByvXX1R8WzejRFw4GIs1RjrILgcTdm3oP/xqpXhqS9q3+L7dIwwck1wbLoOfIy7yDRhEEviEC0g/SJ57mxvQQvcLWr+wJGT6faXCRJnibqONJoAXdIfN4NJl4BzAjiAwlLgR3uD+ADheVu+MQVoLJlExz9MojPYhlvgcZLIJFudsG1vhE1H8ivDzuAWPI8BC0Q8okU+uZqNTXPDSTIJU277UgNBlL1vyn21uBpN7+deg0etMWhy12KkhpZVs79l9wZOwFi0jRz7DMM64UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1rNTxBE20HN/sOAZjjdVs5MNNk+g3PMZVxlSPeX2oM4=; b=C5IMkA58CCO1S+2OZOe2G8vVBE77oWwRayPlgRTSdjw6/B3eGHJeQS/mMth/CPexJ1X+i77joE6l75xHzZmT206+Gw102Jr+olbRcdhcJh693489Ceh32vlo1xeOae8cB9T1bnFtkTEiGsnBqsgue3x/14zwVA9e4+78MbdMCP+kasj+gfLkaxoglhgXAURkIg3wurvGeSVeuXViFlCGtQ7rrDQ9m8oK9J/CbSCP/Bhxi5dSZx4+EiHyVkpJIYKlraID9p+hNxgN8epZdlRM1zmO8GrijhngNjBeW6P85hKdQTH7Mcd1tvt/Pxf3fi4KRBleDQrH75sfL4/0Pdd/pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1rNTxBE20HN/sOAZjjdVs5MNNk+g3PMZVxlSPeX2oM4=; b=ktJro7CrOt1oGKgU2cIEnSboAydp51oF+CCPeEmBGtkHzm10n+zg08Ub0hNi5yMtucdeVxfEoRSHzw4Qn/V8MhnB2V/JHEtePxgQMsObzm4UZ3/zbuMt6R+ZHoW1EmDQgp5olDdHiB+6dPWiQILj9MU9NpELJ5otwsfa4MDr+wA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from MWHPR0101MB2942.prod.exchangelabs.com (2603:10b6:301:2e::14) by PH7PR01MB7704.prod.exchangelabs.com (2603:10b6:510:1d7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.13; Thu, 30 Mar 2023 08:53:08 +0000 Received: from MWHPR0101MB2942.prod.exchangelabs.com ([fe80::1d06:a51a:ca3d:c2f6]) by MWHPR0101MB2942.prod.exchangelabs.com ([fe80::1d06:a51a:ca3d:c2f6%4]) with mapi id 15.20.6178.041; Thu, 30 Mar 2023 08:53:07 +0000 Message-ID: Date: Thu, 30 Mar 2023 15:52:57 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package To: "Chang, Abner" , "devel@edk2.groups.io" , "tinhnguyen@os.amperecomputing.com" CC: Liming Gao , Isaac Oram , Nate DeSimone , "Attar, AbdulLateef (Abdul Lateef)" , Nickle Wang , Igor Kulchytskyy References: <20230322024840.1629-1-abner.chang@amd.com> <20230322024840.1629-2-abner.chang@amd.com> From: "Tinh Nguyen" In-Reply-To: X-ClientProxiedBy: SI1PR02CA0057.apcprd02.prod.outlook.com (2603:1096:4:1f5::10) To MWHPR0101MB2942.prod.exchangelabs.com (2603:10b6:301:2e::14) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR0101MB2942:EE_|PH7PR01MB7704:EE_ X-MS-Office365-Filtering-Correlation-Id: 845ac1b4-ee8d-422d-b1db-08db30fc2e4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yXyWrykiRbaqUN+HImNsBQnz05UoKv/JH1FlS89lpWvL+FNH2Q656nwYiXANppWfgDX4vU44SaLw5XYf3xhcyr43U7JA2XWjPIeAQP0zepodt3Wnq/WR4xWc7RhVxrmsqWazoFF0AYZV1Gn2/U3LoFVHMefF91ynm9epwbSgRCsOegOP86YKTpVd7Kp34KQdYJ9XjBqwzui/9yr9b010nF7ckggCinVPGiPOsqUUbxqVWEObkKBKjxPSUZUM7W4T3kPtU+rpcak/oo6rZzJBIgzeljw0Uy87uBF25GfHOBcbdTuqyqyIQ3e/njA3sZwfbjKxz+S+9d0RE/I4DNT+kG+m5dXLrIv6yEHIi/mOth+JQjmH16atOpyvPcp0qEKoE7nwU9bEiB3EaILppomNjj4DOP0dmBhRY3KeuuerBlCZdmh3Ss4gi0b0XmoIBsGUbiksE0QD4E9u0tnftdobsUqNaxPPyvSVB+76JIFOm6Wlfl8haHseMKQFbnwx+3HQFuoomB/RZE9Nh2moNAgJWIMBU0Q+G27XSFLkpzv1HFdqv3I2A/gA0U6rZmTNuZQjkVvv9DldsAAJ0WzQe8DgXEcKj6Vl7TIXwnqpr5eiQCo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR0101MB2942.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(136003)(376002)(346002)(39850400004)(451199021)(31696002)(2906002)(66899021)(31686004)(6666004)(2616005)(478600001)(53546011)(6506007)(6512007)(83380400001)(6486002)(42882007)(26005)(966005)(66946007)(66476007)(83170400001)(66556008)(54906003)(4326008)(8936002)(8676002)(41300700001)(186003)(110136005)(5660300002)(316002)(38100700002)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nfkI0kVJFfixNvRhYjRTepXdM8mjmLhOhXS4ehu5TEeMQvXOeD1cadcvtesW?= =?us-ascii?Q?YTLwJczcIRvTrJJoqc5/216Ikz8dcIhlBxnILapCahuIPzJN3uxvNdRe2jyD?= =?us-ascii?Q?XA4OkBxeeps1kLZEeBWvkbClPEtUS5y8MX3XQHhluRDcQh4FVdrcQzl5XaLx?= =?us-ascii?Q?PwzME/J2XjM7kJa2iqQhj6mM9CuIv8SutBL25XjMcLixd7HAVPdJuGf00079?= =?us-ascii?Q?bzKI4mJXFnDfliycUMRTKahBOtDHjXRTy0Pp2D82EDu5xRlg6Zmfs85JuVNO?= =?us-ascii?Q?OvwqRCAjygi1E/37vm5rNsUsrHrwed7/590kMYoedEDsdCOCstbz/QtOOq/1?= =?us-ascii?Q?UUwOf1xeus+GbBOiohgL2Muti0w1yP0Dqi+xKSU7RTZxzcWIHORgiw5ai/qh?= =?us-ascii?Q?Fpoj3fn5c53agBAPcFTCODD22wK7KW/gcneClZt1v/ciP9ZtKsGryPy3pflJ?= =?us-ascii?Q?35PvEOExqdImgLwyEGN+2mBuYhXBFkzvaTJHOx0G3nRdQNPBAAM+lqBbPSq+?= =?us-ascii?Q?7uxeOrxaEIa61uBQa27zhxHXd+k05kC+hS+i6CRY4BlYHzKPozu77WXSl8wL?= =?us-ascii?Q?CbZepizfNZONpbxvxZLFocYUD3VH4Ihuvm/+t1QBezluf8h4ApoXjY5YBNLv?= =?us-ascii?Q?y0Ch7Tldho9ye6VCcuC57nHu3lWW+s5QgqKnJfO3GVbXgJHGoaRqW/3ZfAxs?= =?us-ascii?Q?6abEst3+EWhBSFZf1qK3I1leWDdkyaqPbC/j0k9d2O0ANt3N9NRwkdOGx6mz?= =?us-ascii?Q?jzAdDg8DahTiMqVW/uxqCqocYwvD89QsdRIeOGX2rOGF+JfxMl9y4M4xD8AY?= =?us-ascii?Q?lri2mNgrFdBTvv/bNWgaKcH45GVMthP+IQaPTOs4riIMxlxKgUHkhzjBF2/B?= =?us-ascii?Q?xgIAkSdrQpqazgBY/wv9TAa6h+qXQMQmotDVySz/Mj2If1jEm/x9aRELiaVG?= =?us-ascii?Q?a5R82/vL8xPnLWh2WXjY2+bX+wjJrN6EocqKrlWKyEppWj8JLRV7aOa/9+He?= =?us-ascii?Q?82TFfCscs5auxtXkQ3cFaBbPnqo74KUpkIWlGAUJWydrUgb1atb1uJyWt5zf?= =?us-ascii?Q?mbUbJbWqs8GduzwYQwS3e6g5BXbbqU0QB5GT8BOiOHAIJmutVibNLRpB3zWL?= =?us-ascii?Q?D1whODAweNfpnn/sjw31jEHgS5ztpNVfQqaBHi4HU32+DC2s84yHn+2evDhe?= =?us-ascii?Q?SPA22C2S7Z5Tpjw9vxYzrKBPvGJWwUKKezOpuoezjdgbb15dj14cuh2eYvIs?= =?us-ascii?Q?RFoqYLWMeT3Wo9pqcDzHf4rt30gQhYpdzFlsgsL8jJGRJV9n5t0WpvbmIy/y?= =?us-ascii?Q?M7uA6uAuyoxFfJQcyVR+Vhj5wSU0wZHqeKX3DbJ5ZWc1+GuEz/AFTdP9+OjJ?= =?us-ascii?Q?bUmWmmPs9ahwyVg+Kl/BJE6VeYNcBf4DIwkzUyRm5M2Mli+t9CDLBd+QwPge?= =?us-ascii?Q?CRrYNp+fu0uDmW1ObdrhQxaZPUGhQ6Tcu/q8PKBUj8DQ3bx2NZajbF26sXCx?= =?us-ascii?Q?ly49cmrmPPh6FB7TQIVMEDeDQKCSKbdP+DA+RI0rCkp+eSycDyxj2sTrvgK8?= =?us-ascii?Q?EX6T9Ag3VV8ggu7TAwN0b7fx3cWSy3Eoqo8EUxvHMMLlIK7QIG9dFZyD/E8v?= =?us-ascii?Q?fM7GtoDlSCkSEioIlhamJRg=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 845ac1b4-ee8d-422d-b1db-08db30fc2e4b X-MS-Exchange-CrossTenant-AuthSource: MWHPR0101MB2942.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2023 08:53:07.2473 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tc+/svYtr8+1iEW79Ybh6bnKvS54r8+RDvQP5KoWGdYVbVM9tWrtbaU98TqN+13u7dcX1STIZt5o2sw5ZyxNlfaD6X5vPaeQtsjsUMkvujU9fjl4RwFzliHN3QIjjaT6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7704 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Thank you Abner, Let's go on Regards, - Tinh On 3/29/2023 8:32 AM, Chang, Abner wrote: > [AMD Official Use Only - General] > > Hi Tinh, > See my response below, > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Tinh >> Nguyen via groups.io >> Sent: Tuesday, March 28, 2023 8:37 PM >> To: devel@edk2.groups.io; Chang, Abner >> Cc: Liming Gao ; Isaac Oram >> ; Nate DeSimone >> ; Attar, AbdulLateef (Abdul Lateef) >> ; Nickle Wang ; Igor >> Kulchytskyy ; Attar, AbdulLateef (Abdul Lateef) >> >> Subject: Re: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial packa= ge >> >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> Hi Abner, >> >> How can I include this package into flash description? May we lack th= e FDF >> file? >> >> We can refer to AdvanceFeaturePkg, could have PreMemory.fdf and >> PostMemory.fdf > Yes, this is the plan to leverage AdvanceFeaturePkg. > >> BTW, Please add PCDs to the feature configuration; this will be very use= ful >> when other transport drivers are supported. > Sure, I didn=E2=80=99t do this yet because there are not many drivers so = far. I will add PCD in next patch set. The first patch is already got revie= wed and I am thinking to merge it now or adding more patches on top of it a= s a new patch version for community review. > Thanks > Abner > > >> Regards, >> >> Tinh >> >> >> On 3/22/2023 9:48 AM, Chang, Abner via groups.io wrote: >>> From: Abner Chang >>> >>> Initial commit of ManageabilityPkg >>> >>> Signed-off-by: Abner Chang >>> Cc: Liming Gao >>> Cc: Isaac Oram >>> Cc: Nate DeSimone >>> Cc: Abdul Lateef Attar >>> Cc: Nickle Wang >>> Cc: Igor Kulchytskyy >>> Reviewed-by: Abdul Lateef Attar >>> Reviewed-by: Nickle Wang >>> --- >>> .../ManageabilityPkg/ManageabilityPkg.dec | 21 ++++++++++ >>> .../Include/Dsc/Manageability.dsc | 16 ++++++++ >>> .../ManageabilityPkg/ManageabilityPkg.dsc | 39 >> +++++++++++++++++++ >>> 3 files changed, 76 insertions(+) >>> create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dec >>> create mode 100644 >> Features/ManageabilityPkg/Include/Dsc/Manageability.dsc >>> create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dsc >>> >>> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec >>> b/Features/ManageabilityPkg/ManageabilityPkg.dec >>> new file mode 100644 >>> index 0000000000..71bd8a0c80 >>> --- /dev/null >>> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec >>> @@ -0,0 +1,21 @@ >>> +## @file >>> +# Manageabilty Package >>> +# This is the package provides the edk2 drivers and libraries # those >>> +are related to the platform management. >>> +# >>> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights >>> +reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## >>> + >>> +[Defines] >>> + DEC_SPECIFICATION =3D 0x0001001d >>> + PACKAGE_NAME =3D ManageabilityPkg >>> + PACKAGE_GUID =3D 36310119-4FB2-4BA3-959D-74C16B849F9E >>> + PACKAGE_VERSION =3D 1.0 >>> + >>> +[Includes] >>> + Include >>> + >>> +[Guids] >>> + gManageabilityPkgTokenSpaceGuid =3D { 0xBDEFFF48, 0x1C31, 0x49CD, { >>> +0xA7, 0x6D, 0x92, 0x9E, 0x60, 0xDB, 0xB9, 0xF8 } } >>> diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc >>> b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc >>> new file mode 100644 >>> index 0000000000..2cb63c1ca6 >>> --- /dev/null >>> +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc >>> @@ -0,0 +1,16 @@ >>> +## @file >>> +# Common libraries for Manageabilty Package # # Copyright (C) 2023 >>> +Advanced Micro Devices, Inc. All rights reserved.
# >>> +SPDX-License-Identifier: BSD-2-Clause-Patent # ## >>> + >>> +[LibraryClasses.ARM, LibraryClasses.AARCH64] >>> + # >>> + # This library provides the instrinsic functions generated by a give= n >> compiler. >>> + # >>> + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf >>> + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf >>> + ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf >>> + >>> diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc >>> b/Features/ManageabilityPkg/ManageabilityPkg.dsc >>> new file mode 100644 >>> index 0000000000..b3586afa07 >>> --- /dev/null >>> +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc >>> @@ -0,0 +1,39 @@ >>> +## @file >>> +# Manageabilty Package >>> +# This is the package provides edk2 drivers and libraries # those are >>> +related to the platform management. >>> +# >>> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights >>> +reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## >>> + >>> +[Defines] >>> + PLATFORM_NAME =3D ManageabilityPkg >>> + PLATFORM_GUID =3D 7A98123A-B194-40B6-A863-A52192F6D= 65D >>> + PLATFORM_VERSION =3D 1.0 >>> + DSC_SPECIFICATION =3D 0x0001001e >>> + OUTPUT_DIRECTORY =3D Build/ManageabilityPkg >>> + SUPPORTED_ARCHITECTURES =3D IA32|X64|ARM|AARCH64|RISCV64 >>> + BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT >>> + SKUID_IDENTIFIER =3D DEFAULT >>> + >>> +[Packages] >>> + MinPlatformPkg/MinPlatformPkg.dec >>> + >>> +[PcdsFeatureFlag] >>> + # >>> + # MinPlatform common include currently required PCD >>> + # >>> + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable >> |FALSE >>> + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable >> |FALSE >>> + >>> +# >>> +# Include common libraries >>> +# >>> +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc >>> +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc >>> +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc >>> + >>> +!include Include/Dsc/Manageability.dsc >>> + >> >>=20 >>