public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v1 1/1] uefi-sct/SctPkg AdapterInfo SetInformation pass on EFI_UNSUPPORTED
@ 2019-09-12  9:23 Tom Zhao
  0 siblings, 0 replies; only message in thread
From: Tom Zhao @ 2019-09-12  9:23 UTC (permalink / raw)
  To: devel; +Cc: Eric Jin Eric Jin, Supreeth Venkatesh

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2113

AdapterInfoProtocolTest SetInformation Func and Conf change to
pass on EFI_UNSUPPORTED, better fitting the UEFI Spec.

Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Cc: Eric Jin Eric Jin <eric.jin@intel.com>
Signed-off-by: Tom Zhao <tzhao@solarflare.com>
---
 uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c | 4 ++--
 uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c    | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git
a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c
b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c
index fb42398e4a97..3dc048db5333 100644
---
a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c
+++
b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestConformance.c
@@ -556,8 +556,8 @@ BBTestSetInformationConformanceTestCheckpoint2 (
                            NULL,
                            InformationBlockSize
                            );
-      -    if ( Status != EFI_INVALID_PARAMETER && Status !=
EFI_WRITE_PROTECTED) {
+
+    if ( Status != EFI_INVALID_PARAMETER && Status !=
EFI_WRITE_PROTECTED && Status != EFI_UNSUPPORTED) {
         AssertionType = EFI_TEST_ASSERTION_FAILED;
     } else {
         AssertionType = EFI_TEST_ASSERTION_PASSED;
diff --git
a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c
b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c
index 334bb9edc493..4b054b0ef7d8 100644
---
a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c
+++
b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/AdapterInfo/BlackBoxTest/AdapterInfoBBTestFunction.c
@@ -372,11 +372,11 @@ BBTestSetInformationFunctionTestCheckpoint1 (
                              InformationBlockSize1
                              );
 -    if (Status == EFI_SUCCESS || Status ==  EFI_WRITE_PROTECTED)
-      AssertionType = EFI_TEST_ASSERTION_PASSED;  +    if (Status ==
EFI_SUCCESS || Status ==  EFI_WRITE_PROTECTED || Status == EFI_UNSUPPORTED)
+      AssertionType = EFI_TEST_ASSERTION_PASSED;
     else
-      AssertionType = EFI_TEST_ASSERTION_FAILED; -    +
AssertionType = EFI_TEST_ASSERTION_FAILED;
+
     StandardLib->RecordAssertion (
                      StandardLib,
                      AssertionType,
-- 
2.21.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-09-12  9:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-12  9:23 [PATCH v1 1/1] uefi-sct/SctPkg AdapterInfo SetInformation pass on EFI_UNSUPPORTED Tom Zhao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox