From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3FEE094108F for ; Wed, 11 Oct 2023 04:14:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xdMJhIwRN8xmgFNUJXyq9P+ugbcD12O8YKNyxBfb5yI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696997657; v=1; b=ryLDo5SUlkq8JfDGgmb9oMVdihU5tACQCKHH30b+CHO7S16Avmk3KfRkUZxPsdnqIAmUk2dK x6527LjTmBwtB7Uwo9itDBt3wFqo2uybzKmm/NReWGuQX0Unj3uUBAn1XynrpVdBSd07D9AsLjw Xi9bXZfnKr+geoMNOw8r3UWg= X-Received: by 127.0.0.2 with SMTP id YCEyYY7687511xKNcj9AXjLe; Tue, 10 Oct 2023 21:14:17 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.131]) by mx.groups.io with SMTP id smtpd.web11.9630.1696997656219843841 for ; Tue, 10 Oct 2023 21:14:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DQb28KTZWNti88ORzUWgqiDFmmPMK8oL7RoC3S/UMhwi6qgaOYC1Lpp03YBZNbW42/xWy9rPgpf9mebzMbqYEyT8wh9eEfO/Ws9TTpFwXXx/tYIssVG2J9/kPYwc+ihNFe4ZdRZjiJxKQYvZe8xKUkIg5Ah0ueTVxmC2k9L3z7isJFh2NdzZ4B8UUaupM99nywo/ZiR9COq09XZSZ3IhIzFoOjCu+cLCFc3EsZQf3DJ5+LBXg182vZ5jzXXI9Vy0nqEyMVksGsY7znV1zG+SqJxueqN0Z3id6onMJIB6u6Ry7JnJvMRlhdYezgz2/MaZGvma4TWRwbQ00Fd0Ts/PCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yLm5+y1RiQPQdN/xut4VRL0cVCWbif5/nEqv896RzX4=; b=bfl/hgtPdPWDEu5/Oaqe1mbYxAn+qv+DA4vsGUth1N1ZnkN9on+0qlSniqs7rA9m6bR6pLO76zyzoq4rrXnLkusDm7msCjHsK87T87y+y+iqrPVxwaqufRmjcuRu4otvyK4YlUY0v7ukbpKouv73MAfXfbS1h98Sy6u73VOA+6+Zg1IEkTUHf27NyDzuSu2wGuzF8TcCgnKz96is7xLDYVAq23Qk3QA3MkMA6VeaIyfPayzmPh88EEHkkZlyzVKuJSkLGbBtQ78veEV5lYeDnuObcGVPcGOoDC4+k2T28oHCuauBKPIUzJ00jQ1znKoT05cmttHMDIzTLjGJdHw2zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by PH0PR01MB6229.prod.exchangelabs.com (2603:10b6:510:1f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Wed, 11 Oct 2023 04:14:11 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::2237:1801:e15c:e8b7]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::2237:1801:e15c:e8b7%6]) with mapi id 15.20.6838.039; Wed, 11 Oct 2023 04:14:10 +0000 Message-ID: Date: Wed, 11 Oct 2023 11:13:58 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH] RedfishPkg: Use base version SortLib for the specific modules To: Nickle Wang , "abner.chang@amd.com" , "devel@edk2.groups.io" Cc: Igor Kulchytskyy References: <20231011034106.1524-1-abner.chang@amd.com> From: "Nhi Pham via groups.io" In-Reply-To: X-ClientProxiedBy: SG2PR04CA0153.apcprd04.prod.outlook.com (2603:1096:4::15) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|PH0PR01MB6229:EE_ X-MS-Office365-Filtering-Correlation-Id: 5cc72946-d36d-4110-bc38-08dbca1084e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: ST87DZEnJ91mQ/5UGZMAIPo/CsdXqZRQl8xOyV/Z0Ykqg76vp6Oyn1fbJd782gt1XZ5P7fP7izq7D1fuawMtGWxkkKLWj6tOObzAzpeI7UwZjsTu8h4feX+6aXj4yOi0ANXIffLMlRCRlK8WJsgp9ee8OmMJdYgG3CTOVxD5F/A/M5utlmqxpciErUusnQAt+E4wXjwNkK3Vw7lyCuBHf9PAVyBnRk7f3M2C6GsdsaGAyjIBDRn/YEoIHNZWzJZC43Ag3GmnfMe02w/FEzoR9/YWTzqJZGeUyu1LlZA67UDZBUroHybD7o3oDH4xIvht0gr8ofHR6fH/OWZQirvuSe9tAlszIR0EAqBLXTPM2Mwnly3sfCLtc1WRcDT76psUvFj4BpGHm4hdcSCRhqsQVLuKHonwFroXz2G/T72/PxKLCQR2NSOLyfCgtydjWjY6d70b9QewNq4mYp1vj0lqwoljTpk/eIv6HdKNNvPDnGYsTgzTuVEM+A9FM6ye7iNEbMm+FpkXre2N5ig20Q/EITcO36RPHUBfVAOAs7z7KMf0m0f3Y2wEl1+UyA2IVkjsjTA/qPpITg2BNLE10PC617PaG3kquvyC+ECvTOruyn7x3/QW1OYN+B/6dCyI0cudwxFwASOSvdGU2Td4x0rFxg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0JYM2RqTHFnb1RxMkY4ZEpHdCtnVWRVeHkvNUxBQ2tnQm9RN2RBTGZhakRX?= =?utf-8?B?TUticUlRbEtrRCtYT2NyNjMyT2RXNGoxWHZ0bFJoWkxJOXFIKzhnekVNdlMz?= =?utf-8?B?L3RCZDdibHZvOFd6WEo4REpqK2ZpUm9mUzV5bXk4Rm85ekZCTlFwTjlicWhh?= =?utf-8?B?MGZJSUhmc04zem9Ic3ByMEh6M2p4NDNMYTBoWEVaT2NrV3FsTEhiVk5vRHA4?= =?utf-8?B?dUlIRGFQY1BCNko4S25sb3JCcGFLaDF1dWZhSlVOaDNMWXJnY1UrUmF2dVFM?= =?utf-8?B?M1I1NXZaR3ZYOGZsWUlNQzYvL0hUYjAzQkN4ZGNuVmZhMG1HcHA0VmEzcW5S?= =?utf-8?B?NFRKczVHc1F5aVZvWFJSdjAvN1VBTHRheG9VZWNmcVRCb0VVQ1FGckZXdnhl?= =?utf-8?B?eDd2UEM3VDMxZCtIQm5KT0pXTzU2S2tySHREUXB2d0piZXJEcDdnUHgzeSs5?= =?utf-8?B?d1hHaTQvL2NrWXo4S09EKzEzNHhLOGZjTG1ZYVNGOFZsV1kyUWtINlhKeHRM?= =?utf-8?B?dENMbWZoVHJyNnIvSFpJeW1nKzZzV3hzQVlkNlluTFdiTWV5SHBFN1lXTnRY?= =?utf-8?B?aGZaVU9FdjI5dk1CRFpXa1RkdHNlcFZXdC9ndlJRSGZtVzZzRjFXdVZ2anJv?= =?utf-8?B?QllOc0lzS2U3MXRQOE9kQmkwQU15bjVITDBKNWFKMUNPeUwvcklqRGcwWW01?= =?utf-8?B?bm0wdzBVSUgyZWxZUS9vZUdBVFQyMnRvRzBjaHNLRVRHZS9qMWUzZktPU3k2?= =?utf-8?B?cVVXb3FQckw4RmpGK3ZENUtPZXY0c1ZBME40SDM3MUY2SmF3RGxjQ2ZjTjhj?= =?utf-8?B?WDRDYm0rVTdjNC9rK2E1b1ZHb2E5NkRQS24zamIyQjRmNVJHTzF5emIvUTNa?= =?utf-8?B?c21IcXZzK0xlNlB3MVpaa05rTU9ZdXJRUU9EdlVwcDQyQnhmcjZrcHpaZURI?= =?utf-8?B?OUJKR005ME5zeUFHVHlJUUIvT1oyOURNNlJaUmxDY2Vhb1VMSkdhc1FiNnZF?= =?utf-8?B?RlB2SWhIeEs2QTVESzJ2bHhHRTIzcGUrMWFJZnRaVHdTWFhzTlJ6RGVyQXFC?= =?utf-8?B?dzgxdCt2Mnl5VXdrdUFDaVcraGs4dGgrK0htRW1hSGwxV25yZVZlZmpOZkwy?= =?utf-8?B?NHNMOEJJYmNHM3VtMkoxZUVmWmJCL1VEeEQ3bElzR29HVThydy9jMzFiRGoz?= =?utf-8?B?alZQMjFBNFEzb0dmd1Jib2QreFd4TXFIU09aZmVFakZaTGRCMU9yRHhYSmNu?= =?utf-8?B?N01BalVFeHlTUFBpRXQ2aEpiZTBvcmVCTGRxQ3JtQ2NETzRFN3ZPMjg5QXlP?= =?utf-8?B?cTNFSnE4RURvbjE5UmN2RnhSZnc4NDI0MmpQV2ppOU41SzI2eTdqUWNjM0VQ?= =?utf-8?B?VVlkRjd1Tkg0a3VuUStIL2hZeGp2TllYeERmWVdNU01lNERGNk1YR3BTZXJl?= =?utf-8?B?MmZ6RzdNb3JLTWZmeXJZZmRMVWxTTGlWN0R6RnZZcHp5SzB2UFBxK2xQMGFY?= =?utf-8?B?RFQzU1hVaG1CU05sVUswems0UTlCWHhxU1RDZis1YkRXR3FJZ1VNcEJQSHNW?= =?utf-8?B?NVFSSDBVc3RUdjVvRC82ZWdkU25UMEQ0UGFLMW9iVWxYY0wvU25ySlE5QWFq?= =?utf-8?B?VS9jYlYybnFwekpXbHJYaXUxcHVSMGtucVgvdHJ1L1ZoRlBFalhRSEhxR2Jt?= =?utf-8?B?a0tTUGRmb0pkZG9sRU9PU0loVnpYOEJtUTRPdklyMnlXd0dkOTk0K28wdmRw?= =?utf-8?B?djk5VS9ZUVZ4aFVYL045OVIyQ0haa2diTEdqZFRJZzhkR0szWnlPVnB0TXlV?= =?utf-8?B?dGJCbFc2NjEyVWwwS3YxeGpDb0MzMFpMRUVwajcxY2d0VXFCa0toKzBNbW53?= =?utf-8?B?MzFYdGFNRytwWWcvZnUxQjJ1VDR0a3FYeUFKYkx3WGdldDJTUUpjUWtQbVBO?= =?utf-8?B?dDFaTjJaS2grbVRDckpYY3NybXdRR05Ydnp0ejljbWtuRGRaZ01rNHQ2aEMv?= =?utf-8?B?OEIzeURTVmt2cnZ5RDFleHFPNGkwTWhFREl1ODVscDFaVEpUb2lvWmU4Wmoy?= =?utf-8?B?SExQUm05VWtPY2dGblBlZkUyM25VTXExeUpFVGVuZTRIR1huSm5MckxVRkVy?= =?utf-8?B?NWJHNTZlMGo1cVlNNDIyckw5OGk5LzFCay9XR1ZiS1V3dmFPaFd5bTRlZUUr?= =?utf-8?B?Y3c9PQ==?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cc72946-d36d-4110-bc38-08dbca1084e2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 04:14:10.3630 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L9PcU1wdL6/Xjh3WwiCKD3A367ma/IsYyys8sHCc6csS8UpQDrwbwmHkoY8y6gOx7n03GYatEW6L6+u6nJQMfA+sli7zTq+CAaOjMFfQOMU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6229 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NWarBUtJSPwRBQPrSGlUmsYIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ryLDo5SU; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks for writing this patch. Reviewed-by: Nhi Pham Tested-by: Nhi Pham Regards, Nhi On 10/11/2023 10:49 AM, Nickle Wang wrote: >=20 > Reviewed-by: Nickle Wang >=20 > Regards, > Nickle >=20 >> -----Original Message----- >> From: abner.chang@amd.com >> Sent: Wednesday, October 11, 2023 11:41 AM >> To: devel@edk2.groups.io >> Cc: Nickle Wang ; Igor Kulchytskyy ; = Nhi >> Pham >> Subject: [PATCH] RedfishPkg: Use base version SortLib for the specific m= odules >> >> External email: Use caution opening links or attachments >> >> >> From: Abner Chang >> >> BZ #: 4566 >> >> Update Redfish modules to use the small footprint version of base SortLi= b by the >> means of module scoped subelement . With this the platform= level >> SortLib (full version) is not impacted if Redfish.dsc.inc is included in= platform DSC. >> >> Signed-off-by: Abner Chang >> Cc: Nickle Wang >> Cc: Igor Kulchytskyy >> Cc: Nhi Pham >> --- >> RedfishPkg/RedfishComponents.dsc.inc | 10 ++++++++-- >> RedfishPkg/RedfishLibs.dsc.inc | 1 - >> 2 files changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/RedfishPkg/RedfishComponents.dsc.inc >> b/RedfishPkg/RedfishComponents.dsc.inc >> index 1c4284d3ecf..464ffc86064 100644 >> --- a/RedfishPkg/RedfishComponents.dsc.inc >> +++ b/RedfishPkg/RedfishComponents.dsc.inc >> @@ -16,9 +16,15 @@ >> !if $(REDFISH_ENABLE) =3D=3D TRUE >> RedfishPkg/RestJsonStructureDxe/RestJsonStructureDxe.inf >> RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf >> - RedfishPkg/RedfishRestExDxe/RedfishRestExDxe.inf >> + RedfishPkg/RedfishRestExDxe/RedfishRestExDxe.inf { >> + >> + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf >> + } >> RedfishPkg/RedfishCredentialDxe/RedfishCredentialDxe.inf >> - RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf >> + RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf { >> + >> + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf >> + } >> RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf >> RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.inf >> MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf >> diff --git a/RedfishPkg/RedfishLibs.dsc.inc b/RedfishPkg/RedfishLibs.dsc= .inc index >> 03b7ef6f328..5426957da87 100644 >> --- a/RedfishPkg/RedfishLibs.dsc.inc >> +++ b/RedfishPkg/RedfishLibs.dsc.inc >> @@ -14,7 +14,6 @@ >> !if $(REDFISH_ENABLE) =3D=3D TRUE >> RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf >> Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf >> - SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf >> RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.= inf >> JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf >> RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf >> -- >> 2.37.1.windows.1 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109514): https://edk2.groups.io/g/devel/message/109514 Mute This Topic: https://groups.io/mt/101890398/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-