From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C35C1941806 for ; Thu, 14 Dec 2023 12:28:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SOpvyYlEMYXApvwHA6zqJLwhtb4dYP75of8NUFTBQ9o=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702556880; v=1; b=Q3QSHluxV5YJZ+ARyAOZ30JI0NFFNtYKiIalWBS9besrIYYJTcpROP7VRODDOKxCezfwbh4N Cth7bntszfuHRb+VyMAjJq6XGQlxBlBcu3BDWufziu2ZqIhB7jwukduX73Rv1zrNC8nW2s5hSnq +rPh5dJLlCSASjCIMqLDLPqg= X-Received: by 127.0.0.2 with SMTP id cidjYY7687511xcdUTpweftM; Thu, 14 Dec 2023 04:28:00 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.20821.1702556879700600394 for ; Thu, 14 Dec 2023 04:27:59 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-I9CAEq59OAic4dXpkt9XeA-1; Thu, 14 Dec 2023 07:27:53 -0500 X-MC-Unique: I9CAEq59OAic4dXpkt9XeA-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D1CCD185A781; Thu, 14 Dec 2023 12:27:52 +0000 (UTC) X-Received: from [10.39.193.43] (unknown [10.39.193.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C322A40C6EB9; Thu, 14 Dec 2023 12:27:50 +0000 (UTC) Message-ID: Date: Thu, 14 Dec 2023 13:27:49 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v3 1/1] CloudHv: Add CI for CloudHv on AArch64 To: Sami Mujawar , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, kraxel@redhat.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Sibel.Allinson@arm.com, nd@arm.com References: <20231213151320.23192-1-sami.mujawar@arm.com> From: "Laszlo Ersek" In-Reply-To: <20231213151320.23192-1-sami.mujawar@arm.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FQT79oFmUU0qcBjhCcIeXbB9x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Q3QSHlux; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 12/13/23 16:13, Sami Mujawar wrote: > From: Jianyong Wu >=20 > Add the long lost CI for CloudHv on AArch64. > As CloudHv CI works nearly the same way with other VMMs like KvmTool, > thus we can easily create its CI configuration based on KvmTool. >=20 > Reviewed-by: Laszlo Ersek > Signed-off-by: Jianyong Wu > Signed-off-by: Sami Mujawar > --- >=20 > The changes can be seen at: https://github.com/samimujawar/edk2/tree/2897= _cloudhv_ci_v3 >=20 > Notes: > v3: > - CI fails to build when merging this patch [Laszlo] > Ref: https://edk2.groups.io/g/devel/message/112321 > - Added missing comma in supported architecture lists [Sami] > in CloudHvBuild.py to fix the issue. Huh, singleton tuple! https://docs.python.org/3/library/stdtypes.html#tuple "Using a trailing comma for a singleton tuple: a, or (a,)" I guess that broke with the ArchSupported update from v1 to v2: - ArchSupported =3D ("AARCH64", "ARM") + ArchSupported =3D ("AARCH64") Sami, you have push right; can you merge this? Thanks! Laszlo >=20 > ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 13 ++++++++ > ArmVirtPkg/PlatformCI/CloudHvBuild.py | 32 +++++++++++++= +++++++ > 2 files changed, 45 insertions(+) >=20 > diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmV= irtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > index d1772a65fc3a84f7f981971ff4ed6c37d7ba84f6..ab8a2db53026db686ae4e5943= 044235c63ab3a80 100644 > --- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > +++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml > @@ -140,6 +140,19 @@ jobs: > Build.Target: "RELEASE" > Run: false > =20 > + CLOUDHV_AARCH64_DEBUG: > + Build.File: "$(package)/PlatformCI/CloudHvBuild.py" > + Build.Arch: "AARCH64" > + Build.Flags: "" > + Build.Target: "DEBUG" > + Run: false > + CLOUDHV_AARCH64_RELEASE: > + Build.File: "$(package)/PlatformCI/CloudHvBuild.py" > + Build.Arch: "AARCH64" > + Build.Flags: "" > + Build.Target: "RELEASE" > + Run: false > + > workspace: > clean: all > =20 > diff --git a/ArmVirtPkg/PlatformCI/CloudHvBuild.py b/ArmVirtPkg/PlatformC= I/CloudHvBuild.py > new file mode 100644 > index 0000000000000000000000000000000000000000..5100a56f3be5ad6d2b156352a= 521900f93d1de27 > --- /dev/null > +++ b/ArmVirtPkg/PlatformCI/CloudHvBuild.py > @@ -0,0 +1,32 @@ > +# @file > +# Script to Build ArmVirtPkg UEFI firmware > +# > +# Copyright (c) Microsoft Corporation. > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > +import os > +import sys > + > +sys.path.append(os.path.dirname(os.path.abspath(__file__))) > +from PlatformBuildLib import SettingsManager > +from PlatformBuildLib import PlatformBuilder > + > + # ##################################################################= ##################### # > + # Common Configuration = # > + # ##################################################################= ##################### # > +class CommonPlatform(): > + ''' Common settings for this platform. Define static data here and = use > + for the different parts of stuart > + ''' > + PackagesSupported =3D ("ArmVirtPkg",) > + ArchSupported =3D ("AARCH64",) > + TargetsSupported =3D ("DEBUG", "RELEASE") > + Scopes =3D ('armvirt', 'edk2-build') > + WorkspaceRoot =3D os.path.realpath(os.path.join( > + os.path.dirname(os.path.abspath(__file__)), "..", "..")) > + > + DscName =3D os.path.join("ArmVirtPkg", "ArmVirtCloudHv.dsc") > + FvQemuArg =3D "" # ignored > + > +import PlatformBuildLib > +PlatformBuildLib.CommonPlatform =3D CommonPlatform -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112525): https://edk2.groups.io/g/devel/message/112525 Mute This Topic: https://groups.io/mt/103150734/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-