From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mx.groups.io with SMTP id smtpd.web11.21743.1683735285386496342 for ; Wed, 10 May 2023 09:14:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=FckyVw24; spf=pass (domain: bsdio.com, ip: 64.147.123.24, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 531D5320091D; Wed, 10 May 2023 12:14:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 10 May 2023 12:14:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683735283; x=1683821683; bh=1raqqApndfpMF7bIP1kdCLxSu3a4uujHyHs xuYK8ge8=; b=FckyVw24reelmKbI51E6TFp5Ar2U8wd7OPHRxFEbv1YJenD10Dh JhRySiMPWEJc9NJVmXQgYLrmxtHwlVFrJvgPc647whHeGzUK/dd/6ppHUh9OnXp1 BHgjMq5z6U9R2dDAZhUT4fqnmX1WsZvAsfhPcHt9OaI8x7MDVBrsBia4BMm+Lhmh xJ3CS2Go4mRLjq8i6orkCB0DPA0+e0b7KUt+LptbD68wpm7khKMs5dT7e5GZrTpr DG36kzS0CbOySw8/iMcbpMt52QGGbBBgrqVH4CZWlMm8DBbnYWjWacEFxfQoFcAy MkFy5AwATMR++O5XRscydIlJxRM81YFU9wQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683735283; x=1683821683; bh=1raqqApndfpMF7bIP1kdCLxSu3a4uujHyHs xuYK8ge8=; b=YEsGTX9Y1sKwgeku/qC/6WRVBwa3B7hrrF9MT0Ffc8mAyy/w1U/ WuBpGTiG0RxyZbit808RmIq67WSVw7eg4injkhXaSNUuPg46aJmy1psgf06uxJ2r S0/KqGruRLFE+Dk2lsaDKlywKUs7LnxNB0HkMBYw4zThUYA1pmxg3IXJCKk6JMNk Ie63yPFYgHubeNNW3D7vkeUNw1DhRzPUkQz8H1T1yABQsznxY0wFS952OQTvvWii xXr/UG3R1R2ji1YaeQ4fTbePVHPKjqrbbAkNcJ0oOHAndaUdAZXLgs95gDO86vPT VbpOxUggAe8KeumxhQiNXqG3Zu/oyrrvtEA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeegiedgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 May 2023 12:14:43 -0400 (EDT) Message-ID: Date: Wed, 10 May 2023 10:14:42 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 1/1] Platform/SbsaQemu: read platform version To: Marcin Juszkiewicz , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar References: <40996fe8-7fc3-40cc-a106-a2e85e952703@bsdio.com> <20230510160611.202580-1-marcin.juszkiewicz@linaro.org> From: "Rebecca Cran" In-Reply-To: <20230510160611.202580-1-marcin.juszkiewicz@linaro.org> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/10/23 10:06, Marcin Juszkiewicz wrote: > + Result = ArmCallSmc0 (SIP_SVC_VERSION, &Major, &Minor, NULL); > + if (Result == SMC_ARCH_CALL_SUCCESS) > + { > + Result = PcdSet32S (PcdPlatformVersionMajor, Major); > + ASSERT_EFI_ERROR (Result); > + Result = PcdSet32S (PcdPlatformVersionMinor, Minor); > + ASSERT_EFI_ERROR (Result); > + } > + > + Major = PcdGet32 (PcdPlatformVersionMajor); > + ASSERT_EFI_ERROR (Major); > + Minor = PcdGet32 (PcdPlatformVersionMinor); > + ASSERT_EFI_ERROR (Minor); > + > + DEBUG((DEBUG_INFO, "Platform version: %d.%d\n", Major, Minor)); > + > return EFI_SUCCESS; > } Sorry, but there are new problems. There should be a space before the parenthesis in the 'DEBUG' line. PcdGet32 doesn't return a RETURN_STATUS or EFI_STATUS, so ASSERT_EFI_ERROR is incorrect. -- Rebecca Cran