From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.groups.io with SMTP id smtpd.web10.660.1570728909231185360 for ; Thu, 10 Oct 2019 10:35:09 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B913E8E582; Thu, 10 Oct 2019 17:35:08 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-48.rdu2.redhat.com [10.10.120.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id E480F600F8; Thu, 10 Oct 2019 17:35:07 +0000 (UTC) Subject: Re: [edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64 To: devel@edk2.groups.io, liming.gao@intel.com, "Justen, Jordan L" References: <1569570395-11240-1-git-send-email-liming.gao@intel.com> <1569570395-11240-13-git-send-email-liming.gao@intel.com> <115e2a05-08b1-3ff6-018a-d7190a98f9d4@redhat.com> <15CBB488DC5DB3E9.15045@groups.io> <4A89E2EF3DFEDB4C8BFDE51014F606A14E51579F@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 10 Oct 2019 19:35:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E51579F@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 10 Oct 2019 17:35:08 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Liming, On 10/10/19 16:08, Liming Gao wrote: > Laszlo: > Option (a) works. Jordan patch can fix this issue. > Option (b) doesn't work. Even if disable optimization, CLANG doesn't generate the code with push rbp & pop rbp. > > So, Jordan patch becomes only option. We can discuss this topic again. But, I don't think this is the block issue > to add new CLANG9 tool chain. I will try to add CLANG9 tool chain patch without this change, and use BZ 2024 to track this issue. not sure I understand you correctly. - If you intend to drop this patch from the series, and enable CLANG9 for edk2 without enabling it for OvmfPkg specifically (for the time being), that's fine with me. - If you'd like to push this patch first, and work on the general PEI Core issue second, then I defer to Jordan for reviewing this patch. I'd like to neither approve nor reject this patch myself, in that case. Thanks Laszlo