From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.8661.1650465939594283518 for ; Wed, 20 Apr 2022 07:45:39 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=AF55bGeI; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.46.36]) by linux.microsoft.com (Postfix) with ESMTPSA id 5DF0120E2C1A; Wed, 20 Apr 2022 07:45:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5DF0120E2C1A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1650465939; bh=sHILzbDnLvwwfmM56TQIHOXzdc4MV1bfu6w3QUjex9g=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AF55bGeIPX0EuPV7uAVykUZAFW6Udz0FgSgNq4+/C4B00E6C7h4mDD8tkIfr4mmJf TvL+VLvoRI1FXEt8zPWbyCTeu5K6hrG0PGU1qRzx2Iu6wfao1sg9D2GE/01qZBaK02 BTTREUkUxE7cMUJAMbPHsVeek4nwvI8ClaMpEomI= Message-ID: Date: Wed, 20 Apr 2022 10:45:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [edk2-devel] Some questions about Azure CI To: Chao Li , "devel@edk2.groups.io" Cc: "michael.d.kinney@intel.com" , "quic_rcran@quicinc.com" , "spbrogan@outlook.com" References: <3FB8CF0A-BF1B-4A0A-924B-3B5F6D7EB834@getmailspring.com> From: "Michael Kubacki" In-Reply-To: <3FB8CF0A-BF1B-4A0A-924B-3B5F6D7EB834@getmailspring.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable My understanding is that you were referring to the document on my fork=20 being difficult to access and you shared a link to your CI results that=20 does not have the message pointing to the wiki page yet. This is all correct. The wiki content has moved from my fork to the=20 official wiki page and the patch that adds the message to the CI results=20 has not been merged yet. It is posted on the mailing list here and=20 waiting for reviews: https://edk2.groups.io/g/devel/message/89098 --- As for your build failing between yesterday and today, note that the=20 builds are based on different commits. Yesterday: https://github.com/loongson/edk2/commit/8d100910a2ad98b71acaabc0dcdd70be7e0= eba63 Today: https://github.com/loongson/edk2/commit/6ca5d9d6c55ca773a652fe52508e980c7aa= 372d3 The commits have different content. In particular, I took a quick look=20 at a build that is failing now (Build_GCC5 TARGET_MDEMODULE_DEBUG) but=20 previously succeeded. The compilation step is failing for reasons such as the following: INFO -=20 /home/vsts/work/1/s/MdePkg/Include/LoongArch64/ProcessorBind.h:35:24:=20 error: expected =E2=80=98=3D=E2=80=99, =E2=80=98,=E2=80=99, =E2=80=98;=E2= =80=99, =E2=80=98asm=E2=80=99 or =E2=80=98__attribute__=E2=80=99 before =E2= =80=98UINT16=E2=80=99 INFO - 35 | typedef unsigned shor UINT16; Notice, that there is a typo introduced in the new commit. "shor" versus=20 "short", this is what is causing compilation failure. Here is a comparison of those two commits showing the line in=20 ProcessorBind.h that is causing the problem: https://github.com/loongson/edk2/compare/8d10091..6ca5d9d#diff-50b24eb92c57= 85d5c70097a70104040fcacfb70225dd8196c1a97ef3bbb305c8R35-R36 Regards, Michael On 4/20/2022 7:08 AM, Chao Li wrote: > Hi Micheal, >=20 > Do you know if anyone has modified the Azure CI today? I did a CI test=20 > today, and many modules reported errors, but yesterday, only two modules= =20 > reported errors, I don't know what happened. Please refer following two= =20 > links: >=20 > Today: > https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=3D= 32&view=3Dresults=20 > > Yesterday: > https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=3D= 31&view=3Dresults=20 > >=20 > -- > Thanks, > Chao > ------------------------ >=20 >=20 > On 4=E6=9C=88 20 2022, at 6:10 =E6=99=9A=E4=B8=8A, Chao Li wrote: >=20 > Hi Micheal, >=20 > Sorry for late reply, I'm busy with other things, focusing on > modifying our code, refer to the detailed error log file. >=20 > I am learning how to get the detailed log from this link: > https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrusti= fy_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting= -errors-in-continuous-integration-ci > . > I didn't find the detailed log link in the Azure error log, it looks > like: > https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildI= d=3D31&view=3Dlogs&j=3D9701361e-2546-5093-77e5-58c75d95b7ce&t=3D27131ef8-75= e1-57c3-3236-d806181f2f1f > . >=20 > -- > Thanks, > Chao > ------------------------ >=20 >=20 > On 4=E6=9C=88 20 2022, at 9:56 =E4=B8=8A=E5=8D=88, "Michael Kubacki" > wrote: >=20 > Hi Chao, >=20 > Are you referring to the change I made to put the link to the > instructions in the build log. Here's an example of what that > will look > like: >=20 > https://github.com/makubacki/tianocore.github.io/blob/temp_show_u= ncrustify_ci_link_in_build_log/images/edk-ii-code-formatting/temp-example-i= nstruction-link-in-build-log.png?raw=3Dtrue >=20 > (some of the words running together are not in the actual change) >=20 > I'm open to moving it elsewhere but developers will need to know > how to > at least find that or they will have trouble fixing build issues. >=20 > Regards, > Michael >=20 >=20 > On 4/19/2022 9:46 PM, Chao Li wrote: > > Hi Micheal, > > Using the way your provided the link, I found the detail log, > thanks, > > but this way is not friendly to newbies, because they don't > know how to > > find the tutorial.:) > > > > -- > > Thanks, > > Chao > > ------------------------ > > > > > > On 4=E6=9C=88 20 2022, at 7:43 =E6=97=A9=E4=B8=8A, "Michael Ku= backi" > > wrote: > > > > The wiki update is here: > > > https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncr= ustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-format= ting-errors-in-continuous-integration-ci > > > > I am waiting for permissions to be updated so I can update > the actual > > wiki page and then I'll send a patch for the plugin change > with the link > > to that section. > > > > Regards, > > Michael > > > > On 4/19/2022 6:15 PM, Michael Kubacki wrote: > > > I agree that is ideal but I'm not aware of how to do that > at the > > moment. > > > > > > Thanks, > > > Michael > > > > > > On 4/19/2022 4:52 PM, Michael D Kinney wrote: > > >> Hi Michael, > > >> > > >> Can the build log provide a direct link to the log file > artifact > > if an > > >> error is detected? > > >> > > >> Mike > > >> > > >>> -----Original Message----- > > >>> From: devel@edk2.groups.io On > Behalf Of > > >>> Michael Kubacki > > >>> Sent: Tuesday, April 19, 2022 12:42 PM > > >>> To: devel@edk2.groups.io; quic_rcran@quicinc.com; > > >>> spbrogan@outlook.com; Chao Li > > >>> Subject: Re: [edk2-devel] Some questions about Azure CI > > >>> > > >>> Hi Rebecca, > > >>> > > >>> We are trying to keep the results reporting experience > > consistent with > > >>> other plugins and prevent an overwhelming amount of > information > > being > > >>> printed to the build log. > > >>> > > >>> In case other errors are present, providing high-level > > information from > > >>> each plugin can help point the user in the right direction= to > > get more > > >>> detail. > > >>> > > >>> I completely understand the concern though, so I'm > planning to make > > >>> another step toward providing more information about how t= o > > debug an > > >>> issue, when it occurs. That is to put the step-by-step > > information about > > >>> where to find the file diff into the EDK II Code Formattin= g > > wiki page > > >>> and then if a failure occurs, print a link to that section= of > > the wiki > > >>> page. I am hoping this will provide sufficient information= to > > get to the > > >>> file diff at the point of failure. > > >>> > > >>> I should be able to send these patches later today. > > >>> > > >>> Regards, > > >>> Michael > > >>> > > >>> On 4/19/2022 12:43 PM, Rebecca Cran wrote: > > >>>> Since people are going to keep running into this, could w= e > > just output > > >>>> the file diff to the console? That would avoid having to = go > > hunting for > > >>>> the log file. > > >>>> > > >>> > > >>> > > >>> > > >>> > > >> > > >> > > >> > > >> > > >> > > >> > > > > > > Sent from Mailspring > >=20 >=20 > Sent from Mailspring