From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3E5B7740038 for ; Thu, 30 May 2024 00:51:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6Vd6s07auxqlxfzOEEqLPLJ0oDn/uWoq8K0PpwCEr9Y=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717030269; v=1; b=zaYBBc75A4iZ1YGCu/Xa8XCINfPYTGwS5eCHdEA8jH/rVYbUj0LkbH+p1Wr5UpUegY8MihCX o+fDaPUq2aJURMPdVTu+7nqyfRqROaXhwhKmv+2O9HPwFOrMhjvT0LdVWGLPG+Mn/L8oY1ShkOU VJPZtgY45sBMq2FXldDuNS74FtylkOKntnyNOizyo/Fk5TqWEDMfX9AKW98GEv0HrGIrN9vT9vS NK6x+rM+lrej026Zd5RCy+Hi/o5KkDgVULVRjOkvXUjtOOC8yEmAbt7jJBo1C1G6WoAlmEhBhU2 Rhzv0KpUuZp7p6paPAe16DoxclCtPlDM79ADsumWc2ang== X-Received: by 127.0.0.2 with SMTP id GXGcYY7687511x3GCBRNpeJp; Wed, 29 May 2024 17:51:08 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.5089.1717030267929337017 for ; Wed, 29 May 2024 17:51:08 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.0]) by linux.microsoft.com (Postfix) with ESMTPSA id DD4D320B915A; Wed, 29 May 2024 17:51:06 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DD4D320B915A Message-ID: Date: Wed, 29 May 2024 20:51:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] GitHub PR Code Review process now active To: "Kinney, Michael D" , "devel@edk2.groups.io" , Rebecca Cran , "kraxel@redhat.com" , "Kubacki, Michael" References: <086790e8-a850-426f-86b1-73f54feebc1b@bsdio.com> <28097adb-a5fa-4bc6-ac39-fbf9ff71b9c4@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 29 May 2024 17:51:08 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sh3hySF9YFIf3UMS3n4zKDSxx7686176AA= Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=zaYBBc75; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io I've updated the wiki process to clarify that maintainers need to ensure=20 PR reviewers are added and that a contributor cannot do so unless they=20 are a maintainer in this update: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Pr= ocess/_compare/b9d1f34e40d8ecbc7b59632302c9b0c823f52ab8...dd846b296754da310= 03f8c2a70e9a0b861e600b6 I did not include the @ ID process since there was not clear=20 consensus on that. I think it's tedious and for this small window of=20 time without automation, ideally the GitHub notifications mentioned=20 earlier can be used. Thanks, Michael On 5/29/2024 4:06 PM, Kinney, Michael D wrote: > We could, but that would require manually syncing CODEOWNERS > with Maintainer.txt until that part of the process is automated. >=20 > We also need a way to verify that CODEOWNERS and Maintainers.txt > produce the exact same assignments. >=20 > This was on the list of future enhancements when resources are > available to help. We need to focus on a process that works > until those automations can be deployed and supported. >=20 > Mike >=20 >> -----Original Message----- >> From: Michael Kubacki >> Sent: Wednesday, May 29, 2024 12:25 PM >> To: devel@edk2.groups.io; Kinney, Michael D = ; >> Rebecca Cran ; kraxel@redhat.com; Kubacki, Michael >> >> Subject: Re: [edk2-devel] GitHub PR Code Review process now active >> >> Mike, >> >> I agree that automatically adding reviewers would be helpful. >> >> Do you think we could add a CODEOWNERS file now to assist with this? >> >> Benefits being: >> >> 1. CODEOWNERS is low overhead in that GitHub already supports it. >> >> 2. We do not need to require CODEOWNER enforcement yet. We can simply >> use it for automating the process of adding maintainers. >> >> 3. Maintainers have write access so they are required to approve and add >> the push label. This would add a relevant maintainer(s) with write >> access to fulfill that role. >> >> Thanks, >> Michael >> >> On 5/29/2024 2:27 PM, Michael D Kinney wrote: >>> GitHub has notification settings. Maintainers should configure >>> GitHub so they are notified of all PR submissions to edk2 repo. >>> >>> The Wiki for the Maintainer Process provides a link to this page with t= he >> details: >>> >>> https://docs.github.com/en/account-and-profile/managing-subscriptions-a= nd- >> notifications-on-github/setting-up-notifications/configuring-notificatio= ns >>> >>> https://docs.github.com/en/account-and-profile/managing-subscriptions-a= nd- >> notifications-on-github/setting-up-notifications/configuring- >> notifications#about-custom-notifications >>> >>> This allows Maintainers to receive notifications without being an >>> assigned reviewer. >>> >>> Mike >>> >>>> -----Original Message----- >>>> From: Rebecca Cran >>>> Sent: Wednesday, May 29, 2024 11:19 AM >>>> To: devel@edk2.groups.io; Kinney, Michael D ; >>>> kraxel@redhat.com; Kubacki, Michael >>>> Subject: Re: [edk2-devel] GitHub PR Code Review process now active >>>> >>>> On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote: >>>>> Hi Gerd, >>>>> >>>>> We can clarify the Wiki. A Maintainer has to be involved in every >>>>> code review. The first action a Maintainer does is verify that the >>>>> code change should be considered at all or rejected. Then add >>>>> maintainers for the ones that look like good submissions. >>>>> >>>>> I agree that this may add a bit of delay. You are welcome to add >>>>> a comment with @ tags to the maintainers and reviewers so >>>>> they know to look at it and do the assignments. If you like that >>>>> idea we can add that to the Wiki as well. >>>>> >>>>> Since PRs can be also opened by outside contributors that have >>>>> limited access, maintainers have to be involved in reviewing newly >>>>> submitted PRs. >>>> >>>> "Then add maintainers for the ones that look like good submissions." >>>> >>>> Surely in order for the maintainers to know the PR should be looked at >>>> in the first place they need to already be added? >>>> >>>> -- >>>> >>>> Rebecca Cran >>> >>> >>> >>>=20 >>> >>> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119373): https://edk2.groups.io/g/devel/message/119373 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-