Re: [edk2-platforms PATCH v2] Intel Platforms: add OrderedCollectionLib class resolution

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 1/18/21 9:48 AM, Laszlo Ersek wrote:
> The edk2 patch
> 
>   ShellPkg/ShellCommandLib: add ShellSortFileList
> 
> for BZ#3151 will make the
> 
>   ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> 
> instance dependent on the OrderedCollectionLib class. Because the shell
> binaries in the Intel platform DSCs consume the above UefiShellCommandLib
> instance, resolve the OrderedCollectionLib class in them.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     v2:
>     
>     - extract OpenBoardPkg update from CometlakeURvp, GalagoPro3,
>       KabylakeRvp3, BoardX58Ich10, UpXtreme, WhiskeylakeURvp to
>       "MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc" [Liming]
>     
>     - do not pick up Phil's and Nate's R-b, due to the above change
> 
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
>  Platform/Intel/QuarkPlatformPkg/Quark.dsc                   | 1 +
>  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc        | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc         | 1 +
>  5 files changed, 5 insertions(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> index 5e3405d54785..cb40e111b5dd 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> @@ -96,6 +96,7 @@ [LibraryClasses.common]
>    ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>    FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
>    SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> +  OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>