From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.31054.1610960760748041867 for ; Mon, 18 Jan 2021 01:06:01 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZTwq7xkV; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610960760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xnl/b3CQ+yy0yGqQF237wU2/kfWZQQWxVKighvAOGQA=; b=ZTwq7xkVxgnZIkimPk7YgkN66ohiEMvhe9HIwmIRRmqOiKLIYxjpZojbEpKK3YuJzHfp70 RevIysZySfS7SxkjE/892H/T5dYDYtIw3xVw+ZqQdr/4Q1q2oj0BVZOlgCTDgPxII6rwiY KPx/EgRgPelz19olIkeMP3g0RtnDuNs= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-PawAe9U_NQ2ilfqQYxkF4A-1; Mon, 18 Jan 2021 04:05:58 -0500 X-MC-Unique: PawAe9U_NQ2ilfqQYxkF4A-1 Received: by mail-wr1-f71.google.com with SMTP id j5so7982986wro.12 for ; Mon, 18 Jan 2021 01:05:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Xnl/b3CQ+yy0yGqQF237wU2/kfWZQQWxVKighvAOGQA=; b=Nfp2Ej4FPcw+izySL+Plh0nBpa+H/+RzU8ROuOcW/+Nk6g6ztVYydINAKtOkrYMNVD icfwkRszUUdBa/YfBDKBJTkpoxBBMLJ7XXY1ch+6LrvDkJ7Ks/2DrXeBUHRl/XK7g7Jq q8sxZq7hffIBP7s2AgDNPOSHbIpiBePywk80OSVyylkBg91VhHNTu7RioiNSmLCjjdHy 7X/2FK8CGwt7l7iQkooeZ5cBIsNC/WLnIgPTlXEKG8FxzDGEBV5jlKP/C/yFmkqE/nv9 nf1hZU41qC2G4iZwDfds/ybDNw/3CC9C1xQb1mVPQL+1LAqFoOlqmzIX6+0JmjOGs62N DLCQ== X-Gm-Message-State: AOAM530Xm2tUwVc1UZlj2WfGuF1uhVIJyMjtGO5HgvUrYmo1F9OY4TYg QgE+Yq3Q2a9+gGrAuP8DrfQTqLXPGUur40HpOpRiFtl9T0NSQjGIYBCMqy/MYHLADMNE7v/ZG4o I9Yvqz/DQxU1cOg== X-Received: by 2002:adf:f18a:: with SMTP id h10mr26204437wro.244.1610960756951; Mon, 18 Jan 2021 01:05:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLq2uMWH0gOaEmZ+flF9PcYBVC83SzNfTXbASWg7AK33OK8U3ehoKhSz+gzuI4+AHIl/ebUQ== X-Received: by 2002:adf:f18a:: with SMTP id h10mr26204412wro.244.1610960756779; Mon, 18 Jan 2021 01:05:56 -0800 (PST) Return-Path: Received: from [192.168.1.36] (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id u6sm31454662wrm.90.2021.01.18.01.05.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 01:05:56 -0800 (PST) Subject: Re: [edk2-platforms PATCH v2] Intel Platforms: add OrderedCollectionLib class resolution To: Laszlo Ersek , edk2-devel-groups-io Cc: Chasel Chiu , Eric Dong , Kelly Steele , Liming Gao , Michael D Kinney , Nate DeSimone , Yi Qian , Zailiang Sun References: <20210118084803.22552-1-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Mon, 18 Jan 2021 10:05:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210118084803.22552-1-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 1/18/21 9:48 AM, Laszlo Ersek wrote: > The edk2 patch > > ShellPkg/ShellCommandLib: add ShellSortFileList > > for BZ#3151 will make the > > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > > instance dependent on the OrderedCollectionLib class. Because the shell > binaries in the Intel platform DSCs consume the above UefiShellCommandLib > instance, resolve the OrderedCollectionLib class in them. > > Cc: Chasel Chiu > Cc: Eric Dong > Cc: Kelly Steele > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Nate DeSimone > Cc: Philippe Mathieu-Daudé > Cc: Yi Qian > Cc: Zailiang Sun > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151 > Signed-off-by: Laszlo Ersek > --- > > Notes: > v2: > > - extract OpenBoardPkg update from CometlakeURvp, GalagoPro3, > KabylakeRvp3, BoardX58Ich10, UpXtreme, WhiskeylakeURvp to > "MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc" [Liming] > > - do not pick up Phil's and Nate's R-b, due to the above change > > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 + > Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 + > Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > 5 files changed, 5 insertions(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > index 5e3405d54785..cb40e111b5dd 100644 > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > @@ -96,6 +96,7 @@ [LibraryClasses.common] > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf Reviewed-by: Philippe Mathieu-Daude