From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Antoine Coeur <Coeur@gmx.fr>, edk2-devel@lists.01.org
Subject: Re: [PATCH v2] BeagleBoardPkg: Fix various typos
Date: Wed, 6 Feb 2019 23:24:30 +0100 [thread overview]
Message-ID: <d61585c1-d227-6233-a7a5-e1989eda0a9d@redhat.com> (raw)
In-Reply-To: <trinity-45c96b39-d460-451a-ba6f-7d1080b9ea90-1549468282905@3c-app-gmx-bs19>
On 2/6/19 4:51 PM, Antoine Coeur wrote:
> Fix various typos in BeagleBoardPkg.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Coeur <coeur@gmx.fr>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
> BeagleBoardPkg/Library/BeagleBoardLib/Clock.c | 2 +-
> BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoff.c | 4 ++--
> BeagleBoardPkg/PrePi/LzmaDecompress.h | 2 +-
> BeagleBoardPkg/Tools/replace.c | 6 +++---
> 5 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
> index e0fee3692f..d677ab3eed 100644
> --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -71,7 +71,7 @@
> # Uncomment (and comment out the next line) For RealView Debugger. The Standard IO window
> # in the debugger will show load and unload commands for symbols. You can cut and paste this
> # into the command window to load symbols. We should be able to use a script to do this, but
> - # the version of RVD I have does not support scipts accessing system memory.
> + # the version of RVD I have does not support scripts accessing system memory.
> #
> # PeCoffExtraActionLib|ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.inf
> PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.inf
> @@ -303,7 +303,7 @@
> # Values are in EFI Pages (4K). DXE Core will make sure that
> # at least this much of each type of memory can be allocated
> # from a single memory range. This way you only end up with
> -# maximum of two fragements for each type in the memory map
> +# maximum of two fragments for each type in the memory map
> # (the memory used, and the free memory that was prereserved
> # but not used).
> #
> diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/Clock.c b/BeagleBoardPkg/Library/BeagleBoardLib/Clock.c
> index 6ca48e0c9f..4ca07ce7bc 100644
> --- a/BeagleBoardPkg/Library/BeagleBoardLib/Clock.c
> +++ b/BeagleBoardPkg/Library/BeagleBoardLib/Clock.c
> @@ -61,7 +61,7 @@ ClockInit (
> | CM_ICLKEN_PER_EN_GPIO5_ENABLE
> | CM_ICLKEN_PER_EN_GPIO6_ENABLE);
>
> - // Turn on functional & inteface clocks to various wakeup modules.
> + // Turn on functional & interface clocks to various wakeup modules.
> MmioOr32(CM_FCLKEN_WKUP, CM_FCLKEN_WKUP_EN_GPIO1_ENABLE
> | CM_FCLKEN_WKUP_EN_WDT2_ENABLE);
> MmioOr32(CM_ICLKEN_WKUP, CM_ICLKEN_WKUP_EN_GPIO1_ENABLE
> diff --git a/BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoff.c b/BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoff.c
> index bcc694816a..0e81536ca6 100644
> --- a/BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoff.c
> +++ b/BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoff.c
> @@ -182,13 +182,13 @@ PeCoffLoaderImageReadFromMemory (
>
>
> /**
> - Reapply fixups on a fixed up PE32/PE32+ image to allow virutal calling at EFI
> + Reapply fixups on a fixed up PE32/PE32+ image to allow virtual calling at EFI
> runtime.
>
> This function reapplies relocation fixups to the PE/COFF image specified by ImageBase
> and ImageSize so the image will execute correctly when the PE/COFF image is mapped
> to the address specified by VirtualImageBase. RelocationData must be identical
> - to the FiuxupData buffer from the PE_COFF_LOADER_IMAGE_CONTEXT structure
> + to the FixupData buffer from the PE_COFF_LOADER_IMAGE_CONTEXT structure
> after this PE/COFF image was relocated with PeCoffLoaderRelocateImage().
>
> Note that if the platform does not maintain coherency between the instruction cache(s) and the data
> diff --git a/BeagleBoardPkg/PrePi/LzmaDecompress.h b/BeagleBoardPkg/PrePi/LzmaDecompress.h
> index a79ff343d2..3b67ee05cc 100644
> --- a/BeagleBoardPkg/PrePi/LzmaDecompress.h
> +++ b/BeagleBoardPkg/PrePi/LzmaDecompress.h
> @@ -25,7 +25,7 @@
> If the required information can not be retrieved from InputSection,
> then RETURN_INVALID_PARAMETER is returned.
> If the GUID of InputSection does match the GUID that this handler supports,
> - then the size required to hold the decoded buffer is returned in OututBufferSize,
> + then the size required to hold the decoded buffer is returned in OutputBufferSize,
> the size of an optional scratch buffer is returned in ScratchSize, and the Attributes field
> from EFI_GUID_DEFINED_SECTION header of InputSection is returned in SectionAttribute.
>
> diff --git a/BeagleBoardPkg/Tools/replace.c b/BeagleBoardPkg/Tools/replace.c
> index 00f4249592..d974ac1bcd 100644
> --- a/BeagleBoardPkg/Tools/replace.c
> +++ b/BeagleBoardPkg/Tools/replace.c
> @@ -102,7 +102,7 @@ main (int argc, char **argv)
> return -5;
> }
>
> - // Search for a match by reading every possition of the file
> + // Search for a match by reading every position of the file
> // into a buffer that is as big as the maximum search key size.
> // Then we can search the keys for a match. If no match
> // copy the old file character to the new file. If it is a match
> @@ -130,8 +130,8 @@ main (int argc, char **argv)
> InFilePos++;
> }
>
> - // We stoped searching when we got to the point that we could no longer match.
> - // So the last few bytes of the file are not copied in the privous loop
> + // We stopped searching when we got to the point that we could no longer match.
> + // So the last few bytes of the file are not copied in the previous loop
> fseek (In, InFilePos, SEEK_SET);
> while ((c = fgetc (In)) != EOF) {
> fputc (c, Out);
>
prev parent reply other threads:[~2019-02-06 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 15:51 [PATCH v2] BeagleBoardPkg: Fix various typos Antoine Coeur
2019-02-06 22:24 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d61585c1-d227-6233-a7a5-e1989eda0a9d@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox