From: "Laszlo Ersek" <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, devel@edk2.groups.io
Cc: sami.mujawar@arm.com, leif.lindholm@linaro.org
Subject: Re: [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build
Date: Tue, 15 Oct 2019 14:51:01 +0200 [thread overview]
Message-ID: <d6290cf2-c20b-7805-5b48-2660981886f2@redhat.com> (raw)
In-Reply-To: <20191015110742.15551-1-ard.biesheuvel@linaro.org>
On 10/15/19 13:07, Ard Biesheuvel wrote:
> DynamicTablesPkg can be built for ARM as well as for AARCH64, but on
> the former, doing so will result in a build failure due to the lack
> of 64-bit division helpers provided by the ArmPkg intrinsics library.
> So add the missing reference, for both ARM and AARCH64 (which may
> start relying on intrinsics due to future changes)
>
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2269
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> DynamicTablesPkg/DynamicTablesPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.dsc
> index ef958077ed48..19beaaf370f8 100644
> --- a/DynamicTablesPkg/DynamicTablesPkg.dsc
> +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc
> @@ -32,6 +32,7 @@ [LibraryClasses]
> UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
>
> [LibraryClasses.ARM, LibraryClasses.AARCH64]
> + NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
>
> [Components.common]
>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
next prev parent reply other threads:[~2019-10-15 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 11:07 [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build Ard Biesheuvel
2019-10-15 12:21 ` Sami Mujawar
2019-10-15 12:51 ` Laszlo Ersek [this message]
2019-10-16 11:51 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-10-21 11:17 ` Alexei Fedorov
2019-10-21 11:37 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6290cf2-c20b-7805-5b48-2660981886f2@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox