From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::442; helo=mail-pf1-x442.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 989592118FF2E for ; Wed, 14 Nov 2018 06:31:42 -0800 (PST) Received: by mail-pf1-x442.google.com with SMTP id g7-v6so7999252pfo.10 for ; Wed, 14 Nov 2018 06:31:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nxzwhSQoVGrzNFlyn1vrFoaw+L/zPhPSx7SnxEDRZwQ=; b=Tl8HOqHGk2jqzPliA3L6tShXacIeu/VhydziUY/1dv5SYw99FoCqbMILK+zDQ4hVgR SxbLSKrEV12LX4D8ig1G/lbeNu6/UXZsjnqcsE6HBrgOuxRxr3aPy5xT8/hesr7taJb5 rnFqDGCnUHylkR0CXe5nHJuFyr87I2a0fkLNQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nxzwhSQoVGrzNFlyn1vrFoaw+L/zPhPSx7SnxEDRZwQ=; b=PgPce5L7lKKhHM1il5SuPyM7A1nJCxNGgamiZkLHMWOCHDaGcLcDSwK8EzAn1Nitxr Ti3Q03dx/GDb/vTgsqXNcmjLmecHwxatJuGCvOcbXZ7FRn80Oq+r1G+RMP+Nj1g50cxY ilY3kuFve+l1PfjPjitSa/ymNfqax3oAhO0ltTV4LinGQ0FhtlRXnkZHTYaxGYWBSc9D 3e8XNTKjpgChqtuD/b87BeauSjpgSNSgwrWk3Q2fnWfjsg1gga3VmKPGyDjCesqWJZIP SAIbd2EQlelQxvTq9CkDXKTHwWFzmehEa5MospLxSiHe2d3d6KZcF0GBKLZMWrd5kxLQ wl6Q== X-Gm-Message-State: AGRZ1gI3ozpRZidvBrRgC7DZnBvjuqI/bIOonQqdG+DxX1/HRzlIMm2o y0qrCF+cZmu7fE7TS6C97EQEDw== X-Google-Smtp-Source: AJdET5eqrdR42vW/Rzzi5BgvuEfR6c0xP2ujpuEeecVGBSX/hXVC4IV+FAvL6R/4dxhbIzJzsFEKTw== X-Received: by 2002:a62:7a92:: with SMTP id v140-v6mr2232968pfc.46.1542205902347; Wed, 14 Nov 2018 06:31:42 -0800 (PST) Received: from [10.39.0.150] ([64.64.108.117]) by smtp.gmail.com with ESMTPSA id s62-v6sm28575889pfb.73.2018.11.14.06.31.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 06:31:41 -0800 (PST) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20181029033249.45363-1-ming.huang@linaro.org> <20181029033249.45363-12-ming.huang@linaro.org> <20181114002955.57b2kmg5jaiglrjw@bivouac.eciton.net> From: Ming Huang Message-ID: Date: Wed, 14 Nov 2018 22:31:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181114002955.57b2kmg5jaiglrjw@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 11/12] Hisilicon/D06: Modify Gic base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 14:31:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/14/2018 8:29 AM, Leif Lindholm wrote: > On Mon, Oct 29, 2018 at 11:32:48AM +0800, Ming Huang wrote: >> The values of PcdGicInterruptInterfaceBase and GICD are wrong, so modify it. >> Fix SBSA test case 21: >> 21 : Check GIC version >> GIC version is 0 >> Failed on PE - 0 for Level= 3 : Result: --FAIL-- 2 > > I'm confused here. How could this ever have worked? > And what is the change? I see values changing, but what do they mean? We boot from TB(Totem B,similar to die) originally, then switch to boot from TA. 0xAA000000 is GICD base of TB,0xAE000000 is GICD base of TA, the 0xAE000000 should be used for TA boot, otherwise some feature may not work like this SBSA test case. The PcdGicInterruptInterfaceBase(0xFE000000) is wrong, it just copy from D05/D03, maybe somewhere will need the right value of Pcd. > > / > Leif > >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> --- >> Platform/Hisilicon/D06/D06.dsc | 2 +- >> Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc >> index 8ee20342b1..6296fcd9ec 100644 >> --- a/Platform/Hisilicon/D06/D06.dsc >> +++ b/Platform/Hisilicon/D06/D06.dsc >> @@ -183,7 +183,7 @@ >> gHisiTokenSpaceGuid.PcdArmPrimaryCoreTemp|0x80010000 >> gArmTokenSpaceGuid.PcdGicDistributorBase|0xAE000000 >> gArmTokenSpaceGuid.PcdGicRedistributorsBase|0xAE100000 >> - gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xFE000000 >> + gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x9B000000 >> >> >> >> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc >> index 43b43142af..d3de69a3ef 100644 >> --- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc >> +++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/MadtHi1620.aslc >> @@ -361,7 +361,7 @@ EFI_ACPI_MULTIPLE_APIC_DESCRIPTION_TABLE Madt = { >> 0x0, 0x0, 25, 0x4000AA000000 + 0x6C0000 /* GicRBase */, 0), >> }, >> >> - EFI_ACPI_6_1_GIC_DISTRIBUTOR_INIT(0, 0xAA000000, 0, 0x4), >> + EFI_ACPI_6_1_GIC_DISTRIBUTOR_INIT(0, 0xAE000000, 0, 0x4), >> { >> EFI_ACPI_6_1_GIC_ITS_INIT(0,0x202100000), //peri a >> // EFI_ACPI_6_1_GIC_ITS_INIT(1,0x400202100000), //peri a >> -- >> 2.18.0 >>