From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 718802129F025 for ; Tue, 12 Jun 2018 08:57:23 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BC2B9818BAF6 for ; Tue, 12 Jun 2018 15:57:22 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-239.rdu2.redhat.com [10.10.120.239]) by smtp.corp.redhat.com (Postfix) with ESMTP id 10929111CB82; Tue, 12 Jun 2018 15:57:19 +0000 (UTC) To: Gerd Hoffmann , edk2-devel@lists.01.org References: <20180612093117.27028-1-kraxel@redhat.com> <20180612093117.27028-4-kraxel@redhat.com> From: Laszlo Ersek Message-ID: Date: Tue, 12 Jun 2018 17:57:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180612093117.27028-4-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 12 Jun 2018 15:57:22 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 12 Jun 2018 15:57:22 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v2 3/4] OvmfPkg: add QemuRamfb to platform console X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 15:57:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/12/18 11:31, Gerd Hoffmann wrote: > Add QemuRamfbDxe device path to the list of platform console devices, > so ConSplitter will pick up the device even though it isn't a PCI GPU. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gerd Hoffmann > --- > .../Library/PlatformBootManagerLib/PlatformData.c | 51 ++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c > index a50cd7bcaf..1250a6d351 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/PlatformData.c > @@ -14,6 +14,7 @@ > **/ > > #include "BdsPlatform.h" > +#include > > // > // Debug Agent UART Device Path structure > @@ -37,6 +38,17 @@ typedef struct { > } USB_KEYBOARD_DEVICE_PATH; > #pragma pack () > > +// > +// QemuRamfb Device Path structure > +// > +#pragma pack (1) > +typedef struct { > + VENDOR_DEVICE_PATH Vendor; > + ACPI_ADR_DEVICE_PATH AcpiAdr; > + EFI_DEVICE_PATH_PROTOCOL End; > +} VENDOR_RAMFB_DEVICE_PATH; > +#pragma pack () > + > ACPI_HID_DEVICE_PATH gPnpPs2KeyboardDeviceNode = gPnpPs2Keyboard; > ACPI_HID_DEVICE_PATH gPnp16550ComPortDeviceNode = gPnp16550ComPort; > UART_DEVICE_PATH gUartDeviceNode = gUart; > @@ -100,6 +112,41 @@ STATIC USB_KEYBOARD_DEVICE_PATH gUsbKeyboardDevicePath = { > gEndEntire > }; > > +STATIC VENDOR_RAMFB_DEVICE_PATH gQemuRamfbDevicePath = { > + { > + { > + HARDWARE_DEVICE_PATH, > + HW_VENDOR_DP, > + { > + (UINT8) (sizeof (VENDOR_DEVICE_PATH)), > + (UINT8) ((sizeof (VENDOR_DEVICE_PATH)) >> 8) > + } > + }, > + QEMU_RAMFB_GUID, > + }, > + { > + { > + ACPI_DEVICE_PATH, > + ACPI_ADR_DP, > + { > + (UINT8) (sizeof (ACPI_ADR_DEVICE_PATH)), > + (UINT8) ((sizeof (ACPI_ADR_DEVICE_PATH)) >> 8) > + } > + }, > + ACPI_DISPLAY_ADR ( > + 1, // DeviceIdScheme > + 0, // HeadId > + 0, // NonVgaOutput > + 1, // BiosCanDetect > + 0, // VendorInfo > + ACPI_ADR_DISPLAY_TYPE_EXTERNAL_DIGITAL, // Type > + 0, // Port > + 0 // Index > + ), > + }, > + gEndEntire > +}; > + > // > // Predefined platform default console device path > // > @@ -113,6 +160,10 @@ PLATFORM_CONSOLE_CONNECT_ENTRY gPlatformConsole[] = { > CONSOLE_IN > }, > { > + (EFI_DEVICE_PATH_PROTOCOL *)&gQemuRamfbDevicePath, > + CONSOLE_OUT > + }, > + { > NULL, > 0 > } > Reviewed-by: Laszlo Ersek