public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Phil Dennis-Jordan <phil@philjordan.eu>
Cc: Phil Dennis-Jordan <lists@philjordan.eu>,
	edk2-devel@lists.01.org,
	Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH v3 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support
Date: Wed, 5 Apr 2017 14:58:19 +0200	[thread overview]
Message-ID: <d66ebeaa-4ea3-b4c6-3f5d-35d1fd54c8f8@redhat.com> (raw)
In-Reply-To: <CAAibmn3sm+QGwp1QaBq+_m4UQy1L1rcG7Z3RRq=L4sY-1WmJyQ@mail.gmail.com>

On 04/05/17 14:37, Phil Dennis-Jordan wrote:
>> In fact, above you already have a (BitsPerPixel == 32) check. At the end
>> of that block, you could set PixelMask to MAX_UINT32 explicitly. And,
>> you could add an "else" branch, simply with
>>
>>   PixelMask = (1u << (BitsPerPixel - 1)) - 1;
>>
>> What do you think?
> I'm pretty sure you mean
> 
>   PixelMask = (0x1u << BitsPerPixel) - 1;

Heh, right :)


      parent reply	other threads:[~2017-04-05 12:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05  9:57 [PATCH v3 0/3] OvmfPkg/QemuVideoDxe: Add VMWare SVGA framebuffer support Phil Dennis-Jordan
2017-04-05  9:57 ` [PATCH v3 1/3] OvmfPkg: VMWare SVGA display device register definitions Phil Dennis-Jordan
2017-04-05 10:05   ` Laszlo Ersek
2017-04-05  9:57 ` [PATCH v3 2/3] OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O Phil Dennis-Jordan
2017-04-05 10:16   ` Laszlo Ersek
2017-04-05  9:58 ` [PATCH v3 3/3] OvmfPkg/QemuVideoDxe: VMWare SVGA device support Phil Dennis-Jordan
2017-04-05 11:41   ` Laszlo Ersek
2017-04-05 12:46     ` Phil Dennis-Jordan
     [not found]     ` <CAAibmn3sm+QGwp1QaBq+_m4UQy1L1rcG7Z3RRq=L4sY-1WmJyQ@mail.gmail.com>
2017-04-05 12:58       ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d66ebeaa-4ea3-b4c6-3f5d-35d1fd54c8f8@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox