From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 11EB7D80C7F for ; Thu, 25 Apr 2024 08:10:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NYG03kIcxFHGaBHtDlaaepuQlRlKGp1EzBokxjHtiL4=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1714032604; v=1; b=axJL+XBAAXNEgB/XAFOzNiEdXjV30xllUWZXTrsdiVR77QQwj2OfAY7no3J7n70o0RBZELD7 Sw7PO4uwqTxsPzqD9dl21mWIguiqriqQsKKQSpYegcNJ7dDU/TRwJ6Yn0Tl8vV5KYMQcSBicTkS NkznAddB1J5OiXScNwx8/r6Do1i1fDtcwxQrmS5EBShX+3uiFP1u6f8sZEQs9wdxqvk9Enob7WM ZT4nldeUwB2m7tm8cUX5vYzrAhzSehFwdJEt6Ymhki2ugqXhL5jooem8J4U4ACp8du1BuaossZD q+zZxyNFK6q56OZpRCDWvUDmQak4AefEpw/8pRHWLMVjw== X-Received: by 127.0.0.2 with SMTP id t9EmYY7687511xNTXd5kHGh5; Thu, 25 Apr 2024 01:10:04 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.11903.1714032602634168347 for ; Thu, 25 Apr 2024 01:10:03 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8CxyenYDypmcrUCAA--.534S3; Thu, 25 Apr 2024 16:10:00 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxnlfWDypmbuMEAA--.12690S3; Thu, 25 Apr 2024 16:09:58 +0800 (CST) Message-ID: Date: Thu, 25 Apr 2024 16:09:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 2/7] OvmfPkg: Add the way of HOBs in QemuFwCfgLibMmio To: devel@edk2.groups.io, kraxel@redhat.com Cc: Ard Biesheuvel , Jiewen Yao , Leif Lindholm , Sami Mujawar , Sunil V L , Andrei Warkentin References: <20240425041728.1385891-1-lichao@loongson.cn> <20240425041816.1386268-1-lichao@loongson.cn> <5boqyu5erbhftofbobyknwg4i4ngbm4igybx554whbtqnn4hh6@3zl5bgcskxkj> From: "Chao Li" In-Reply-To: <5boqyu5erbhftofbobyknwg4i4ngbm4igybx554whbtqnn4hh6@3zl5bgcskxkj> X-CM-TRANSID: AQAAf8BxnlfWDypmbuMEAA--.12690S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQASCGYpxJMEXwADsb X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 25 Apr 2024 01:10:03 -0700 Resent-From: lichao@loongson.cn Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Sv8eUcxps5jcGjSlHFWxdx4jx7686176AA= Content-Type: multipart/alternative; boundary="------------CMOSjutxMTBaJDI9JoKrxG3L" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=axJL+XBA; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --------------CMOSjutxMTBaJDI9JoKrxG3L Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Gerd, Thanks, Chao On 2024/4/25 15:40, Gerd Hoffmann wrote: > Hi, > >> +EFI_GUID mFwCfgSelectorAddressGuid =3D FW_CONFIG_SELECTOR_ADDRESS_HOB_= GUID; >> +EFI_GUID mFwCfgDataAddressGuid =3D FW_CONFIG_DATA_ADDRESS_HOB_GUID= ; >> +EFI_GUID mFwCfgDmaAddressGuid =3D FW_CONFIG_DMA_ADDRESS_HOB_GUID; > Oh. I assumed that would be obvious (because it's common practice for > HOBs), but I was thinking about a single HOB containing a struct with > all three values instead of a separate HOB for each value. If uses a single HOB, it must define a structure in this library, and it=20 may be more complicated to build and parse the HOB. > > take care, > Gerd > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118279): https://edk2.groups.io/g/devel/message/118279 Mute This Topic: https://groups.io/mt/105724969/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------CMOSjutxMTBaJDI9JoKrxG3L Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Gerd,


=
Thanks,
Chao
On 2024/4/25 15:40, Gerd Hoffmann wrote:
  Hi,


+EFI_GUID  mFwCfgSelectorAdd=
ressGuid =3D FW_CONFIG_SELECTOR_ADDRESS_HOB_GUID;
+EFI_GUID  mFwCfgDataAddressGuid     =3D FW_CONFIG_DATA_ADDRESS_HOB_GUID;
+EFI_GUID  mFwCfgDmaAddressGuid      =3D FW_CONFIG_DMA_ADDRESS_HOB_GUID;

Oh.  I assumed that would be obvious (because it's common practice for
HOBs), but I was thinking about a single HOB containing a struct with
all three values instead of a separate HOB for each value.
If uses a single HOB, it must define a structure in this library, and it may be more complicated to build and parse the HOB.

take care,
  Gerd
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118279) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------CMOSjutxMTBaJDI9JoKrxG3L--