Re: [PATCH 0/2] ArmPlatformPkg/NorFlashDxe: implement standalone MM version

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 12/18/20 11:05 AM, Masahisa Kojima wrote:
> To support secure variable storage on the aarch64 SBSA-QEMU platform,
> this patch series implement the NOR Flash driver for standalone MM.
> 
> What have been tested:
> For DXE driver, uefi variable storage works fine on the ArmVirtQemu platform.
> For Standalone MM driver, uefi secure variable storage works fine
> on the SBSA-QEMU platform.
> Note that SBSA-QEMU secure variable storage handling is not yet upstreamed,
> because it needs this standalone MM NOR Flash driver.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> 
> Masahisa Kojima (2):
>   ArmPlatformPkg/NorFlashDxe: factor out DXE specific pieces
>   ArmPlatformPkg/NorFlashDxe: implement standalone MM version
> 

Thanks Masahisa. This looks fine to me.

I have taken the liberty of adding the hunk below so the driver can be
built for testing purposes from ArmPlatformPkg.dsc. I also needed to
replace some instances of EFI_D_ERROR with DEBUG_ERROR to placate
PatchCheck.

For the series,

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Merged as #1285




index b92ef712be87..88fe1247c03b 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dsc
+++ b/ArmPlatformPkg/ArmPlatformPkg.dsc
@@ -90,6 +90,12 @@ [LibraryClasses.common.SEC]

MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf

PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf

+[LibraryClasses.AARCH64.MM_STANDALONE]
+  HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
+
MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf
+
MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf
+
StandaloneMmDriverEntryPoint|MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf
+
 [Components.common]
   ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
   ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
@@ -122,3 +128,6 @@ [Components.common]
   ArmPlatformPkg/PrePi/PeiUniCore.inf

   ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
+
+[Components.AARCH64]
+  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf