From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (EUR02-HE1-obe.outbound.protection.outlook.com [40.107.1.63]) by mx.groups.io with SMTP id smtpd.web12.65004.1643813593036448296 for ; Wed, 02 Feb 2022 06:53:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=giaKn6hm; spf=pass (domain: arm.com, ip: 40.107.1.63, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S/Faom81FMPibbPa/X3csWHBch41K+ARXgyAsDR3R/4=; b=giaKn6hmeinjOMRdLKohY4BxYXs1SlvmlNU8qp866UndEUA6tWec7h78wsFjuokzzXeOs31bKKIXM7Jxkm2wuV/e93vs8+y4KZCG1uCJz1wA8CWxf/tRYkylVhox6wGHybmGSWybTGJoXiQS3S97gH0HhQiAA1+EUz4E+RV4uBw= Received: from AM5PR0201CA0014.eurprd02.prod.outlook.com (2603:10a6:203:3d::24) by PAXPR08MB7393.eurprd08.prod.outlook.com (2603:10a6:102:2bd::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Wed, 2 Feb 2022 14:53:09 +0000 Received: from VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:3d:cafe::99) by AM5PR0201CA0014.outlook.office365.com (2603:10a6:203:3d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend Transport; Wed, 2 Feb 2022 14:53:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT003.mail.protection.outlook.com (10.152.18.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12 via Frontend Transport; Wed, 2 Feb 2022 14:53:08 +0000 Received: ("Tessian outbound 1f399c739551:v113"); Wed, 02 Feb 2022 14:53:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e34e5d1c92fc17c6 X-CR-MTA-TID: 64aa7808 Received: from f53f1a7f0709.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2335D89E-2501-4E11-A1AB-29E55DDFDC78.1; Wed, 02 Feb 2022 14:53:01 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f53f1a7f0709.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 02 Feb 2022 14:53:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LW24N3HVjgpJFxkbCk4zVU/KnQUuMkRSGtWTpbEzAssJYbT2pAnsQIDVJTB5DcnOgHg2N2uWB4MOTnmWw9JmSmQIOMLTw1QP2mT4pOGp1eQrj3yIwosX/zHGsunX/3HGxukarl1ypGwzXH9xMtnd7l2G7sU1yb9LoHZotM7aJZFaNr/6OGdIdF0NICNR0ZapwKsmMhI+uT2fd5gXatwfBa6ysYs3VoKMn1suclJE2RJ9SShGDX/XwcDcK8BRxY1d4cR1fQRehVgK+ypv+WIxvKDT6XiU2YcLtIR5sH+CQPvwNv1UYyKq0d0VAWvYkvdOE6qtcQAWYNRDX8y5bMsPhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S/Faom81FMPibbPa/X3csWHBch41K+ARXgyAsDR3R/4=; b=N2PTEuBi/UklugCDhF7IhF7NWq82aHOxUOBL7CBpEotSw/ei84/bSKrZJfG0MTelzBaMVJ/d5qsi+thHXY4D0eQyvfdUSe9phaNqIRm+SgFoPfFmN6FLFQlSEkl6fVVz6KeDPljQDOGeuicO0mdgwdLD4lltw0sGk8LPBjUkZDtiWqIn+cYJIQWH1EuT6NZX12fVCHEGUPdePF36baG6odjWR0El9k6fTMYQC8wYbX90nVyt3nsvO0RRlWNafencIBiM/s1Yj5fPGlby+cpSnoy9eE/uwIjdXiLScFrOCrW6x0ikwAKP/zHFN20UkP7qaNjnsAxMsVWn+XARa1bGBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S/Faom81FMPibbPa/X3csWHBch41K+ARXgyAsDR3R/4=; b=giaKn6hmeinjOMRdLKohY4BxYXs1SlvmlNU8qp866UndEUA6tWec7h78wsFjuokzzXeOs31bKKIXM7Jxkm2wuV/e93vs8+y4KZCG1uCJz1wA8CWxf/tRYkylVhox6wGHybmGSWybTGJoXiQS3S97gH0HhQiAA1+EUz4E+RV4uBw= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAXPR08MB6623.eurprd08.prod.outlook.com (2603:10a6:102:155::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Wed, 2 Feb 2022 14:53:00 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95%8]) with mapi id 15.20.4909.019; Wed, 2 Feb 2022 14:53:00 +0000 Subject: Re: [PATCH v3 2/3] DynamicTablesPkg: Remove redundant cast in AmlCodeGenReturn To: Rebecca Cran , devel@edk2.groups.io, PierreGondois , Alexei Fedorov , Leif Lindholm , nd References: <20220113164052.20841-1-quic_rcran@quicinc.com> <20220113164052.20841-3-quic_rcran@quicinc.com> From: "Sami Mujawar" Message-ID: Date: Wed, 2 Feb 2022 14:53:00 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20220113164052.20841-3-quic_rcran@quicinc.com> X-ClientProxiedBy: LO2P265CA0318.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 30077a63-a463-4de8-2309-08d9e65bba26 X-MS-TrafficTypeDiagnostic: PAXPR08MB6623:EE_|VE1EUR03FT003:EE_|PAXPR08MB7393:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:5797;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: S+foRqIApf/PJdJDEmwyw1m3S8P3LS7oeuzSlgmUiWQ5k+XpGdViV7kQWstngqjnAanadfKzd+XCdAnCFl6L+okCYhbPRVHKi+WBLEXgI915afiOzCeR3vA+p36GvLRPKMwU5vZeM/nje2BHScXQJi0/uN2U/DRAb/VJ5yN4oDU1r1+Lo15t7GdtXiBJxGmX78tw+HTOQBedY6LOqd6K8ve657c67+SJthd/fv6h3X/Za++QY+hsAh/5e4+S10TAWvMd9K50FSoH6IzbKSLiYiYjktz4RsxgMdjGvAkyh7i1yRIvFP0Dlg99tbWdANcl8BprMJxMxESVCNVLY0zcoaxIyulfJhNq+G8NxkOK9RmRdKWMO1GaG7pq3IyH4VZDmbUn02lyLnPm/xiYNzZyBdYeFBGeCnw0J0ZfbA4x3sI5CfgjakaE3kNja/0vzvFgrU2BP2KYsxbtG/5zhHziScZjNbEVTu+CCBouczGvtrRUcfDt3I+S5aEccgNEpvl7gM+1yA8TfsDtIwKT/1T+cKC81Hjb2tNXsVye3jproZJe0YW7z3o+z+ZxNWpxUGnNlEFb/yNfs/FEr7DyvUO8cTTQuQd3AayQJhr1MCLayi+YJNumKnBpf7kKSbotanHLRwcp5Mz1FllfKxaEF7lIHeEM6StWjfv6Hgi+yMdAPPg1t/G40QRDxC7c/V4GbTOmH/eN/vcXpmMOqOtlYULXIxt/7tmJQ+ooF6qRl0bpWcmkp5KfouRpzR3zgJh5PGnZYI5o64p+kX4r+tyw+Q/9UA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(8676002)(508600001)(8936002)(86362001)(66946007)(5660300002)(38100700002)(38350700002)(44832011)(66476007)(66556008)(31696002)(6506007)(6636002)(26005)(186003)(110136005)(6512007)(2616005)(52116002)(316002)(36756003)(6486002)(2906002)(31686004)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6623 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 183b3a35-bdb9-49cf-3c48-08d9e65bb4f8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AcmcvrbR1oOV7r+3Iapu9Rm4fxDsEgFo2DAX6XFIeTSuRRu/zjiZ4HsSsQdnbFavi4kpjFLs+qD2etUbItH0HOW2SsgEBqQhrz5qWEvXbIwTpvGSl2hW2uPErKpKLgCqwY/bjgLVuqccfqEgphwl0kcawIpMvfPNu4iKbDmYupqI+Scf3DXhGTvjk8GfzEBRfvgoNsIcKO1RmVuH4Hr1gbn+l8chovyp9W7J2KrnKQXmXrMqdLm7Y06kAzs3hvb9GQupgv2h6sTBErGA24r2uYUxOWzOwI3q5cEnyaNQe4nP7vzQXSYWhkdHLUPd9h0zBXV+HKtypCaqyKGdzqo4Lf4Lcdoh76kqZ4r0KpSp075rglLwK64KPWixkf53b8eHCp9Yrx/ejOkgLLoWKmEOHQ4pmXFVLlwTD6B683B6ZRIDZ8hDRwH1YcNLu7sv4DWuZMj0NKlZXer2UoBb4W7PNMtb8qS4D+2O0EK3peD4u40wdMPNFOXnO2BbJVdR+dhe40vJcSv7j7RjL2oZEFCi8WJdbY5aEmltgTog+yLdWdInezLB5/ClbaSG8UhkosEj3NDYZ+2AJ9ZwdInsWa/h/N7iypTaYLTGFcrFw0ogPEVymUxdTh5K6iq+yOAdQHhi8a19vG7+KJWFTU8KhxUSXYUgFG69Pkkir73qH1MxoO/HBjc5iRdIad8xas/eJq9Sc185FAleyxMeOSH/9zJY1g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(70586007)(70206006)(36860700001)(31686004)(40460700003)(316002)(6512007)(86362001)(8936002)(8676002)(36756003)(5660300002)(81166007)(31696002)(2906002)(356005)(44832011)(47076005)(508600001)(336012)(82310400004)(6486002)(6636002)(26005)(6506007)(53546011)(110136005)(186003)(83380400001)(2616005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 14:53:08.8046 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30077a63-a463-4de8-2309-08d9e65bba26 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7393 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Rebecca, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 13/01/2022 04:40 PM, Rebecca Cran wrote: > In AmlCodeGenReturn, the cast to AML_NODE_HEADER* in the call to > AmlSetFixedArgument is redundant because ReturnNode is already a > AML_NODE_HEADER* . > > Signed-off-by: Rebecca Cran > Reviewed-by: Pierre Gondois > --- > DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c = b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > index d245848ce3fa..838a892c6b58 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c > @@ -1564,7 +1564,7 @@ AmlCodeGenReturn ( > Status =3D AmlSetFixedArgument ( > ObjectNode, > EAmlParseIndexTerm0, > - (AML_NODE_HEADER *)ReturnNode > + ReturnNode > ); > if (EFI_ERROR (Status)) { > ASSERT (0); IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.