From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.375.1652808199474535121 for ; Tue, 17 May 2022 10:23:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=hZcHF06F; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 3BB8E20DF5AA; Tue, 17 May 2022 10:23:18 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3BB8E20DF5AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1652808198; bh=Ixn3+/F06wKjSvgnqmWArZr2+Q/FBQEXr+jn34CH2/Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hZcHF06FI/Y8Rnq1FHbDuc3D0kvrdMqkdI8GhtlfF7mUfst72CveK5HqgHdn8z1yp ErWVm1U39q1CrDQaPBzzis48pQeV60lhtU76rz/PAs1eSgCv3D4pu74yiw1D51sgDs Zo9+r276eP6s38xfSEb8oxSoNe6va0m16eYleWNY= Message-ID: Date: Tue, 17 May 2022 13:23:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v1 2/8] StandaloneMmPkg: Fix new typos reported To: Sami Mujawar , "devel@edk2.groups.io" Cc: Ard Biesheuvel , Jiewen Yao , Supreeth Venkatesh , nd References: <20220517160043.1210-1-mikuback@linux.microsoft.com> <20220517160043.1210-3-mikuback@linux.microsoft.com> <180FD406-1951-4BE8-A8A8-02DA1584F3AF@arm.com> From: "Michael Kubacki" In-Reply-To: <180FD406-1951-4BE8-A8A8-02DA1584F3AF@arm.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Sure I can add that to a v2. I'm going to leave v1 up for a bit longer=20 to collect more feedback before sending that. Regards, Michael On 5/17/2022 12:19 PM, Sami Mujawar wrote: > Hi Michael, >=20 > Thank you for fixing these issues. >=20 > I have a minor suggestion marked inline as [SAMI]. Otherwise, this patc= h looks good to me. >=20 > Reviewed-by: Sami Mujawar >=20 > Regards, >=20 > Sami Mujawar >=20 > =EF=BB=BFOn 17/05/2022, 17:01, "mikuback@linux.microsoft.com" wrote: >=20 > From: Michael Kubacki >=20 > The SpellCheck plugin began reporting new typos that were previous= ly > missed. This change fixes those typos. >=20 > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Signed-off-by: Michael Kubacki > --- > StandaloneMmPkg/Core/Dependency.c | 2 +- > StandaloneMmPkg/Core/Dispatcher.c | 18 +++++++++--------- > StandaloneMmPkg/Include/Guid/MmCoreData.h | 2 +- > StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 9 +++++++++ > 4 files changed, 20 insertions(+), 11 deletions(-) >=20 > diff --git a/StandaloneMmPkg/Core/Dependency.c b/StandaloneMmPkg/C= ore/Dependency.c > index 440fe3e45238..0e9c0e96a276 100644 > --- a/StandaloneMmPkg/Core/Dependency.c > +++ b/StandaloneMmPkg/Core/Dependency.c > @@ -38,7 +38,7 @@ BOOLEAN *mDepexEvaluationStackPointer =3D NULL; > /** > Grow size of the Depex stack >=20 > - @retval EFI_SUCCESS Stack successfully growed. > + @retval EFI_SUCCESS Stack successfully grew. > @retval EFI_OUT_OF_RESOURCES There is not enough system memory= to grow the stack. >=20 > **/ > diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/C= ore/Dispatcher.c > index b1ccba15b060..01da395be3c4 100644 > --- a/StandaloneMmPkg/Core/Dispatcher.c > +++ b/StandaloneMmPkg/Core/Dispatcher.c > @@ -17,7 +17,7 @@ > and After dependencies. This is done recursively as t= he call to add > to the mScheduledQueue checks for Before Depexes and = recursively > adds all Before Depexes. It then adds the item that w= as passed in > - and then processess the After dependencies by recursi= vely calling > + and then processes the After dependencies by recursiv= ely calling > the routine. >=20 > Dispatcher Rules: > @@ -93,29 +93,29 @@ LIST_ENTRY mScheduledQueue =3D INITIALIZE_LIS= T_HEAD_VARIABLE (mScheduledQueue); > LIST_ENTRY mFwVolList =3D INITIALIZE_LIST_HEAD_VARIABLE (mFwVolL= ist); >=20 > // > -// Flag for the MM Dispacher. TRUE if dispatcher is executing. > +// Flag for the MM Dispatcher. TRUE if dispatcher is executing. > // > BOOLEAN gDispatcherRunning =3D FALSE; >=20 > // > -// Flag for the MM Dispacher. TRUE if there is one or more MM dr= ivers ready to be dispatched > +// Flag for the MM Dispatcher. TRUE if there is one or more MM d= rivers ready to be dispatched > // > BOOLEAN gRequestDispatch =3D FALSE; >=20 > // > // The global variable is defined for Loading modules at fixed ad= dress feature to track the MM code > -// memory range usage. It is a bit mapped array in which every bi= t indicates the correspoding > +// memory range usage. It is a bit mapped array in which every bi= t indicates the corresponding > // memory page available or not. > // > GLOBAL_REMOVE_IF_UNREFERENCED UINT64 *mMmCodeMemoryRangeUsage= BitMap =3D NULL; >=20 > /** > To check memory usage bit map array to figure out if the memory= range in which the image will be loaded > - is available or not. If memory range is avaliable, the function= will mark the corresponding bits to 1 > + is available or not. If memory range is available, the function= will mark the corresponding bits to 1 > which indicates the memory range is used. The function is only = invoked when load modules at fixed address > feature is enabled. >=20 > - @param ImageBase The base addres the image will= be loaded at. > + @param ImageBase The base address the image wil= l be loaded at. > @param ImageSize The size of the image >=20 > @retval EFI_SUCCESS The memory range the image wil= l be loaded in is available > @@ -194,7 +194,7 @@ CheckAndMarkFixLoadingMemoryUsageBitMap ( > @param ImageContext Pointer to the image context = structure that describes the PE/COFF > image that needs to be examin= ed by this function. > @retval EFI_SUCCESS An fixed loading address is a= ssigned to this image by build tools . > - @retval EFI_NOT_FOUND The image has no assigned fix= ed loadding address. > + @retval EFI_NOT_FOUND The image has no assigned fix= ed loading address. >=20 > **/ > EFI_STATUS > @@ -513,7 +513,7 @@ MmPreProcessDepex ( >=20 > @param DriverEntry Driver to work on. >=20 > - @retval EFI_SUCCESS Depex read and preprossesed > + @retval EFI_SUCCESS Depex read and pre-processed > @retval EFI_PROTOCOL_ERROR The section extraction protocol r= eturned an error > and Depex reading needs to be re= tried. > @retval Error DEPEX not found. > @@ -851,7 +851,7 @@ FvIsBeingProcessed ( > The Discovered list is never freed and contains booleans that r= epresent the > other possible MM driver states. >=20 > - @param [in] FwVolHeader Pointer to the formware volume he= ader. > + @param [in] FwVolHeader Pointer to the firmware volume he= ader. > @param [in] Pe32Data Pointer to the PE data. > @param [in] Pe32DataSize Size of the PE data. > @param [in] Depex Pointer to the Depex info. > diff --git a/StandaloneMmPkg/Include/Guid/MmCoreData.h b/Standalon= eMmPkg/Include/Guid/MmCoreData.h > index b8be92c6abfd..0f58f41d8060 100644 > --- a/StandaloneMmPkg/Include/Guid/MmCoreData.h > +++ b/StandaloneMmPkg/Include/Guid/MmCoreData.h > @@ -70,7 +70,7 @@ typedef struct { >=20 > /// > /// The MM Foundation Entry Point. The MM Core fills in this f= ield when the > - /// MM Core is initialized. The MM IPL is responsbile for regi= stering this entry > + /// MM Core is initialized. The MM IPL is responsible for regi= stering this entry > /// point with the MM Configuration Protocol. The MM Configura= tion Protocol may > /// not be available at the time the MM IPL and MM Core are sta= rted, so the MM IPL > /// sets up a protocol notification on the MM Configuration Pro= tocol and registers > diff --git a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml b/StandaloneM= mPkg/StandaloneMmPkg.ci.yaml > index 4777532a7ede..535e269e7891 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.ci.yaml > +++ b/StandaloneMmPkg/StandaloneMmPkg.ci.yaml > @@ -81,12 +81,21 @@ > "IgnoreFiles": [], # use gitignore syntax to ig= nore errors > # in matching files > "ExtendWords": [ > + "bootinformation", > "Bsymbolic", > + "bugbug", > + "combineable", > + "depexes", > "FwVol", > + "hoblist", > + "imagehandle", > + "interfacer", > [SAMI] I think there is a typo in https://github.com/tianocore/edk2/blo= b/master/StandaloneMmPkg/Core/Handle.c#L350 and https://github.com/tianoc= ore/edk2/blob/master/StandaloneMmPkg/Core/StandaloneMmCore.h#L429, where = "a protocol:interfacer" needs to be changed to "protocol interfaces". > [/SAMI] > "mpidr", > "mstrict", > "schedulable", > "StandaloneMMCore", > + "systemtable", > + "uncacheable" > ], # words to extend to the dictionary for this= package > "IgnoreStandardPaths": [], # Standard Plugin defined pa= ths that > # should be ignore > -- > 2.28.0.windows.1 >=20 >=20