From: "Ankur Arora" <ankur.a.arora@oracle.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: devel@edk2.groups.io, imammedo@redhat.com, boris.ostrovsky@oracle.com
Subject: Re: [edk2-devel] [PATCH v5 0/9] support CPU hot-unplug
Date: Tue, 26 Jan 2021 12:09:29 -0800 [thread overview]
Message-ID: <d6ccfc68-8b69-beb1-2377-294a23307a1d@oracle.com> (raw)
In-Reply-To: <f6a3696a-d1a8-fcf5-1f35-d29b9ba7836a@redhat.com>
On 2021-01-26 10:03 a.m., Laszlo Ersek wrote:
> Hi Ankur,
>
> On 01/26/21 07:44, Ankur Arora wrote:
>> Hi,
>>
>> This series adds support for CPU hot-unplug with OVMF.
>>
>> Please see this in conjunction with the QEMU secureboot hot-unplug v2
>> series posted here (now upstreamed):
>> https://lore.kernel.org/qemu-devel/20201207140739.3829993-1-imammedo@redhat.com/
>>
>> Patches 1 and 3,
>> ("OvmfPkg/CpuHotplugSmm: refactor hotplug logic")
>> ("OvmfPkg/CpuHotplugSmm: add Qemu Cpu Status helper")
>> are either refactors or add support functions.
>>
>> OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()
>> OvmfPkg/CpuHotplugSmm: add CpuEject()
>> OvmfPkg/CpuHotplugSmm: add worker to do CPU ejection
>>
>> Patch 2 and 9,
>> ("OvmfPkg/CpuHotplugSmm: collect hot-unplug events")
>> ("OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug")
>> handle the QEMU protocol logic for collection of CPU hot-unplug events
>> or the protocol negotiation.
>>
>> Patch 4,
>> ("OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()")
>> adds the MMI logic for CPU hot-unplug handling and informing
>> the PiSmmCpuDxeSmm of CPU removal.
>>
>> Patches 5 and 6,
>> ("OvmfPkg/CpuHotplugSmm: define CPU_HOT_EJECT_DATA")
>> ("OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state")
>> sets up state for doing the CPU ejection as part of hot-unplug.
>>
>> Patches 7, and 8,
>> ("OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()")
>> ("OvmfPkg/CpuHotplugSmm: add worker to do CPU ejection")
>> add the CPU ejection logic.
>>
>> Testing (with QEMU 5.2.50):
>> - Stable with randomized CPU plug/unplug (guest maxcpus=1,8,128)
>> - Synthetic tests with simultaneous multi CPU hot-unplug
>> - Negotiation with/without CPU hotplug enabled
>>
>> Also at:
>> github.com/terminus/edk2/ hot-unplug-v5
>>
>> Changelog:
>> v5:
>> - fixes ECC errors (all but one in "OvmfPkg/CpuHotplugSmm: add
>> add Qemu Cpu Status helper").
>>
>> v4:
>> - Gets rid of unnecessary UefiCpuPkg changes
>> URL: https://patchew.org/EDK2/20210118063457.358581-1-ankur.a.arora@oracle.com/
>>
>> v3:
>> - Use a saner PCD based interface to share state between PiSmmCpuDxeSmm
>> and OvmfPkg/CpuHotplugSmm
>> - Cleaner split of the hot-unplug code
>> URL: https://patchew.org/EDK2/20210115074533.277448-1-ankur.a.arora@oracle.com/
>>
>> v2:
>> - Do the ejection via SmmCpuFeaturesRendezvousExit()
>> URL: https://patchew.org/EDK2/20210107195515.106158-1-ankur.a.arora@oracle.com/
>>
>> RFC:
>> URL: https://patchew.org/EDK2/20201208053432.2690694-1-ankur.a.arora@oracle.com/
>>
>>
>> Please review.
>>
>> Thanks
>> Ankur
>>
>> Ankur Arora (9):
>> OvmfPkg/CpuHotplugSmm: refactor hotplug logic
>> OvmfPkg/CpuHotplugSmm: collect hot-unplug events
>> OvmfPkg/CpuHotplugSmm: add Qemu Cpu Status helper
>> OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()
>> OvmfPkg/CpuHotplugSmm: define CPU_HOT_EJECT_DATA
>> OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state
>> OvmfPkg/CpuHotplugSmm: add CpuEject()
>> OvmfPkg/CpuHotplugSmm: add worker to do CPU ejection
>> OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug
>>
>> OvmfPkg/OvmfPkg.dec | 10 +
>> OvmfPkg/CpuHotplugSmm/CpuHotplugSmm.inf | 1 +
>> .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 3 +
>> OvmfPkg/CpuHotplugSmm/QemuCpuhp.h | 6 +
>> OvmfPkg/Include/IndustryStandard/QemuCpuHotplug.h | 2 +
>> OvmfPkg/Include/Library/CpuHotEjectData.h | 32 ++
>> OvmfPkg/CpuHotplugSmm/CpuHotplug.c | 450 ++++++++++++++++-----
>> OvmfPkg/CpuHotplugSmm/QemuCpuhp.c | 57 ++-
>> .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 68 ++++
>> OvmfPkg/SmmControl2Dxe/SmiFeatures.c | 25 +-
>> 10 files changed, 552 insertions(+), 102 deletions(-)
>> create mode 100644 OvmfPkg/Include/Library/CpuHotEjectData.h
>>
>
> This series is still mal-formatted; for some reason it has one too many
> CRs per line.
>
> Did you try to set up the "base64" or the "8bit"
> content-transfer-encoding? The emails reflected through the list are
> still "quoted-printable".
Confirming that this was the problem. And, thanks for debugging this.
Ankur
>
> Anyway, I managed to apply the patches with some trickery on a local branch.
>
> Thanks
> Laszlo
>
next prev parent reply other threads:[~2021-01-26 20:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 6:44 [PATCH v5 0/9] support CPU hot-unplug Ankur Arora
2021-01-26 6:44 ` [PATCH v5 1/9] OvmfPkg/CpuHotplugSmm: refactor hotplug logic Ankur Arora
2021-01-26 19:01 ` Laszlo Ersek
2021-01-26 19:04 ` Laszlo Ersek
2021-01-26 19:09 ` Laszlo Ersek
2021-01-26 19:15 ` Ankur Arora
2021-01-26 21:07 ` Laszlo Ersek
2021-01-26 21:17 ` Ankur Arora
2021-01-26 21:32 ` Laszlo Ersek
2021-01-26 22:53 ` Ankur Arora
2021-01-26 6:44 ` [PATCH v5 2/9] OvmfPkg/CpuHotplugSmm: collect hot-unplug events Ankur Arora
2021-01-26 6:44 ` [PATCH v5 3/9] OvmfPkg/CpuHotplugSmm: add Qemu Cpu Status helper Ankur Arora
2021-01-26 6:44 ` [PATCH v5 4/9] OvmfPkg/CpuHotplugSmm: introduce UnplugCpus() Ankur Arora
2021-01-26 6:44 ` [PATCH v5 5/9] OvmfPkg/CpuHotplugSmm: define CPU_HOT_EJECT_DATA Ankur Arora
2021-01-26 6:44 ` [PATCH v5 6/9] OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state Ankur Arora
2021-01-26 6:44 ` [PATCH v5 7/9] OvmfPkg/CpuHotplugSmm: add CpuEject() Ankur Arora
2021-01-26 6:44 ` [PATCH v5 8/9] OvmfPkg/CpuHotplugSmm: add worker to do CPU ejection Ankur Arora
2021-01-26 6:44 ` [PATCH v5 9/9] OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug Ankur Arora
2021-01-26 18:03 ` [edk2-devel] [PATCH v5 0/9] support " Laszlo Ersek
2021-01-26 20:09 ` Ankur Arora [this message]
2021-01-26 18:18 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6ccfc68-8b69-beb1-2377-294a23307a1d@oracle.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox