From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by mx.groups.io with SMTP id smtpd.web09.18520.1611691782597674444 for ; Tue, 26 Jan 2021 12:09:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=WIPVJvxU; spf=pass (domain: oracle.com, ip: 156.151.31.86, mailfrom: ankur.a.arora@oracle.com) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10QJxrCt080070; Tue, 26 Jan 2021 20:09:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=PqefceYasfUNMoQdmPt1zcf72IbJUeLD0WCLaDvnmH0=; b=WIPVJvxUDjLr0xu2RV88iky+D5Vcd3o5J+7B5vOyhhlxXtSvkqdPr+R9huespbcvwAMi gaygUvduS8YToRDiFeV77bjywYY7wa+7xZBfPMB6S/7x0FNhGhVBHsjKCTx764S3UgAv XHPzyTCJMV0FLUlIdgopr4FvdWZFqJaJZMOcB21fJUaOUuKITkgE/3cAE2ZGVIyArp78 1e6Mi9qxnLUrNja8RBvQcQReatcf16IZmDbTfPm+hhntEcs0w9IofCR4DJyGYr1zvkKT W//Vv1v7o95sNUg0hmrfI30bdMCYGE9aKZ5GxgZfGlAvwJ5vPnLnn1udu5PM8Tp+o3q0 KQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 368b7quwu5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jan 2021 20:09:41 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10QK9dLJ008174; Tue, 26 Jan 2021 20:09:41 GMT Received: from nam02-bl2-obe.outbound.protection.outlook.com (mail-bl2nam02lp2058.outbound.protection.outlook.com [104.47.38.58]) by userp3020.oracle.com with ESMTP id 368wjrmahh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jan 2021 20:09:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ifkZlsJt3zUFdxMFECnxIzljKHf5fm19SEKncJmtAqIxdGZ/9NDfF8Yo57vOoTQCX8iQrV7DBy5f7eIujnVcc7vSDorWXPXifCWbT/VSC073jeqLAinvLi3SET2CneZh7XcCT96k7wkKpu4WCxv5sax2L0DHEQLecH2SgHOZdXDIfBfzVxvu+BLDeAN1rJtTxBVhfoImaQ0UHWRIEHEPrxsshMTlDq1Qv2dRd/YtrLtD5rgfvif7MRX3+OYUtPuS8D5uqQ5w7GsDi4khZdBLAj5wLsVEHr8TMSEKeoO1DQPYlyDOpl99FsKprIxiXknB082eWR4PEfqUVcLQmgSIZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PqefceYasfUNMoQdmPt1zcf72IbJUeLD0WCLaDvnmH0=; b=BtiX/t6OG/maGmimWrHSgP/DMeolfWJIXV54KRz/gfJtZAfL1FNxbiK+DuLxPdJcrb5Jx2qxCCUBqsMxNq4BSeUl9SbEW/yt1RAx7uclTx0l2GKUsNAanI6kYdRb5+tQ06mOeKnCAtxT95JPF1tAIGjVJzdEmbEh/TrCu6PopEicMPReGBmOO5tjoGK/i4iGXm2aLdJP1QKRWRz2LRM6ABelvG91rNz8QhvEY2/MbeO5qc3PAckdYVHYMsVU5OM+sCmiWjCbdKKniih8ul1aB38aTa5/LA2hMft5kDCXD51U7mOZUR59rYn0x/Zq4Gbf+t7GaN9FRvUXUPCG9QEBfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PqefceYasfUNMoQdmPt1zcf72IbJUeLD0WCLaDvnmH0=; b=EMch4PDhaLoEkZsKu/8PxSmBRVFwnOaPpK11SGlXzoIDPFq86OFJX50c064dbUtonlIv5QylNlSoP6+fof9mG+2q27bRwEF0oTIJN7BBQcBGIGrz1C4IbzRG4NSPnwPaggtzTEk/0dtRc0qiMSJfBHi3WfpE7XRmsXQOSAHno34= Received: from CY4PR10MB1718.namprd10.prod.outlook.com (2603:10b6:910:9::17) by CY4PR10MB1720.namprd10.prod.outlook.com (2603:10b6:910:a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.19; Tue, 26 Jan 2021 20:09:33 +0000 Received: from CY4PR10MB1718.namprd10.prod.outlook.com ([fe80::39dc:6ba7:9397:cb6]) by CY4PR10MB1718.namprd10.prod.outlook.com ([fe80::39dc:6ba7:9397:cb6%6]) with mapi id 15.20.3784.019; Tue, 26 Jan 2021 20:09:33 +0000 Subject: Re: [edk2-devel] [PATCH v5 0/9] support CPU hot-unplug To: Laszlo Ersek Cc: devel@edk2.groups.io, imammedo@redhat.com, boris.ostrovsky@oracle.com References: <20210126064440.299596-1-ankur.a.arora@oracle.com> From: "Ankur Arora" Message-ID: Date: Tue, 26 Jan 2021 12:09:29 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 In-Reply-To: X-Originating-IP: [148.87.23.7] X-ClientProxiedBy: MW4PR03CA0390.namprd03.prod.outlook.com (2603:10b6:303:114::35) To CY4PR10MB1718.namprd10.prod.outlook.com (2603:10b6:910:9::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.108] (148.87.23.7) by MW4PR03CA0390.namprd03.prod.outlook.com (2603:10b6:303:114::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12 via Frontend Transport; Tue, 26 Jan 2021 20:09:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c9485d9-07e7-4d9a-5f23-08d8c2364b97 X-MS-TrafficTypeDiagnostic: CY4PR10MB1720: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BxdfAhlM3ptfKAkcHs3PANtzcCBaxkJqCJjHe9f8SYuVAOXuGgOjFdfBzVTn2XYnE7e32Fg1op5eeLcheHCMjlhyUdL1unilAt471LtGlCF281P3bC8Ae+MhMTa7JtyVD7egHyXv7C8njchcpNwtfCnzdacuSrLwxZnPYQv2HXko4A9wciSzUAmSoCK7/1nMF7TZoGPU4g0kQ4UZvejya942mLFbnAVUEW2vUKfD8Jm5xOJ4qUSxjbFNjt/pNs+0SwLJrv4Bt6JiSinKnXSvBPzAp3iHoigRylk4gm59QidXPv6y060MHWOwNngT2/9/xWOI5mb/jM7iUkBa5NvZk3c90eNO+rTmmbRccpKBFmuZLe88JINdCnDbkCStrPaiP2/35+7ny2VxXP5N32QwptwR6uyuOMrDccxJI0QBnRfjiSkF2leq/dHSoAxen5klNKxxIH8a2p6p2vhINN5cHZ0tNGdD8R0FHSH2uU3wxPP+8WMb7/gOihsuwyBp4tySk0lQgh0xCCXqXWY0MNcpCGTYKnbxGb87oBxY6HvghAg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR10MB1718.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(396003)(39860400002)(346002)(366004)(31696002)(53546011)(66946007)(66476007)(86362001)(66556008)(31686004)(8936002)(186003)(16576012)(4326008)(16526019)(8676002)(36756003)(2616005)(956004)(5660300002)(2906002)(83380400001)(19627235002)(26005)(478600001)(316002)(966005)(6486002)(6916009)(107886003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZksvZXcxejBYZ3VaMW9ESHlNWXNHdENnUVFKckcxY1dZNmFBRVJPNzRCQlA4?= =?utf-8?B?WUgzUW5VVEp5STNCMkhzZFppZmNRWE9oRzFNK1p0NHAySGNrUG00RDkxSVVE?= =?utf-8?B?Q245alhCNCswdnVwd09jWXVOY0ZVbjJJNElVb01QSW9kWDIxZE5neTJxWE11?= =?utf-8?B?Vk04RjNCQTFuemZNSDA0QW1udzRYZDhXZ04vTGExaENBTnZkdjhJcDNYNHYr?= =?utf-8?B?aHNRRTJMaVdVZUVxb0Jza2dubjFac3BRTmFuSzIzc1B5WnZGOERsRkZSMVRB?= =?utf-8?B?UzlqQk03eFZhMkdpdHpieERiNjZMVkpYeG1wQ1FIVFdzOXpyY3NSY2pQL1d3?= =?utf-8?B?TElEd0lTZm5PR0NzMXJOQ2syTHcweTdpWUplb3FVTVFTS1lzM0xvWjAyUDRV?= =?utf-8?B?Y05UWTYwY3JTcmwxUXE0NlcvcWxWUStrRWVoREZsK2hjd29IUHFSeld2RDlO?= =?utf-8?B?dVVQQ0dxbEtLTGZrQnlrOW5PWGlieGNjQyttT0k4UFBPNWdOblRwZ044U2ln?= =?utf-8?B?ZXp6UnZ1RkxDQXdpZU5nNjhYN2NvOTczZHNBZnRqdUtMUzR0ekl5QjJrRTJ5?= =?utf-8?B?aU82VkNLejFQRFFNSjVaOFYvcFJtSW5wL2o1eUhidjNkWUE5MkVzNVhmYzN3?= =?utf-8?B?OWNkRGpVN0xjVi9lUE1pTWh0VVY5Uk9FUGhFU0o2TVd6ZFFHYnpHbUtrb3l0?= =?utf-8?B?Y1kwdDczbGYrSEtCbHRtbzV6TkVyMTV0ZjhNSWQ2bUNiWXhXeHdzSzN0RVlX?= =?utf-8?B?SWdiZmpHREhaV1FUTUpWZkdpWnVtYjM3K3FaWFZkV2p4aW5VOWlxWmdBZk9a?= =?utf-8?B?S2djTnVrMjBab2VyWE5rWWpTT2kyTHJXYUI4dkJYOE5EdjQ0dFd2K04rbEJH?= =?utf-8?B?eXpXM1pWK1RPRnBYN1VIbSt4SHNTUEgvN1J3Qk1DVnN0c3lIUS9IOVdlOEhz?= =?utf-8?B?RkkrUk0xcmVrZnJuY1ByWi90aW9uemJpbVRFUWI4Rk1xd25UQWVvcXl5djZT?= =?utf-8?B?RkZWeDl2MlBjTVNXZnd6UkVaWUdmV0hkVmZzZG12MFc0Y1JKeTJtd0pHVUJz?= =?utf-8?B?VFpTTlkrLzk2RlBad3VKMndoOEpXU01hNnpsMUZnWFZ0MGhsdnJCNmRjM1lJ?= =?utf-8?B?TlNTdGVWTkU5UnhQM0ttdFVpK0FqUkFwd1krVU54d0tNUU5yV0lEUVBmeXcy?= =?utf-8?B?SWlOZDl1c3ZVUTRDK0lNVWdzS2p3OHlWb2NhUnJ0a21EMWJlbEJaZ1lKQnBP?= =?utf-8?B?a0d6alJiSHdzVEhEOUh3Q3ZCUVgrdTdwcjg4S0ptdjJrTzQ4aDdJbnBwM0dV?= =?utf-8?B?a2h2azFMUmJJOW1NdWEwbWxPSkEyUll0NzJhcFJMVmpqcm56eDNzclpnNFJh?= =?utf-8?B?cDdrMEV2VHc3dVhMRTVsdkFpaGV0aXBoai90c3RkaVVyc1ZZRWF5SEkwL2kz?= =?utf-8?Q?zDadb37f?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c9485d9-07e7-4d9a-5f23-08d8c2364b97 X-MS-Exchange-CrossTenant-AuthSource: CY4PR10MB1718.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2021 20:09:32.8847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ofPFsxYGD6GvMQA6OO7R8VSEkbslUkuRx8aevNKGQQ8he/1aKxqflfWbzITOjkEiqnIwTA2ig9uNJyOswQ2nc7lVEFr+m9tLFFJ49zh7ItY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1720 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9876 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 adultscore=0 mlxscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101260103 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9876 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101260102 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2021-01-26 10:03 a.m., Laszlo Ersek wrote: > Hi Ankur, > > On 01/26/21 07:44, Ankur Arora wrote: >> Hi, >> >> This series adds support for CPU hot-unplug with OVMF. >> >> Please see this in conjunction with the QEMU secureboot hot-unplug v2 >> series posted here (now upstreamed): >> https://lore.kernel.org/qemu-devel/20201207140739.3829993-1-imammedo@redhat.com/ >> >> Patches 1 and 3, >> ("OvmfPkg/CpuHotplugSmm: refactor hotplug logic") >> ("OvmfPkg/CpuHotplugSmm: add Qemu Cpu Status helper") >> are either refactors or add support functions. >> >> OvmfPkg/CpuHotplugSmm: introduce UnplugCpus() >> OvmfPkg/CpuHotplugSmm: add CpuEject() >> OvmfPkg/CpuHotplugSmm: add worker to do CPU ejection >> >> Patch 2 and 9, >> ("OvmfPkg/CpuHotplugSmm: collect hot-unplug events") >> ("OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug") >> handle the QEMU protocol logic for collection of CPU hot-unplug events >> or the protocol negotiation. >> >> Patch 4, >> ("OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()") >> adds the MMI logic for CPU hot-unplug handling and informing >> the PiSmmCpuDxeSmm of CPU removal. >> >> Patches 5 and 6, >> ("OvmfPkg/CpuHotplugSmm: define CPU_HOT_EJECT_DATA") >> ("OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state") >> sets up state for doing the CPU ejection as part of hot-unplug. >> >> Patches 7, and 8, >> ("OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()") >> ("OvmfPkg/CpuHotplugSmm: add worker to do CPU ejection") >> add the CPU ejection logic. >> >> Testing (with QEMU 5.2.50): >> - Stable with randomized CPU plug/unplug (guest maxcpus=1,8,128) >> - Synthetic tests with simultaneous multi CPU hot-unplug >> - Negotiation with/without CPU hotplug enabled >> >> Also at: >> github.com/terminus/edk2/ hot-unplug-v5 >> >> Changelog: >> v5: >> - fixes ECC errors (all but one in "OvmfPkg/CpuHotplugSmm: add >> add Qemu Cpu Status helper"). >> >> v4: >> - Gets rid of unnecessary UefiCpuPkg changes >> URL: https://patchew.org/EDK2/20210118063457.358581-1-ankur.a.arora@oracle.com/ >> >> v3: >> - Use a saner PCD based interface to share state between PiSmmCpuDxeSmm >> and OvmfPkg/CpuHotplugSmm >> - Cleaner split of the hot-unplug code >> URL: https://patchew.org/EDK2/20210115074533.277448-1-ankur.a.arora@oracle.com/ >> >> v2: >> - Do the ejection via SmmCpuFeaturesRendezvousExit() >> URL: https://patchew.org/EDK2/20210107195515.106158-1-ankur.a.arora@oracle.com/ >> >> RFC: >> URL: https://patchew.org/EDK2/20201208053432.2690694-1-ankur.a.arora@oracle.com/ >> >> >> Please review. >> >> Thanks >> Ankur >> >> Ankur Arora (9): >> OvmfPkg/CpuHotplugSmm: refactor hotplug logic >> OvmfPkg/CpuHotplugSmm: collect hot-unplug events >> OvmfPkg/CpuHotplugSmm: add Qemu Cpu Status helper >> OvmfPkg/CpuHotplugSmm: introduce UnplugCpus() >> OvmfPkg/CpuHotplugSmm: define CPU_HOT_EJECT_DATA >> OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state >> OvmfPkg/CpuHotplugSmm: add CpuEject() >> OvmfPkg/CpuHotplugSmm: add worker to do CPU ejection >> OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug >> >> OvmfPkg/OvmfPkg.dec | 10 + >> OvmfPkg/CpuHotplugSmm/CpuHotplugSmm.inf | 1 + >> .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 3 + >> OvmfPkg/CpuHotplugSmm/QemuCpuhp.h | 6 + >> OvmfPkg/Include/IndustryStandard/QemuCpuHotplug.h | 2 + >> OvmfPkg/Include/Library/CpuHotEjectData.h | 32 ++ >> OvmfPkg/CpuHotplugSmm/CpuHotplug.c | 450 ++++++++++++++++----- >> OvmfPkg/CpuHotplugSmm/QemuCpuhp.c | 57 ++- >> .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 68 ++++ >> OvmfPkg/SmmControl2Dxe/SmiFeatures.c | 25 +- >> 10 files changed, 552 insertions(+), 102 deletions(-) >> create mode 100644 OvmfPkg/Include/Library/CpuHotEjectData.h >> > > This series is still mal-formatted; for some reason it has one too many > CRs per line. > > Did you try to set up the "base64" or the "8bit" > content-transfer-encoding? The emails reflected through the list are > still "quoted-printable". Confirming that this was the problem. And, thanks for debugging this. Ankur > > Anyway, I managed to apply the patches with some trickery on a local branch. > > Thanks > Laszlo >