From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.2314.1587978237795190647 for ; Mon, 27 Apr 2020 02:03:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dCRsS0RQ; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587978236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NkEATkGUssXnyxUPq5X8JoiYy5yYzmFiOfx1wZT7KAM=; b=dCRsS0RQDkq2Cv40pbCBwDVk0sDhMVCF7mY+lDhEm4VR5GiIrZXGKAk/gn6dZOxzoFrmPt ku6tyoZVVIhlG/PS0m3Rt5Xc2eBHZWPKusexGTvpSUWd4DrIayrlr/tSsb1xochZIb51ZA ljiCa/zA8EnwDjUtAsykYJJGK+nQmSo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-57-AVeicY32NlqfIHvxeEHXvA-1; Mon, 27 Apr 2020 05:03:54 -0400 X-MC-Unique: AVeicY32NlqfIHvxeEHXvA-1 Received: by mail-wr1-f70.google.com with SMTP id a3so10205728wro.1 for ; Mon, 27 Apr 2020 02:03:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NkEATkGUssXnyxUPq5X8JoiYy5yYzmFiOfx1wZT7KAM=; b=WgjlWXgtBziTeQTdmy6yMb6lZ0smtU1C9QMFafOTk7qXBvgxboJvN0eQ6x8jQiSefm BC5xISvg7wq7kIw7h7LWriGzCsQL9OxWKEqWw82CnGdHV0DEVIhRW1xu0plnoV3EaTgJ P4DyKI+DV+uROyR1i/KnguleGXWNBKaXOxBQ0rfJ9K06wpEHqLAvsmUA6GOcTztCtz0u G7ii4LBGhLp6+ZreXfuDPFjHyXahsIt/ju39MSntkw3GK8wbtyKqHSeJMCPfdp56KznP x1/GIjkF8Eup1SB986OGTKfC41McP1sJuOhHVMAFbhD7XSMka9c5xdPvNOztUlI2FMEa CpLg== X-Gm-Message-State: AGi0PuZetNAJcJLP1utxR/h7+0GVxUHP+XZ+DB/Gxjx3x4QwdHFkFQE+ Q0P0mjkwnEAK9P9ZM9EQd24XE4Ed9q2mPeuLbLBnhz0kYi4Ixh4PBE7zAUsObV6JFgIdK22K8I4 zFGXYnmfhNcVSFw== X-Received: by 2002:a5d:6688:: with SMTP id l8mr27955749wru.179.1587978233853; Mon, 27 Apr 2020 02:03:53 -0700 (PDT) X-Google-Smtp-Source: APiQypK/ii5rqCEv41n03hxyLnXIhvxedJn1j/crA9+VujiSJDKXzuiyfWgKqR9H0IabTLwua+JbtA== X-Received: by 2002:a5d:6688:: with SMTP id l8mr27955723wru.179.1587978233631; Mon, 27 Apr 2020 02:03:53 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (137.red-88-21-205.staticip.rima-tde.net. [88.21.205.137]) by smtp.gmail.com with ESMTPSA id d5sm20301839wrp.44.2020.04.27.02.03.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2020 02:03:52 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull To: devel@edk2.groups.io, rebecca@bsdio.com, Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Andrew Fish , Leif Lindholm , Michael D Kinney References: <20200424182914.138915-1-rebecca@bsdio.com> <20200424182914.138915-3-rebecca@bsdio.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Mon, 27 Apr 2020 11:03:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200424182914.138915-3-rebecca@bsdio.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Hi Rebecca, On 4/24/20 8:29 PM, Rebecca Cran wrote: > Add a null implementation library for QemuFwCfgLib, in order to > support building PciHostBridgeLib for bhyve. > > Signed-off-by: Rebecca Cran > --- > .../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 37 ++++ > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c | 209 ++++++++++++++++++ > 2 files changed, 246 insertions(+) > create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf > create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c > > diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf > new file mode 100644 > index 0000000000..09f86c2b02 > --- /dev/null > +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf > @@ -0,0 +1,37 @@ > +## @file > +# > +# Stateful, implicitly initialized fw_cfg library. > +# > +# Copyright (C) 2013, Red Hat, Inc. > +# Copyright (c) 2008 - 2012, Intel Corporation. All rights reserved.
> +# Copyright (c) 2017, AMD Incorporated. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION = 0x00010005 > + BASE_NAME = QemuFwCfgLibNull > + FILE_GUID = B9D1A1F2-01E2-4732-982D-C7F9ED51AC6B > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = QemuFwCfgLib > + > +# > +# The following information is for reference only and not required by the build tools. > +# > +# VALID_ARCHITECTURES = IA32 X64 > +# > + > +[Sources] > + QemuFwCfgLibInternal.h > + QemuFwCfgNull.c > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + OvmfPkg/OvmfPkg.dec > + > +[LibraryClasses] > + DebugLib > diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c > new file mode 100644 > index 0000000000..e2cc5f3406 > --- /dev/null > +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c > @@ -0,0 +1,209 @@ > +/** @file > + > + Stateful and implicitly initialized fw_cfg library implementation. > + > + Copyright (C) 2013, Red Hat, Inc. > + Copyright (c) 2011 - 2013, Intel Corporation. All rights reserved.
> + Copyright (c) 2017, Advanced Micro Devices. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#include > +#include > +#include Don't you need ? > + > +/** > + Returns a boolean indicating if the firmware configuration interface > + is available or not. > + > + This function may change fw_cfg state. > + > + @retval TRUE The interface is available > + @retval FALSE The interface is not available > + > +**/ > +BOOLEAN > +EFIAPI > +QemuFwCfgIsAvailable ( > + VOID > + ) > +{ > + return FALSE; > +} [...]