From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4C71521FD73D4 for ; Tue, 6 Mar 2018 21:49:23 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2018 21:55:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,434,1515484800"; d="scan'208";a="25856632" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.44]) ([10.239.9.44]) by fmsmga002.fm.intel.com with ESMTP; 06 Mar 2018 21:55:36 -0800 To: Dandan Bi , edk2-devel@lists.01.org Cc: Eric Dong , Laszlo Ersek References: <1520402018-7012-1-git-send-email-dandan.bi@intel.com> From: "Ni, Ruiyu" Message-ID: Date: Wed, 7 Mar 2018 13:55:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1520402018-7012-1-git-send-email-dandan.bi@intel.com> Subject: Re: [patch] UefiCpuPkg/CpuCommonFeaturesLib: Fix coding style issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 05:49:23 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/7/2018 1:53 PM, Dandan Bi wrote: > Boolean values do not need to use explicit comparisons > to TRUE or FALSE. > > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > index cc64dbb..27ca911 100644 > --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c > @@ -138,11 +138,11 @@ McaInitialize ( > ) > { > MSR_IA32_MCG_CAP_REGISTER McgCap; > UINT32 BankIndex; > > - if (State == TRUE) { > + if (State) { > McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP); > for (BankIndex = 0; BankIndex < (UINT32) McgCap.Bits.Count; BankIndex++) { > CPU_REGISTER_TABLE_WRITE64 ( > ProcessorNumber, > Msr, > Reviewed-by: Ruiyu Ni -- Thanks, Ray