Hi Laszlo,

If the SPEC and BaseTools are ready, then then that's fine with me.

Reviewed-by: Chao Li <lichao@loongson.cn>

Thanks,
Chao

On 2024/3/5 20:01, Laszlo Ersek wrote:

<Library/PeimEntryPoint.h> declares a bogus
ProcessLibraryConstructorList() for LoongArchQemuPkg's SEC module. Rely on
AutoGen for (properly) declaring ProcessLibraryConstructorList(). Update
the call.

Build-tested with:

  build -a LOONGARCH64 -b DEBUG \
    -m Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf \
    -p Platform/Loongson/LoongArchQemuPkg/Loongson.dsc -t GCC5

Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Chao Li <lichao@loongson.cn>
Cc: Xianglai li <lixianglai@loongson.cn>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf | 2 +-
 Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c   | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf
index c0d5439d5379..bb86c7c77471 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf
+++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf
@@ -8,7 +8,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 1.30
   BASE_NAME                      = SecMain
   FILE_GUID                      = 57d02d4f-5a5d-4bfa-b7d6-ba0a4d2c72ce
   MODULE_TYPE                    = SEC
diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
index 3f1998c48c12..50d898859a99 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
+++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
@@ -9,7 +9,6 @@
 
 #include <PiPei.h>
 
-#include <Library/PeimEntryPoint.h>
 #include <Library/BaseLib.h>
 #include <Library/DebugLib.h>
 #include <Library/BaseMemoryLib.h>
@@ -378,7 +377,7 @@ SecCoreStartupWithStack (
 
   DEBUG ((DEBUG_INFO, "Entering C environment\n"));
 
-  ProcessLibraryConstructorList (NULL, NULL);
+  ProcessLibraryConstructorList ();
 
   DEBUG ((DEBUG_INFO,
     "SecCoreStartupWithStack (0x%lx, 0x%lx)\n",

_._,_._,_

Groups.io Links:

You receive all messages sent to this group.

_._,_._,_