From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3249E740048 for ; Tue, 5 Mar 2024 13:06:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0sIT/OixFxnTV4OLbCZfHuaWQCpQbb662YwxT27IWKk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1709643967; v=1; b=dd124GBV0HSGDTnHXammGo8cTQDvAv86Q+SGvDzsV6rq0WbUA9l6I0CItLy73tVXxMgXrjPi 8+TC5alHQmXmyoGE1sRSeIuP9o4igi3pHa6/SvsRlKdc4TTzNE1Ck7EEcTyaa4pMdgpsjWC1d6H l7eXoaF5XhfyLwaVe2dnkVi0= X-Received: by 127.0.0.2 with SMTP id XRVgYY7687511xvr6D0FGh6O; Tue, 05 Mar 2024 05:06:07 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.22077.1709643965998127570 for ; Tue, 05 Mar 2024 05:06:06 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8DxWPC3GOdl28gUAA--.51795S3; Tue, 05 Mar 2024 21:05:59 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxjhO0GOdlQZVOAA--.21770S3; Tue, 05 Mar 2024 21:05:56 +0800 (CST) Message-ID: Date: Tue, 5 Mar 2024 21:05:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms PATCH v2 3/4] LoongArchQemuPkg: auto-gen & fix SEC ProcessLibraryConstructorList() decl To: devel@edk2.groups.io, lersek@redhat.com Cc: Bibo Mao , Xianglai li References: <20240305120126.70259-1-lersek@redhat.com> <20240305120126.70259-4-lersek@redhat.com> From: "Chao Li" In-Reply-To: <20240305120126.70259-4-lersek@redhat.com> X-CM-TRANSID: AQAAf8AxjhO0GOdlQZVOAA--.21770S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAHCGXm1+YDSgADs2 X-Coremail-Antispam: 1Uk129KBj93XoWxWFyrKFWfWw4fAF1kZFW5urX_yoW5Gw13pF 1DuanrKr48tr4jvwn5t34jgF4v9rZ0kr4qqrs0k34a9as7J3Wqq3yjvF48Z3y7ZrWFya40 qry0gw4UW3WjgagCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUyGb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67 AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26F4UJVW0owAS0I0E0xvYzxvE52x0 82IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMcIj6xIIjxv20xvE14v26r1j6r18Mc Ij6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41l7480 Y4vEI4kI2Ix0rVAqx4xJMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI 8I3I0E5I8CrVAFwI0_JrI_JrWlx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AK xVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI 8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280 aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43 ZEXa7IU1Au4UUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dVBzd9VZCGfQQnQmxKSwo1e3x7686176AA= Content-Type: multipart/alternative; boundary="------------MxnsqeY7djp32jmvRuVfmRqJ" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=dd124GBV; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------MxnsqeY7djp32jmvRuVfmRqJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Laszlo, If the SPEC and BaseTools are ready, then then that's fine with me. Reviewed-by: Chao Li Thanks, Chao On 2024/3/5 20:01, Laszlo Ersek wrote: > declares a bogus > ProcessLibraryConstructorList() for LoongArchQemuPkg's SEC module. Rely o= n > AutoGen for (properly) declaring ProcessLibraryConstructorList(). Update > the call. > > Build-tested with: > > build -a LOONGARCH64 -b DEBUG \ > -m Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf \ > -p Platform/Loongson/LoongArchQemuPkg/Loongson.dsc -t GCC5 > > Cc: Bibo Mao > Cc: Chao Li > Cc: Xianglai li > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 > Signed-off-by: Laszlo Ersek > --- > Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf | 2 +- > Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf b/Platfor= m/Loongson/LoongArchQemuPkg/Sec/SecMain.inf > index c0d5439d5379..bb86c7c77471 100644 > --- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf > +++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf > @@ -8,7 +8,7 @@ > ## > =20 > [Defines] > - INF_VERSION =3D 0x00010005 > + INF_VERSION =3D 1.30 > BASE_NAME =3D SecMain > FILE_GUID =3D 57d02d4f-5a5d-4bfa-b7d6-ba0a4d2c72= ce > MODULE_TYPE =3D SEC > diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c b/Platform/= Loongson/LoongArchQemuPkg/Sec/SecMain.c > index 3f1998c48c12..50d898859a99 100644 > --- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c > +++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c > @@ -9,7 +9,6 @@ > =20 > #include > =20 > -#include > #include > #include > #include > @@ -378,7 +377,7 @@ SecCoreStartupWithStack ( > =20 > DEBUG ((DEBUG_INFO, "Entering C environment\n")); > =20 > - ProcessLibraryConstructorList (NULL, NULL); > + ProcessLibraryConstructorList (); > =20 > DEBUG ((DEBUG_INFO, > "SecCoreStartupWithStack (0x%lx, 0x%lx)\n", > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116390): https://edk2.groups.io/g/devel/message/116390 Mute This Topic: https://groups.io/mt/104742760/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------MxnsqeY7djp32jmvRuVfmRqJ Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Laszlo,

If the SPEC and BaseTools are ready, then then that's fine with me.

Reviewed-by: Chao Li <lichao@loongson.cn>


=
Thanks,
Chao
On 2024/3/5 20:01, Laszlo Ersek wrote: 
<Library/PeimEntryPoint.h&g=
t; declares a bogus
ProcessLibraryConstructorList() for LoongArchQemuPkg's SEC module. Rely on
AutoGen for (properly) declaring ProcessLibraryConstructorList(). Update
the call.

Build-tested with:

  build -a LOONGARCH64 -b DEBUG \
    -m Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf \
    -p Platform/Loongson/LoongArchQemuPkg/Loongson.dsc -t GCC5

Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Chao Li <lichao@loongson.cn>
Cc: Xianglai li <lixianglai@loongson.cn>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=
=3D990
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf | 2 +-
 Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c   | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf b/Platform/=
Loongson/LoongArchQemuPkg/Sec/SecMain.inf
index c0d5439d5379..bb86c7c77471 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf
+++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.inf
@@ -8,7 +8,7 @@
 ##
=20
 [Defines]
-  INF_VERSION                    =3D 0x00010005
+  INF_VERSION                    =3D 1.30
   BASE_NAME                      =3D SecMain
   FILE_GUID                      =3D 57d02d4f-5a5d-4bfa-b7d6-ba0a4d2c72ce
   MODULE_TYPE                    =3D SEC
diff --git a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c b/Platform/Lo=
ongson/LoongArchQemuPkg/Sec/SecMain.c
index 3f1998c48c12..50d898859a99 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
+++ b/Platform/Loongson/LoongArchQemuPkg/Sec/SecMain.c
@@ -9,7 +9,6 @@
=20
 #include <PiPei.h>
=20
-#include <Library/PeimEntryPoint.h>
 #include <Library/BaseLib.h>
 #include <Library/DebugLib.h>
 #include <Library/BaseMemoryLib.h>
@@ -378,7 +377,7 @@ SecCoreStartupWithStack (
=20
   DEBUG ((DEBUG_INFO, "Entering C environment\n"));
=20
-  ProcessLibraryConstructorList (NULL, NULL);
+  ProcessLibraryConstructorList ();
=20
   DEBUG ((DEBUG_INFO,
     "SecCoreStartupWithStack (0x%lx, 0x%lx)\n",
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#116390) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------MxnsqeY7djp32jmvRuVfmRqJ--