From: athierry@redhat.com
To: devel@edk2.groups.io
Cc: Adrien Thierry <athierry@redhat.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <leif@nuviainc.com>, Pete Batard <pete@akeo.ie>
Subject: [edk2-platforms PATCH] Platform/RaspberryPi: Fix miniuart base address and length
Date: Fri, 3 Dec 2021 12:32:10 -0500 [thread overview]
Message-ID: <d717552ff526733d409774ce01fbca1e3d855eb1.1638552624.git.athierry@redhat.com> (raw)
Make sure the base address and length of the Raspberry Pi miniuart set
in the ACPI tables match those in the official device tree. This will be
useful for adding ACPI support to the miniuart Linux driver.
Signed-off-by: Adrien Thierry <athierry@redhat.com>
---
.../RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.h | 2 +-
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.h b/Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.h
index 24c0e5fd56..65e8aeb17c 100644
--- a/Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.h
+++ b/Platform/RaspberryPi/Library/DualSerialPortLib/DualSerialPortLib.h
@@ -17,7 +17,7 @@
#include <IndustryStandard/Bcm2836Gpio.h>
#define PL011_UART_REGISTER_BASE BCM2836_PL011_UART_BASE_ADDRESS
-#define MINI_UART_REGISTER_BASE (BCM2836_MINI_UART_BASE_ADDRESS + 0x40)
+#define MINI_UART_REGISTER_BASE BCM2836_MINI_UART_BASE_ADDRESS
//
// 16550 UART register offsets and bitfields
diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h
index a930c64af3..f34dddd58d 100644
--- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h
+++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h
@@ -81,9 +81,9 @@
#define BCM2836_PL011_UART_BASE_ADDRESS (BCM2836_SOC_REGISTERS + BCM2836_PL011_UART_OFFSET)
#define BCM2836_PL011_UART_LENGTH 0x00001000
-#define BCM2836_MINI_UART_OFFSET 0x00215000
+#define BCM2836_MINI_UART_OFFSET 0x00215040
#define BCM2836_MINI_UART_BASE_ADDRESS (BCM2836_SOC_REGISTERS + BCM2836_MINI_UART_OFFSET)
-#define BCM2836_MINI_UART_LENGTH 0x00000070
+#define BCM2836_MINI_UART_LENGTH 0x00000040
#define BCM2836_I2C0_OFFSET 0x00205000
#define BCM2836_I2C0_BASE_ADDRESS (BCM2836_SOC_REGISTERS + BCM2836_I2C0_OFFSET)
--
2.31.1
next reply other threads:[~2021-12-03 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 17:32 athierry [this message]
2021-12-13 14:54 ` [edk2-platforms PATCH] Platform/RaspberryPi: Fix miniuart base address and length Adrien Thierry
2021-12-13 15:14 ` Ard Biesheuvel
2021-12-13 19:17 ` Andrei Warkentin
2021-12-14 5:39 ` [edk2-devel] " Jeremy Linton
2021-12-14 6:21 ` Andrei Warkentin
2021-12-14 13:35 ` Samer El-Haj-Mahmoud
2021-12-14 16:42 ` Jeremy Linton
2021-12-14 22:49 ` Adrien Thierry
2021-12-15 23:53 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d717552ff526733d409774ce01fbca1e3d855eb1.1638552624.git.athierry@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox