From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 30 Jul 2019 05:34:59 -0700 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 724AA3078A3C; Tue, 30 Jul 2019 12:34:59 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 164BB5D6B2; Tue, 30 Jul 2019 12:34:57 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v4 31/35] OvmfPkg/PlatformBootManagerLib: Use a Xen console for ConOut/ConIn To: devel@edk2.groups.io, anthony.perard@citrix.com Cc: Julien Grall , xen-devel@lists.xenproject.org, Jordan Justen , Ard Biesheuvel References: <20190729153944.24239-1-anthony.perard@citrix.com> <20190729153944.24239-32-anthony.perard@citrix.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 30 Jul 2019 14:34:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190729153944.24239-32-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 30 Jul 2019 12:34:59 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/29/19 17:39, Anthony PERARD wrote: > On a Xen PVH guest, none of the existing serial or console interface > works, so we add a new one, based on XenConsoleSerialPortLib, and > implemented via SerialDxe. > > That is a simple console implementation that can works on both PVH > guest and HVM guests, even if it rarely going to be use on HVM. > > Have PlatformBootManagerLib look for the new console, when running as a > Xen guest. > > Since we use VENDOR_UART_DEVICE_PATH, fix its description and coding > style. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Reviewed-by: Laszlo Ersek > --- > > Notes: > v4: > - instead of creating a new XEN_CONSOLE_DEVICE_PATH, use the existing > VENDOR_UART_DEVICE_PATH. And explain why VENDOR_UART_DEVICE_PATH > changed in the commit message. > > v3: > - removed PciSioSerialDxe and IsaSerialDxe from OvmfXen, since they > would not be used, maybe, to check. > - some coding style fix > > - not changed: PciSioSerialDxe: even if we add SerialDxe, we still needs > PciSioSerialDxe to have OVMF use the emulated serial port on HVM. > > v2: > - Use MdeModulePkg/Universal/SerialDxe instead of something new. > - Have PlatformInitializeConsole() look for it by using the > known-in-advance device path for the xen console in the > PLATFORM_CONSOLE_CONNECT_ENTRY. > > OvmfPkg/OvmfXen.dsc | 4 ++ > OvmfPkg/OvmfXen.fdf | 1 + > .../PlatformBootManagerLib.inf | 4 ++ > .../PlatformBootManagerLib/BdsPlatform.h | 1 + > .../PlatformBootManagerLib/BdsPlatform.c | 3 +- > .../PlatformBootManagerLib/PlatformData.c | 49 +++++++++++++++++-- > 6 files changed, 58 insertions(+), 4 deletions(-) Looks good, thanks. Laszlo