Re: [edk2-devel] [PATCH v4 10/13] OvmfPkg/MptScsiDxe: Initialize hardware

["Laszlo Ersek" <lersek@redhat.com>]

On 04/14/20 19:38, Nikita Leshenko wrote:

> diff --git a/OvmfPkg/Include/IndustryStandard/FusionMptScsi.h b/OvmfPkg/Include/IndustryStandard/FusionMptScsi.h

Some notes related to edk2's CamelCase style:

> +#pragma pack (1)
> +typedef struct {
> +  UINT8     WhoInit;
> +  UINT8     Reserved1;
> +  UINT8     MessageLength;
> +  UINT8     Function;
> +  UINT8     Flags;
> +  UINT8     MaxDevices;
> +  UINT8     MaxBuses;
> +  UINT8     MessageFlags;
> +  UINT32    MessageContext;
> +  UINT16    Reserved2;
> +  UINT16    IOCStatus;
> +  UINT32    IOCLogInfo;

(13) In both above fields, please spell "IOC" as "Ioc".

> +} MPT_IO_CONTROLLER_INIT_REPLY;
> +
> +typedef struct {
> +  UINT8     TargetID;

(14) TargetId

> +  UINT8     Bus;
> +  UINT8     ChainOffset;
> +  UINT8     Function;
> +  UINT8     CDBLength;

(15) CdbLength

> +  UINT8     SenseBufferLength;
> +  UINT8     Reserved;
> +  UINT8     MessageFlags;
> +  UINT32    MessageContext;
> +  UINT8     LUN[8];

(16) Lun

> +  UINT32    Control;
> +  UINT8     CDB[16];

(17) Cdb

> +  UINT32    DataLength;
> +  UINT32    SenseBufferLowAddress;
> +} MPT_SCSI_IO_REQUEST;
> +
> +typedef struct {
> +  UINT32    Length:             24;
> +  UINT32    EndOfList:          1;
> +  UINT32    Is64BitAddress:     1;
> +  //
> +  // True when the buffer contains data to be transfered. Otherwise it's the
> +  // destination buffer
> +  //
> +  UINT32    BufferContainsData: 1;
> +  UINT32    LocalAddress:       1;
> +  UINT32    ElementType:        2;
> +  UINT32    EndOfBuffer:        1;
> +  UINT32    LastElement:        1;
> +  UINT64    DataBufferAddress;
> +} MPT_SG_ENTRY_SIMPLE;
> +#pragma pack ()
> +
> +typedef union {
> +#pragma pack (1)
> +  struct {
> +    UINT8   TargetID;

(18) TargetId

> +    UINT8   Bus;
> +    UINT8   MessageLength;
> +    UINT8   Function;
> +    UINT8   CDBLength;

(19) CdbLength

> +    UINT8   SenseBufferLength;
> +    UINT8   Reserved;
> +    UINT8   MessageFlags;
> +    UINT32  MessageContext;
> +    UINT8   SCSIStatus;
> +    UINT8   SCSIState;

(20) In both fields, s/SCSI/Scsi/ please

> +    UINT16  IOCStatus;
> +    UINT32  IOCLogInfo;

(21) Same as (13)

> +    UINT32  TransferCount;
> +    UINT32  SenseCount;
> +    UINT32  ResponseInfo;
> +  } Data;
> +#pragma pack ()
> +  UINT64 Uint64; // 8 byte alignment required by HW
> +} MPT_SCSI_IO_ERROR_REPLY;
> +
>  #endif // __FUSION_MPT_SCSI_H__

Thanks!
Laszlo